👍 brunoerg approved a pull request: "test: Return dict in MiniWallet::send_to"
(https://github.com/bitcoin/bitcoin/pull/27640#pullrequestreview-1424649982)
crACK faf4315c88d8c81c2ff84870bc81aef3cf719816

💬 furszy commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1545855845)
Is it me or DrahtBot is typing as a human?

💬 RandyMcMillan commented on pull request "p2p: skip netgroup diversity follow-up":
(https://github.com/bitcoin/bitcoin/pull/27467#discussion_r1192468422)
`to be two`

https://github.com/jonatack/bitcoin/pull/1

💬 jamesob commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1545856135)
I've done a number of runs here with some combination of indexing and pruning, and I think this is in about as good a shape as it can be, with the following caveat:

When using assumeutxo with pruning and indexing, the snapshot chainstate cannot be pruned because of how we handle indexing during bg sync. Since the snapshot chainstate isn't indexed until after the background sync completes (in order to avoid out-of-order indexation), we aren't able to prune the snapshot chainstate based upon th
...

✅ sangaman closed a pull request: "init: add MALLOC_ARENA_MAX=1 to systemd"
(https://github.com/bitcoin/bitcoin/pull/27641)

💬 jonatack commented on pull request "p2p: skip netgroup diversity follow-up":
(https://github.com/bitcoin/bitcoin/pull/27467#discussion_r1192498239)
Thank you for looking -- "to" (as in "toward") is correct here.

💬 mzumsande commented on pull request "Relay own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/27509#discussion_r1192502249)
> Any reason not to send `TX` directly and avoid the `INV`, like below?

It has been suggested to stop processing unrequested TXs messages, see #21224. While that didn't make it, the idea is still floating around. If bitcoin core itself started relying on unrequested msgs being processed, that would probably kill it once for all.
Maybe that's ok, but we should make sure that there aren't alternative clients that would ignore unrequested TXs.

📝 sangaman opened a pull request: "init: add MALLOC_ARENA_MAX=1 to systemd"
(https://github.com/bitcoin/bitcoin/pull/27642)
This adds the MALLOC_ARENA_MAX=1 environment variable as suggested in https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-memory.md#linux-specific to the systemd service file definition.

Without this env var, memory usage can grow significantly especially when rpcthreads is increased above its default value.

Closes https://github.com/bitcoin/bitcoin/issues/24542.

I have tested this change myself with positive results after dealing with memory consumption issues for a long time usi
...

📝 Madgregory123 opened a pull request: "25.x"
(https://github.com/bitcoin/bitcoin/pull/27643)


Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improve coverage are always welcome.
* All other changes should have accomp
...

💬 sangaman commented on pull request "init: add MALLOC_ARENA_MAX=1 to systemd":
(https://github.com/bitcoin/bitcoin/pull/27641#issuecomment-1545908173)
Looks like I goofed somehow when editing my branch to remove some whitespace and that resulted in closing this PR, that's what I get for creating the original commit in the github.com text editor. Reopened in #27642.

💬 Madgregory123 commented on pull request "25.x":
(https://github.com/bitcoin/bitcoin/pull/27643#issuecomment-1545908176)
🤔

✅ fanquake closed a pull request: "25.x"
(https://github.com/bitcoin/bitcoin/pull/27643)

📝 fanquake locked a pull request: "25.x"
(https://github.com/bitcoin/bitcoin/pull/27643)


Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improve coverage are always welcome.
* All other changes should have accomp
...

📝 fanquake locked a pull request: "init: add MALLOC_ARENA_MAX=1 to systemd"
(https://github.com/bitcoin/bitcoin/pull/27641)
This adds the `MALLOC_ARENA_MAX=1` environment variable as suggested in https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-memory.md#linux-specific to the systemd service file definition.

Without this env var, memory usage can grow significantly especially when `rpcthreads` is increased above its default value.

Closes #24542.

I have tested this change myself with positive results after dealing with memory consumption issues for a long time using systemd on a 8GB RAM raspi4. I fig
...

💬 sangaman commented on issue "Slow memory leak in v22.0?":
(https://github.com/bitcoin/bitcoin/issues/24542#issuecomment-1545911064)

> Seems like it would be better to add it to the documentation if anything...

It is in the documentation already at https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-memory.md
The behavior was introduced to increase CPU locality of allocated memory and performance with concurrent allocation, so this setting could in theory reduce performance. However, in Bitcoin Core very little parallel allocation happens, so the impact is expected to be small or absent.

💬 willcl-ark commented on pull request "init: add MALLOC_ARENA_MAX=1 to systemd":
(https://github.com/bitcoin/bitcoin/pull/27642#issuecomment-1545912961)
I don't believe this affects the majority of users (where the two pools per core default works fine), so I don't see why we'd update the default service file like this.

We have documentation that describes what to do to reduce memory in the event that one wants to do that?

💬 sangaman commented on pull request "init: add MALLOC_ARENA_MAX=1 to systemd":
(https://github.com/bitcoin/bitcoin/pull/27642#issuecomment-1545934901)
> I don't believe this affects the majority of users (where the two pools per core default works fine), so I don't see why we'd update the default service file like this.
>
> We have documentation that describes what to do to reduce memory in the event that one wants to do that?

Maybe it's my fault for not digging into the docs more but I went over a year with inflated, unpredictable RAM usage and even occasional OOM crashes on a machine that I wouldn't consider particularly memory-constra
...

🤔 pinheadmz reviewed a pull request: "Introduce field element and group element classes to test_framework/key.py"
(https://github.com/bitcoin/bitcoin/pull/26222#pullrequestreview-1424673767)
concept ACK

Did as much code review as my tiny brain could handle. I agree that this implementation is easy to read and follow. I checked as much as I could against [NIST params](https://www.secg.org/sec2-v2.pdf) and equations from [Guide to Elliptic Curve Cryptography](https://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.394.3037&rep=rep1&type=pdf)

Comparing run time of `feature_taproot.py` between master and branch, over a few trials with and without RAM disk, the new code only cost
...

💬 pinheadmz commented on pull request "Introduce field element and group element classes to test_framework/key.py":
(https://github.com/bitcoin/bitcoin/pull/26222#discussion_r1192479969)
Not using hex here?

📝 fanquake converted_to_draft a pull request: "Bugfix: Skip tests for tools not being built"
(https://github.com/bitcoin/bitcoin/pull/23027)