🚀 fanquake merged a pull request: "refactor: Remove redundant and confusing calls to IsArgSet"
(https://github.com/bitcoin/bitcoin/pull/31896)
(https://github.com/bitcoin/bitcoin/pull/31896)
✅ fanquake closed an issue: "build: depends cross-compile using Clang fails"
(https://github.com/bitcoin/bitcoin/issues/31748)
(https://github.com/bitcoin/bitcoin/issues/31748)
🚀 fanquake merged a pull request: "depends: set `CMAKE_*_COMPILER_TARGET` in toolchain"
(https://github.com/bitcoin/bitcoin/pull/31849)
(https://github.com/bitcoin/bitcoin/pull/31849)
✅ fanquake closed an issue: "fuzz: psbt_base64_decode fails on Windows"
(https://github.com/bitcoin/bitcoin/issues/32135)
(https://github.com/bitcoin/bitcoin/issues/32135)
🚀 fanquake merged a pull request: "fuzz: extract unsequenced operations with side-effects"
(https://github.com/bitcoin/bitcoin/pull/32141)
(https://github.com/bitcoin/bitcoin/pull/32141)
✅ fanquake closed an issue: "qa: `p2p_ibd_stalling.py --v1transport` fails"
(https://github.com/bitcoin/bitcoin/issues/32090)
(https://github.com/bitcoin/bitcoin/issues/32090)
🚀 fanquake merged a pull request: "test: fix intermittent timeout in p2p_ibd_stalling.py"
(https://github.com/bitcoin/bitcoin/pull/32148)
(https://github.com/bitcoin/bitcoin/pull/32148)
👍 laanwj approved a pull request: "contrib: document asmap-tool commands more thoroughly"
(https://github.com/bitcoin/bitcoin/pull/32110#pullrequestreview-2720156962)
Thanks, LGTM now
ACK 704573e016ac40e7cae00a84a9ba532a760e043e
(https://github.com/bitcoin/bitcoin/pull/32110#pullrequestreview-2720156962)
Thanks, LGTM now
ACK 704573e016ac40e7cae00a84a9ba532a760e043e
👍 fanquake approved a pull request: "cmake: Add `NO_CACHE_IF_FAILED` option for checking linker flags"
(https://github.com/bitcoin/bitcoin/pull/32027#pullrequestreview-2720160842)
ACK 52ac17757eed5056d03a6861bcc24ee864c17385
(https://github.com/bitcoin/bitcoin/pull/32027#pullrequestreview-2720160842)
ACK 52ac17757eed5056d03a6861bcc24ee864c17385
🚀 fanquake merged a pull request: "cmake: Add `NO_CACHE_IF_FAILED` option for checking linker flags"
(https://github.com/bitcoin/bitcoin/pull/32027)
(https://github.com/bitcoin/bitcoin/pull/32027)
🚀 fanquake merged a pull request: "doc: Update comments for AreInputsStandard to match code"
(https://github.com/bitcoin/bitcoin/pull/32129)
(https://github.com/bitcoin/bitcoin/pull/32129)
✅ fanquake closed an issue: "ci: failure in interface_usdt_utxocache.py"
(https://github.com/bitcoin/bitcoin/issues/31951)
(https://github.com/bitcoin/bitcoin/issues/31951)
🚀 fanquake merged a pull request: "Accept unordered tracepoints in interface_usdt_utxocache.py"
(https://github.com/bitcoin/bitcoin/pull/32101)
(https://github.com/bitcoin/bitcoin/pull/32101)
🚀 fanquake merged a pull request: "doc: clarify the documentation of `Assume` assertion"
(https://github.com/bitcoin/bitcoin/pull/32100)
(https://github.com/bitcoin/bitcoin/pull/32100)
💬 laanwj commented on issue "Enable PCP by default?":
(https://github.com/bitcoin/bitcoin/issues/31663#issuecomment-2757073396)
i've added protonVPN port forwarding to the table (see https://github.com/bitcoin/bitcoin/issues/32052#issuecomment-2750762673 for details), they don't support PCP at the moment but the NATPMP fallback works
(https://github.com/bitcoin/bitcoin/issues/31663#issuecomment-2757073396)
i've added protonVPN port forwarding to the table (see https://github.com/bitcoin/bitcoin/issues/32052#issuecomment-2750762673 for details), they don't support PCP at the moment but the NATPMP fallback works
💬 fanquake commented on pull request "build: Drop option to disable hardening.":
(https://github.com/bitcoin/bitcoin/pull/32071#issuecomment-2757080132)
cc @theuni
(https://github.com/bitcoin/bitcoin/pull/32071#issuecomment-2757080132)
cc @theuni
💬 maflcko commented on issue "intermittent issue in wallet_upgradewallet.py AssertionError: [node 2] Node returned unexpected exit code (1) vs (0) when stopping":
(https://github.com/bitcoin/bitcoin/issues/30798#issuecomment-2757100714)
reproduced locally: https://drahtbot.space/temp_scratch/w_up_w.tar.zstd
(https://github.com/bitcoin/bitcoin/issues/30798#issuecomment-2757100714)
reproduced locally: https://drahtbot.space/temp_scratch/w_up_w.tar.zstd
💬 hebasto commented on pull request "cmake: Avoid fuzzer "multiple definition of `main'" errors":
(https://github.com/bitcoin/bitcoin/pull/31992#issuecomment-2757262611)
Friendly ping @dergoegge and @maflcko ;)
(https://github.com/bitcoin/bitcoin/pull/31992#issuecomment-2757262611)
Friendly ping @dergoegge and @maflcko ;)
💬 maflcko commented on pull request "cmake: Avoid fuzzer "multiple definition of `main'" errors":
(https://github.com/bitcoin/bitcoin/pull/31992#issuecomment-2757270888)
seems fine to do this, if all prior use cases and configurations continue to work fine without any changes or breakages
(https://github.com/bitcoin/bitcoin/pull/31992#issuecomment-2757270888)
seems fine to do this, if all prior use cases and configurations continue to work fine without any changes or breakages
🤔 willcl-ark reviewed a pull request: "depends: set `CMAKE_*_COMPILER_TARGET` in toolchain"
(https://github.com/bitcoin/bitcoin/pull/31849#pullrequestreview-2720582928)
Post-merge ACK 963355037fe78eb4fbdda8631ac05a7b07fcec8c
<details>
<summary> guix hashes</summary>
```
will@ubuntu in …/src/core/bitcoin on clang_cross_toolchain:refs/pull/31849/head [$?] via △ v3.31.6 : 🐍 (core) took 1h23m21s
$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
02c610ee1471cc2671588a999e5ef914547cd55352ddc084faf7a9a55d79098b guix-build-963355037fe7/output/aarch64-linux-gnu/SHA256SUMS.part
11c177952
...
(https://github.com/bitcoin/bitcoin/pull/31849#pullrequestreview-2720582928)
Post-merge ACK 963355037fe78eb4fbdda8631ac05a7b07fcec8c
<details>
<summary> guix hashes</summary>
```
will@ubuntu in …/src/core/bitcoin on clang_cross_toolchain:refs/pull/31849/head [$?] via △ v3.31.6 : 🐍 (core) took 1h23m21s
$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
02c610ee1471cc2671588a999e5ef914547cd55352ddc084faf7a9a55d79098b guix-build-963355037fe7/output/aarch64-linux-gnu/SHA256SUMS.part
11c177952
...