💬 sr-gi commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#issuecomment-1544692524)
> > > > `txinfo.m_time <= mempool_req`
> >
> >
> > > This condition is checking that our inv (`txinfo`) is more recent than the last `mempool_req`, meaning that once a mempool request has been processed the peer can request any transaction from our mempool.
> >
> >
> > I don't get it. Is it not that the condition is checking whether `txinfo` is _older_ than the last `mempool_req`? In that case the transaction has been part of the `MEMPOOL` reply, so we have sent an `INV` about it.
>
...

📝 theStack opened a pull request: "test: avoid sporadic MINIMALDATA failure in feature_taproot.py (fixes #27595)"
(https://github.com/bitcoin/bitcoin/pull/27631)
The functional test feature_taproot.py fails in some rare cases on the execution of the following `"branched_codesep"` spending script (can be reproduced via `$ ./test/functional/feature_taproot.py --randomseed 9048710178866422833` on master / 137a98c5a22e058ed7a7997a0a4dbd75301de51e):

https://github.com/bitcoin/bitcoin/blob/9d85c03620bf660cfa7d13080f5c0b191579cbc3/test/functional/feature_taproot.py#L741


The problem occurs if the first data-push (having random content with a random lengt
...

💬 ismaelsadeeq commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1191715247)
Sure :+1: , fixed.

💬 sipa commented on pull request "test: avoid sporadic MINIMALDATA failure in feature_taproot.py (fixes #27595)":
(https://github.com/bitcoin/bitcoin/pull/27631#issuecomment-1544738994)
Concept ACK

🤔 stickies-v reviewed a pull request: "net: Allow inbound whitebind connections to more aggresivey evict peers when slots are full"
(https://github.com/bitcoin/bitcoin/pull/27600#pullrequestreview-1423467785)
Concept ACK, makes sense to prioritize whitelisted peers. Will review more in-depth soon.

💬 stickies-v commented on pull request "net: Allow inbound whitebind connections to more aggresivey evict peers when slots are full":
(https://github.com/bitcoin/bitcoin/pull/27600#discussion_r1191709646)
nit
```suggestion
return force ? std::make_optional(last_out.id) : std::nullopt;
```

💬 jonatack commented on pull request "net: Allow inbound whitebind connections to more aggresivey evict peers when slots are full":
(https://github.com/bitcoin/bitcoin/pull/27600#discussion_r1191732820)
Not sure, but IIRC last time I looked RVO wasn't working with a ternary.

💬 ryanofsky commented on pull request "Multiprocess bitcoin":
(https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-1544783273)
Thanks @Sjors. I've tried a lot of things and have not been able to reproduce the crash exactly, but the log you posted was helpful, and I could reproduce similar error output by adding an extra call from bitcoin-node to bitcoin-wallet that sleeps in bitcoin-wallet, and then manual killing `bitcoin-wallet` process. When I do that I see similar `kj::Exception` errors on the bitcoin-node main thread and bitcoin-node b-capnp-loop thread like in your log. In your log the exact errors are `kj/async
...

📝 jonatack opened a pull request: "Raise on invalid -debug and -loglevel config options"
(https://github.com/bitcoin/bitcoin/pull/27632)
and rename BCLog::BLOCKSTORE to BLOCKSTORAGE so the enum is the same as its value like the other BCLog enums.

Per discussion in bitcoin-core-dev IRC today from https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2023-05-11#921458.

💬 amitiuttarwar commented on pull request "rpc: add 'getnetmsgstats', new rpc to view network message statistics":
(https://github.com/bitcoin/bitcoin/pull/27534#discussion_r1191790448)
@satsie is the concern of having a dummy value like `NET_MAX` that it could fall out of

🤔 amitiuttarwar reviewed a pull request: "rpc: add 'getnetmsgstats', new rpc to view network message statistics"
(https://github.com/bitcoin/bitcoin/pull/27534#pullrequestreview-1423599288)
approach ACK. did a high-level review and left a few small comments

💬 amitiuttarwar commented on pull request "rpc: add 'getnetmsgstats', new rpc to view network message statistics":
(https://github.com/bitcoin/bitcoin/pull/27534#discussion_r1191793368)
this function should handle if `index > NUM_NET_MESSAGE_TYPES`

💬 amitiuttarwar commented on pull request "rpc: add 'getnetmsgstats', new rpc to view network message statistics":
(https://github.com/bitcoin/bitcoin/pull/27534#discussion_r1191798171)
nit: I'm kinda confused by this spacing. could it be a bit more legible to have them just line up instead of cascade?

💬 amitiuttarwar commented on pull request "rpc: add 'getnetmsgstats', new rpc to view network message statistics":
(https://github.com/bitcoin/bitcoin/pull/27534#discussion_r1191801732)
cc @dergoegge

💬 amitiuttarwar commented on pull request "rpc: add 'getnetmsgstats', new rpc to view network message statistics":
(https://github.com/bitcoin/bitcoin/pull/27534#discussion_r1191790800)
@satsie is the concern of having a dummy value like `NET_MAX` that it could fall out of sync if enum values start being explicitly assigned?

💬 amitiuttarwar commented on pull request "rpc: add 'getnetmsgstats', new rpc to view network message statistics":
(https://github.com/bitcoin/bitcoin/pull/27534#discussion_r1191806474)
adding it to the `NetMsgType` namespace makes sense to me- the current name essentially manually namespaces it.

RE `allNetMessageTypes` array - either way seems OK to me. from a quick glance at callers, I don't think you'd have to add much special case logic if you added it in the array, so that could be nice

💬 amitiuttarwar commented on pull request "rpc: add 'getnetmsgstats', new rpc to view network message statistics":
(https://github.com/bitcoin/bitcoin/pull/27534#discussion_r1191804470)
+1 I think having this code in a separate compilation unit + forward declaration of the class would be sufficient for `net.h`, then `net.cpp` could include the full file

💬 ajtowns commented on pull request "p2p: Stop relaying non-mempool txs":
(https://github.com/bitcoin/bitcoin/pull/27625#issuecomment-1544947585)
> > we could trim mapRelay before their scheduled expiry time has actually been reached.
>
> Sounds like this would either degrade compact block relay when the mempool is full due to trimming `mapRelay`, or turn one DoS (OOM) into another DoS (lost fee income) due to trimming valid mempool txs? And if you use separate and dedicated size limits for `mapRelay` and the mempool, it might be easier to keep them separate data structures?

The memory usage of `mapRelay` depends on whether the tran
...

⚠️ ETCorps opened an issue: "[> ETH Price: $1,800.33 (-1.80%)"
(https://github.com/bitcoin/bitcoin/issues/27633)
[> ETH Price: $1,800.33 (-1.80%)
>
>
>
> Transaction Details
>
> SALES! Get 15% off (one-time) for any new API Pro subscription. Code:ESFP15Q223
> Overview
> Internal Txns
> Logs (9)
> State
> Comments
> Transaction Hash:
> 0x273894b35d8c30d32e1ffa22ee6aa320cc9f55f2adbba0583594ed47c031f6f6
> Status:
> Success
> Block:
> 17046833
> 193887 Block Confirmations
> Timestamp:
> 27 days 7 hrs ago (Apr-14-2023 05:21:11 PM +UTC)|Confirmed within 30 secs
> Transaction Action:
> Supply
> 391,662,390,
...

✅ achow101 closed an issue: "[> ETH Price: $1,800.33 (-1.80%)"
(https://github.com/bitcoin/bitcoin/issues/27633)