Bitcoin Core Github
42 subscribers
125K links
Download Telegram
πŸ’¬ rkrux commented on pull request "test: Add encodable PUSHDATA1 examples to feature_taproot":
(https://github.com/bitcoin/bitcoin/pull/32114#issuecomment-2751321498)
The new design also allows for using different keys and pubs in different tests instead of using one set in all the tests.
The overall commentary looks great, the commits can be cleaned up.
πŸ’¬ instagibbs commented on pull request "test: Add encodable PUSHDATA1 examples to feature_taproot":
(https://github.com/bitcoin/bitcoin/pull/32114#issuecomment-2751328611)
@rkrux done thanks
πŸ’¬ Sjors commented on pull request "multiprocess: add bitcoin-mine test program":
(https://github.com/bitcoin/bitcoin/pull/30437#issuecomment-2751357927)
ACK 0ec78961915da141b9c68a39ec0ebd5091c13be0
πŸ’¬ laanwj commented on pull request "build: Remove bitness suffix from Windows installer":
(https://github.com/bitcoin/bitcoin/pull/32132#issuecomment-2751358384)
> Was thinking x86_64-windows-mingw would be sufficient, and on par with x86_64-linux-gnu. What sets them in stone?

gcc (and the mingw project itself, in this case). The idea is that every OS-architecture combination has a unique, unambiguous tuple. In practice there is some ambiguity (this is the magic `config.sub` deals with, to "normalize" it) but it's not a good thing to mess with in general.
πŸ‘ hodlinator approved a pull request: "Move some tests and documentation from testnet3 to testnet4"
(https://github.com/bitcoin/bitcoin/pull/32096#pullrequestreview-2713883417)
re-ACK 2ee474d33f3340084a458e7348f5358fcaea8911

* Moved assumeutxo functional test [from 31974](https://github.com/bitcoin/bitcoin/pull/31974#discussion_r2010985584).
* Dropped duplicated argsman_test.cpp lines.
πŸ’¬ brunoerg commented on pull request "contrib: document asmap-tool commands more thoroughly":
(https://github.com/bitcoin/bitcoin/pull/32110#issuecomment-2751359340)
Concept ACK
πŸ’¬ brunoerg commented on pull request "contrib: document asmap-tool commands more thoroughly":
(https://github.com/bitcoin/bitcoin/pull/32110#discussion_r2012179499)
75b145eef57053f24bc58531163408271d17eb59: nit: I think it would be great to mention that `diff` may take a while to execute. In my last try it took around 2 minutes and doesn't show anything until the end.
πŸ’¬ brunoerg commented on pull request "contrib: document asmap-tool commands more thoroughly":
(https://github.com/bitcoin/bitcoin/pull/32110#discussion_r2012184495)
75b145eef57053f24bc58531163408271d17eb59: It is `diff_addrs`, not `diff-addrs`.
πŸ’¬ maflcko commented on pull request "multiprocess: add bitcoin-mine test program":
(https://github.com/bitcoin/bitcoin/pull/30437#discussion_r2012199249)
nit if you re-touch: Probably a typo in the program name?

```suggestion
# Copyright (c) 2024-present The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""Test bitcoin-mine"""
```
πŸ’¬ maflcko commented on pull request "test: replace hardcoded fee with node relay fee based calculation":
(https://github.com/bitcoin/bitcoin/pull/32058#issuecomment-2751403431)
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
πŸ’¬ jurraca commented on pull request "contrib: document asmap-tool commands more thoroughly":
(https://github.com/bitcoin/bitcoin/pull/32110#discussion_r2012238385)
fixed in [a799327](https://github.com/bitcoin/bitcoin/pull/32110/commits/a799327f6bc3efe0509a811ff02f5d705a041f29)
πŸ“ glozow opened a pull request: "[29.x] backports and 29.0rc3"
(https://github.com/bitcoin/bitcoin/pull/32136)
Draft for now, collecting backports. Then will add final changes for 29.0rc3.
πŸ’¬ glozow commented on pull request "test: avoid disk space warning for non-regtest":
(https://github.com/bitcoin/bitcoin/pull/32057#issuecomment-2751484977)
Backported in #32136
πŸ’¬ sipa commented on pull request "contrib: document asmap-tool commands more thoroughly":
(https://github.com/bitcoin/bitcoin/pull/32110#issuecomment-2751486951)
Perhaps it's worth mentioning that `asmap.py` runs about 5x faster under `pypy3` than under `python3`?
⚠️ Kotarou10 opened an issue: "Accedence and the Resonance Energy for Bitcoin."
(https://github.com/bitcoin/bitcoin/issues/32137)
### Please describe the feature you'd like to see added.

Below, I present a reflection on Bitcoin Core as mirrored through its "ex mere negativis nihil sequitur; ex mere particularibus nihil sequitur"

[NIST.FIPS.205.ipd.pdf](https://github.com/user-attachments/files/19434960/NIST.FIPS.205.ipd.pdf)

The content is divided into three core sections: Purpose, Concrete Mathematical Proof, and Use Case. This exploration addresses the switch from SHA-256 to SHA-512, the concept of resonance energyβ€”d
...
βœ… fanquake closed an issue: "Accedence and the Resonance Energy for Bitcoin."
(https://github.com/bitcoin/bitcoin/issues/32137)
:lock: fanquake locked an issue: "Accedence and the Resonance Energy for Bitcoin."
(https://github.com/bitcoin/bitcoin/issues/32137)
βœ… maflcko closed an issue: "wallet: rpc: `settxfee` sets the wallet feerate not fee"
(https://github.com/bitcoin/bitcoin/issues/31088)
πŸ’¬ maflcko commented on issue "wallet: rpc: `settxfee` sets the wallet feerate not fee":
(https://github.com/bitcoin/bitcoin/issues/31088#issuecomment-2751553560)
Closing for now, after deprecation
πŸ‘ laanwj approved a pull request: "build: Switch to Qt 6"
(https://github.com/bitcoin/bitcoin/pull/30997#pullrequestreview-2714168472)
Code review and tested ACK 3bf637c693a5893df4b117078421747a696a252b
imo it would be fairly useful to merge this early in the 30.x window, to make sure any unexpected problems that might come up can be fixed in time.