:lock: hebasto locked an issue: "."
(https://github.com/bitcoin-core/gui/issues/859)

💬 hebasto commented on pull request "build: Remove bitness suffix from Windows installer":
(https://github.com/bitcoin/bitcoin/pull/32132#discussion_r2010337872)
Considering the condition that triggers this message, the latter is correct. However, the condition itself may now be outdated.

This code does not affect the UX, so there's no harm in leaving it as is for now.

💬 ryanofsky commented on pull request "fuzz: enable running fuzz test cases in Debug mode":
(https://github.com/bitcoin/bitcoin/pull/32113#discussion_r2010343421)
In commit "fuzz: enable running fuzz test cases in Debug mode" (1718da848a0a7591f0eab086e159f1e9e0f2c59b)

I don't think I the understand reason for ABORT_ON_FAILED_ASSUME affecting return value of EnableFuzzDeterminism(), and trying to force non-determinism when assume doesn't abort. It seems like this behavior might cause the `assert(EnableFuzzDeterminism())` to fail, but also this code might just be easier to understand if fuzz determinism only depended on the FUZZING_BUILD_MODE_UNSAFE_FOR_
...

👍 ryanofsky approved a pull request: "fuzz: enable running fuzz test cases in Debug mode"
(https://github.com/bitcoin/bitcoin/pull/32113#pullrequestreview-2710675645)
Concept & approach ACK. The changes here all seem reasonable and I get abstractly how it could be useful to run fuzz binary without fuzzing compile options and instrumentation. But I only have a vague idea of how this should get used in practice. It would be helpful to add some documentation to https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md to say how/when you could run the fuzz binary in debug mode, and when you would might want to set the FUZZ_NONDETERMINISM environment variable
...

💬 rkrux commented on pull request "test: Add encodable PUSHDATA1 examples to feature_taproot":
(https://github.com/bitcoin/bitcoin/pull/32114#issuecomment-2748411943)
Nice, I like this approach. Besides making it easier to onboard by adding the commentaty, it also helps in not increasing the size of the `spenders_taproot_active`, which is more than 500 lines long already.

I will look at it in detail soon.

💬 rkrux commented on pull request "rpc: Support v3 raw transactions creation":
(https://github.com/bitcoin/bitcoin/pull/31936#discussion_r2010354181)
Related, see https://github.com/bitcoin/bitcoin/pull/31936#discussion_r2010279314

💬 instagibbs commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#issuecomment-2748427065)
reACK b2ea3656481b4196acaf6a1b5f3949a9ba4cf48f

nice doc improvements

`git range-diff master 1601906941fa559ebbee7898453fa77f4606ad38 b2ea3656481b4196acaf6a1b5f3949a9ba4cf48f`

💬 1440000bytes commented on issue "bitcoind crash with corrupt wallet.dat":
(https://github.com/bitcoin/bitcoin/issues/32124#issuecomment-2748493704)
Steps to reproduce:

1. Run bitcoind with `bitcoind -regtest`
2. Create a new wallet which loads on startup with ` bitcoin-cli -regtest -named createwallet wallet_name=w1 load_on_startup=true`
3. Download sqlite binary: https://www.sqlite.org/download.html
4. Exit bitcoind
5. Use arbitrary SQL statements for wallet db with sqlite binary. Use the below SQL statements for the error mentioned in OP.

```
$ sqlite3 "wallet.dat file path"
SQLite version 3.49.1 2025-02-18 13:38:58
Ent
...

👍 hodlinator approved a pull request: "doc: clarify the documentation of `Assume` assertion"
(https://github.com/bitcoin/bitcoin/pull/32100#pullrequestreview-2710762015)
re-ACK 329a0dcdafe05002f662e8737a76bfdeaba9a3ed

💬 Sjors commented on pull request "OP_CHECKCONTRACTVERIFY":
(https://github.com/bitcoin/bitcoin/pull/32080#discussion_r2010404646)
Here's a branch with the above patch https://github.com/bitcoin/bitcoin/commit/f87381ae825b7c0263f0b30d2f93e2687c8fca6f, but also renaming:
- `unvault_{privkey, pubkey_xonly}` to `hot_{privkey,pk,pubkey_xonly}`
- `recover_{privkey, pubkey_xonly}` to `cold_{privkey,pk,pubkey_xonly}`

With that terminology I find it easier to follow: using their hot key the user unvaults into their withdrawal address, which can be recovered using their cold key.

💬 ryanofsky commented on pull request "cmake: Avoid fuzzer "multiple definition of `main'" errors":
(https://github.com/bitcoin/bitcoin/pull/31992#issuecomment-2748542650)
Updated 34aeb70748ef8ee186fe53f0db2580a445452dc2 -> 60d2afe65484f755d99191bb650b9f9a784ee2c2 ([`pr/subtree-fuzz.1`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree-fuzz.1) -> [`pr/subtree-fuzz.2`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree-fuzz.2), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/subtree-fuzz.1..pr/subtree-fuzz.2)) moving `FUZZ_LIBS` to the `fuzzer_interface` target

---

re: https://github.com/bitcoin/bitcoin/pull/31992#issuecomment-2747463640
...

💬 martinus commented on pull request "Draft: CCoinMap Experiments":
(https://github.com/bitcoin/bitcoin/pull/32128#issuecomment-2748556101)
> Welcome back @martinus, we missed you! :) I will measure these changes separately until 890k blocks soon. I have included this change a tracking PR where we have other similar experiments: #32043

I have not done any programming in half a year, looking forward to getting back :)

💬 VolodymyrBg commented on pull request "test: Add support for mainnet addresses in address_to_scriptpubkey":
(https://github.com/bitcoin/bitcoin/pull/32060#issuecomment-2748559368)
@maflcko
@davidgumberg
could you check it please when you have a free moment?

📝 fjahr opened a pull request: "RFC: Accept non-std transactions in Testnet4 by default again"
(https://github.com/bitcoin/bitcoin/pull/32133)
Feel free to ignore the code, just looking for conceptual discussion for now.

It used to be the case that we would accept non-std transactions by default in Testnet3 but this was changed in #28354 because RSK had shot themselves in the foot because of this (see #26348). In discussions on Testnet4 [this came up again as a potential feature](https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2041139129) but the idea to revert this was rejected then because the 20-min exception rule coul
...

💬 0xB10C commented on pull request "Accept unordered tracepoints in interface_usdt_utxocache.py":
(https://github.com/bitcoin/bitcoin/pull/32101#issuecomment-2748614134)
ACK 693d1e2f54baa0d5e407153f79b2f98385e6b8d9

I successfully ran the changed test a couple of times and the code changes look good to me.

That this behavior works as intended can be tested with this patch:

```patch
diff --git a/test/functional/interface_usdt_utxocache.py b/test/functional/interface_usdt_utxocache.py
index d4213d5020..94ec23c51a 100755
--- a/test/functional/interface_usdt_utxocache.py
+++ b/test/functional/interface_usdt_utxocache.py
@@ -326,6 +326,7 @@ class UTXOCac
...

🤔 pablomartin4btc reviewed a pull request: "wallet: Disable creating and loading legacy wallets"
(https://github.com/bitcoin/bitcoin/pull/31250#pullrequestreview-2710888718)
Adding more details from my previous [comment](https://github.com/bitcoin/bitcoin/pull/31250#pullrequestreview-2705644380):
- The legacy wallet is being created as a `sqlite` DB (the unsupported legacy-sqlite mentioned [above](https://github.com/bitcoin/bitcoin/pull/31250#discussion_r1983725941)):
https://github.com/bitcoin/bitcoin/blob/32a522f2d825957f0c85d7b4ea9185a053b018e3/src/wallet/walletdb.cpp#L1471-L1477
- In `getwalletinfo` we could see `"format": "sqlite",`;

💬 maflcko commented on pull request "RFC: Accept non-std transactions in Testnet4 by default again":
(https://github.com/bitcoin/bitcoin/pull/32133#issuecomment-2748639276)
> the question is why we are not also moving back on this setting, too, so that people can use non-std transactions on Testnet4.

I don't think this is enough. There are many non-std transactions that will still be rejected, even if this is turned on. One example is https://github.com/bitcoin/bitcoin/pull/29843.



> If you want to make sure your tx propagates on mainnet then use `testmempoolaccept` on a mainnet node.

I don't think this is enough either. There are many transaction topol
...

💬 fjahr commented on pull request "policy: Allow non-standard scripts with -acceptnonstdtxn=1 (test nets only)":
(https://github.com/bitcoin/bitcoin/pull/29843#issuecomment-2748654660)
Concept ACK

💬 hebasto commented on issue "v29.0 Testing":
(https://github.com/bitcoin/bitcoin/issues/32052#issuecomment-2748663483)
I've completed testing the v29.0.0rc2 release candidate on Windows 11 Pro 24H2, using the default Edge browser for downloading.

All signatures look good. The browser flagged [`bitcoin-29.0rc2-win64-setup-unsigned.exe`](https://bitcoincore.org/bin/bitcoin-core-29.0/test.rc2/bitcoin-29.0rc2-win64-setup-unsigned.exe), which is expected:


The binaries `bitcoind.exe`, `bitcoin-cli.exe`, `bitcoin-qt.exe` and `t
...

💬 fjahr commented on pull request "Move some tests and documentation from testnet3 to testnet4":
(https://github.com/bitcoin/bitcoin/pull/32096#discussion_r2010500449)
Seems fine either way. I don't see why this has to be testnet in the example here.