📝 hebasto opened a pull request: "build: Remove bitness suffix from Windows installer"
(https://github.com/bitcoin/bitcoin/pull/32132)
Since support for 32-bit Windows has been dropped, the suffix is no longer necessary.

👍 instagibbs approved a pull request: "tests: improves tapscript unit tests"
(https://github.com/bitcoin/bitcoin/pull/31640#pullrequestreview-2710575039)
LGTM dfea1fae92a1fd8ba0bbf5d52a37baffa28f9f8f

I think having "fail-fast", developer-friendly tests is a fine motivation. And nothing stops me/you from porting novel things to the functional framework for additional coverage.

The additional sanity check added in first commit also helps protect against test regressions in the future.

Hand-checked the scripts, seems correct.

💬 ismaelsadeeq commented on pull request "doc: clarify the documentation of `Assume` assertion":
(https://github.com/bitcoin/bitcoin/pull/32100#discussion_r2010300389)
Fixed!

💬 l0rinc commented on pull request "build: Remove bitness suffix from Windows installer":
(https://github.com/bitcoin/bitcoin/pull/32132#discussion_r2010308034)
Does the message below (written 11 years ago) still make sense now that there's no "64 bit version Windows installer", just a "Windows installer"?

> MessageBox MB_OK|MB_ICONSTOP "Cannot install 64-bit version on a 32-bit system."

🤔 l0rinc reviewed a pull request: "build: Remove bitness suffix from Windows installer"
(https://github.com/bitcoin/bitcoin/pull/32132#pullrequestreview-2710614237)
utACK fb2b05b1259d3e69e6e675adfa30b429424c7625

💬 darosior commented on pull request "fuzz: avoid returning non-conforming results from FuzzedSock::GetSockName()":
(https://github.com/bitcoin/bitcoin/pull/32109#issuecomment-2748345445)
Leaning toward Concept NACK.

OP is suggesting to provide more guarantees in our mocked `getsockname` than the one used in production. On its face i think the motivation is misguided and we should rather aim for having stricter tests to make sure our code is robust as well as to surface some edge case we might have not considered. If the reason for opening this PR is that the change in #31676 led to some fuzz crashes, then i would say it works as intended. Instead of working around the crash i
...

💬 l0rinc commented on pull request "doc: clarify the documentation of `Assume` assertion":
(https://github.com/bitcoin/bitcoin/pull/32100#issuecomment-2748351872)
ACK 329a0dcdafe05002f662e8737a76bfdeaba9a3ed

⚠️ mahmoudeA opened an issue: "Mahmoud amin elgder"
(https://github.com/bitcoin-core/gui/issues/859)
https://github.com/bitcoin-core/gui/blob/770d39a37652d40885533fecce37e9f71cc0d051/src/test/README.md?plain=1#L25

✅ mahmoudeA closed an issue: "Mahmoud amin elgder"
(https://github.com/bitcoin-core/gui/issues/859)

📝 mahmoudeA opened a pull request: "Mahmoud amin elgder Update libbitcoinkernel.pc.in"
(https://github.com/bitcoin-core/gui/pull/860)
https://github.com/bitcoin-core/gui/issues/859

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

...

✅ hebasto closed a pull request: "Mahmoud amin elgder Update libbitcoinkernel.pc.in"
(https://github.com/bitcoin-core/gui/pull/860)

📝 hebasto locked a pull request: "Mahmoud amin elgder Update libbitcoinkernel.pc.in"
(https://github.com/bitcoin-core/gui/pull/860)
https://github.com/bitcoin-core/gui/issues/859

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

...

:lock: hebasto locked an issue: "."
(https://github.com/bitcoin-core/gui/issues/859)

💬 hebasto commented on pull request "build: Remove bitness suffix from Windows installer":
(https://github.com/bitcoin/bitcoin/pull/32132#discussion_r2010337872)
Considering the condition that triggers this message, the latter is correct. However, the condition itself may now be outdated.

This code does not affect the UX, so there's no harm in leaving it as is for now.

💬 ryanofsky commented on pull request "fuzz: enable running fuzz test cases in Debug mode":
(https://github.com/bitcoin/bitcoin/pull/32113#discussion_r2010343421)
In commit "fuzz: enable running fuzz test cases in Debug mode" (1718da848a0a7591f0eab086e159f1e9e0f2c59b)

I don't think I the understand reason for ABORT_ON_FAILED_ASSUME affecting return value of EnableFuzzDeterminism(), and trying to force non-determinism when assume doesn't abort. It seems like this behavior might cause the `assert(EnableFuzzDeterminism())` to fail, but also this code might just be easier to understand if fuzz determinism only depended on the FUZZING_BUILD_MODE_UNSAFE_FOR_
...

👍 ryanofsky approved a pull request: "fuzz: enable running fuzz test cases in Debug mode"
(https://github.com/bitcoin/bitcoin/pull/32113#pullrequestreview-2710675645)
Concept & approach ACK. The changes here all seem reasonable and I get abstractly how it could be useful to run fuzz binary without fuzzing compile options and instrumentation. But I only have a vague idea of how this should get used in practice. It would be helpful to add some documentation to https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md to say how/when you could run the fuzz binary in debug mode, and when you would might want to set the FUZZ_NONDETERMINISM environment variable
...

💬 rkrux commented on pull request "test: Add encodable PUSHDATA1 examples to feature_taproot":
(https://github.com/bitcoin/bitcoin/pull/32114#issuecomment-2748411943)
Nice, I like this approach. Besides making it easier to onboard by adding the commentaty, it also helps in not increasing the size of the `spenders_taproot_active`, which is more than 500 lines long already.

I will look at it in detail soon.

💬 rkrux commented on pull request "rpc: Support v3 raw transactions creation":
(https://github.com/bitcoin/bitcoin/pull/31936#discussion_r2010354181)
Related, see https://github.com/bitcoin/bitcoin/pull/31936#discussion_r2010279314

💬 instagibbs commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#issuecomment-2748427065)
reACK b2ea3656481b4196acaf6a1b5f3949a9ba4cf48f

nice doc improvements

`git range-diff master 1601906941fa559ebbee7898453fa77f4606ad38 b2ea3656481b4196acaf6a1b5f3949a9ba4cf48f`

💬 1440000bytes commented on issue "bitcoind crash with corrupt wallet.dat":
(https://github.com/bitcoin/bitcoin/issues/32124#issuecomment-2748493704)
Steps to reproduce:

1. Run bitcoind with `bitcoind -regtest`
2. Create a new wallet which loads on startup with ` bitcoin-cli -regtest -named createwallet wallet_name=w1 load_on_startup=true`
3. Download sqlite binary: https://www.sqlite.org/download.html
4. Exit bitcoind
5. Use arbitrary SQL statements for wallet db with sqlite binary. Use the below SQL statements for the error mentioned in OP.

```
$ sqlite3 "wallet.dat file path"
SQLite version 3.49.1 2025-02-18 13:38:58
Ent
...