Bitcoin Core Github
43 subscribers
123K links
Download Telegram
💬 davidgumberg commented on pull request "build: Drop option to disable hardening.":
(https://github.com/bitcoin/bitcoin/pull/32071#issuecomment-2744568286)
Rebased to address @vasild feedback to drop `hardening_interface`, and added a check to `CMakeLists.txt` to avoid `-z separate-code` on NetBSD < 11.0 (thanks @hebasto). I've also updated the PR description.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008492939)
@ajtowns That's fair; I liked to think of TxGraph as something with well-specified behavior, but there are several instances of unspecified/best-effort behavior already:
* The cluster linearizations used (as no optimality is guaranteed)
* Reordering of tx removal / dep adding due to lazy batching
* Tie-breaking of order of same-chunk-feerate transactions from different clusters
* The exact logic Trim uses

Going to mark this resolved.
🤔 sipa reviewed a pull request: "cluster mempool: introduce TxGraph"
(https://github.com/bitcoin/bitcoin/pull/31363#pullrequestreview-2707582068)
Changes:
* Did a big pass through the interface documentation in txgraph.h
* Moved the support for Refs outliving TxGraph to a separate commit, and added the test suggested in https://github.com/bitcoin/bitcoin/pull/31363#issuecomment-2742606528.
* Some smaller things listed below:
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008491083)
Marking resolved.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008491413)
Good idea. Done through a `ClusterSet::HoldsGraphIndexes()` function.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008491150)
Done.
💬 rsafier commented on issue "Enable PCP by default?":
(https://github.com/bitcoin/bitcoin/issues/31663#issuecomment-2744896938)
Router Model: CR1000A (Verizon FIOS)
Platform: MacOS 15.3.2
Version: v29.0rc2
Successfully mapped via NAT-PMP, verified inbound connectable

```
bitcoind -natpmp -debug=net -listen=1 -maxconnections=60
...
2025-03-22T01:48:33Z [net] portmap: Got unsupported PCP version response, falling back to NAT-PMP
2025-03-22T01:48:33Z [net] natpmp: Requesting port mapping port 8333 from gateway x.x.x.x
2025-03-22T01:48:33Z [net] natpmp: Received response of 12 bytes: [xxx]
2025-03-22T01:48:33Z [net] natpmp
...
💬 fanquake commented on issue "build: make macOS build Clang only":
(https://github.com/bitcoin/bitcoin/issues/30206#issuecomment-2744920866)
> The last commit makes the macOS builds on Guix Clang only.

Seems like that commit is missing the diff to actually remove the GCC toolchain from the macOS build? Applying that causes the build to fail:
```diff
diff --git a/contrib/guix/manifest.scm b/contrib/guix/manifest.scm
index 4e7e955218..f1e3db81c8 100644
--- a/contrib/guix/manifest.scm
+++ b/contrib/guix/manifest.scm
@@ -544,7 +544,6 @@ inspecting signatures in Mach-O binaries.")
gzip
xz
;; Build tools
-
...
🚀 fanquake merged a pull request: "contrib: Make deterministic-coverage error messages more readable"
(https://github.com/bitcoin/bitcoin/pull/32074)
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008636799)
This has been rewritten.
⚠️ Dan9470000 opened an issue: "Dear Cypherpunk, SLH-DSA & SAI-15, NO Offense, Peace Out."
(https://github.com/bitcoin/bitcoin/issues/32119)
### Motivation

This my identity if y'all not believe 4fbbc8e089720d559de2e4ba351ef411ee602a86c7da1a05894d5d7bd831685f for Opportunity Cost and Just listen to what is conveyed not to who is presenting it and send me the Entropy Pool Product and Ciphertext like QSC01 send it to my home and i wanna help to execute ideas, Bitcoin is an easily confused asset of Positivism Falsehood and the Byzantine Devil, What Solution? SAI-15 and SLH-DSA.

### Possible solution

If you can't believe me, send me yo
...
fanquake closed an issue: "Dear Cypherpunk, SLH-DSA & SAI-15, NO Offense, Peace Out."
(https://github.com/bitcoin/bitcoin/issues/32119)
💬 Dan9470000 commented on issue "SAI-15 and i can execution idea.":
(https://github.com/bitcoin/bitcoin/issues/32075#issuecomment-2744965769)
Will this be implemented or not, Brruhh?. Let's Discuss and Forget about this account, focus on cryptographic math, I am very open-minded to accept criticism.
💬 Dan9470000 commented on issue "SAI-15 and i can execution idea.":
(https://github.com/bitcoin/bitcoin/issues/32075#issuecomment-2744966393)
[NIST.FIPS.205.ipd.pdf](https://github.com/user-attachments/files/19400568/NIST.FIPS.205.ipd.pdf) SLH-DSA recommendation for now and until the futures, I don't have 100% control over changing SAI-15, let you implement.
:lock: fanquake locked an issue: "SAI-15 and i can execution idea."
(https://github.com/bitcoin/bitcoin/issues/32075)
:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/32119)
🤔 MurdoqZodoq reviewed a pull request: "[28.x] 28.1 backports and final changes"
(https://github.com/bitcoin/bitcoin/pull/31594#pullrequestreview-2707803550)
734
⚠️ farrelA opened an issue: "Bitcoin Nebula, Please open a discussion."
(https://github.com/bitcoin/bitcoin/issues/32120)
Any Decentrilized 100% in here? Peace out guys, be healthy always, Let's fly higher 11111111111111111111111111100000000000000000000000000000000011111111111111111111111111111111111111111111111 Critize Message for Economic Think Tank. Why SAI-15 and SLH-DSA because for Signature Checksum to become a Balance for X Validate, I'm just criticizing it, I really care, not saying SHA 256 is a nightmare, y'all don't Sentiment I won't be here long, if you care who conveys information, not cryptography and
...
💬 farrelA commented on issue "Bitcoin Nebula, Please open a discussion.":
(https://github.com/bitcoin/bitcoin/issues/32120#issuecomment-2745003343)
Hopefully it will be implemented not because of who I am, I don't have feelings for anyone, You're the wrong person if you keep canceling this because I care not only in terms of Technology but also the Philosophy of Accedence, Like US it is impossible to exceed the amount of Bitcoin that Satoshi Nakamoto owns because reward and resonance energy what US get so small so different than Satoshi owns and why Altcoin can't beating of Bitcoin? Because there's all create Math Mistake not the laws of na
...
fanquake closed an issue: "Bitcoin Nebula, Please open a discussion."
(https://github.com/bitcoin/bitcoin/issues/32120)