💬 jurraca commented on pull request "contrib: document asmap-tool commands more thoroughly":
(https://github.com/bitcoin/bitcoin/pull/32110#issuecomment-2744427175)
thanks for the explanation! Seems like the tradeoff could be a bit dangerous if there are a lot of unmapped ranges. Updated the `--fill` section to reflect the tradeoff a bit better.

📝 darosior opened a pull request: "qa: make feature_assumeutxo.py test more robust"
(https://github.com/bitcoin/bitcoin/pull/32117)
This is another robustness fix that i [dropped](https://github.com/bitcoin/bitcoin/pull/31907#issuecomment-2698108727) from https://github.com/bitcoin/bitcoin/pull/31910, intending to just tweak the error in my branch which triggers the issue. As i played more with it i eventually decided to submit a proper fix instead. Since the rationale initially [confused reviewers](https://github.com/bitcoin/bitcoin/pull/31907#discussion_r1966033115) i tried to explain it in details in the commit message (r
...

📝 brunoerg opened a pull request: "fuzz: wallet: fix crypter target"
(https://github.com/bitcoin/bitcoin/pull/32118)
The crypter target has an issue, it's calling `DecryptKey` with a random secret and a random public key that will unlikely be related to the key used to encrypt, so it won't have any effect. This PR changes fixes it and also removes the `DecryptSecret` call since this function is already (and only) called within `DecryptKey`.

💬 hebasto commented on issue "build: make macOS build Clang only":
(https://github.com/bitcoin/bitcoin/issues/30206#issuecomment-2744536272)
[Here](https://github.com/hebasto/bitcoin/tree/250321-qt6-clang) is a working proof of concept based on the branch from https://github.com/bitcoin/bitcoin/pull/30997. The last commit makes the macOS builds on Guix Clang only.

💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r2008402492)
To clarify things, I reworked the commit and [provided](https://github.com/bitcoin/bitcoin/issues/30206#issuecomment-2744536272) a working proof of concept that addresses https://github.com/bitcoin/bitcoin/issues/30206.

The key point to keep in mind is that the build system for Qt 6 is entirely different from that of Qt 5. For this reason, I don't think this change could be split out.

However, the new approach is flexible enough to accommodate the needs of other native packages in the futu
...

💬 davidgumberg commented on pull request "build: Drop option to disable hardening.":
(https://github.com/bitcoin/bitcoin/pull/32071#discussion_r2008405401)
Fixed in latest push

💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2744566414)
1. Addressed the rest of the feedback from @fanquake.

2. Provided a working proof of concept addressinghttps://github.com/bitcoin/bitcoin/issues/30206, based ob this branch.

3. Fixed a bug when `make HOST=<host> NO_QT=1` builds the `native_qt` package.

💬 davidgumberg commented on pull request "build: Drop option to disable hardening.":
(https://github.com/bitcoin/bitcoin/pull/32071#issuecomment-2744568286)
Rebased to address @vasild feedback to drop `hardening_interface`, and added a check to `CMakeLists.txt` to avoid `-z separate-code` on NetBSD < 11.0 (thanks @hebasto). I've also updated the PR description.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008492939)
@ajtowns That's fair; I liked to think of TxGraph as something with well-specified behavior, but there are several instances of unspecified/best-effort behavior already:
* The cluster linearizations used (as no optimality is guaranteed)
* Reordering of tx removal / dep adding due to lazy batching
* Tie-breaking of order of same-chunk-feerate transactions from different clusters
* The exact logic Trim uses

Going to mark this resolved.

🤔 sipa reviewed a pull request: "cluster mempool: introduce TxGraph"
(https://github.com/bitcoin/bitcoin/pull/31363#pullrequestreview-2707582068)
Changes:
* Did a big pass through the interface documentation in txgraph.h
* Moved the support for Refs outliving TxGraph to a separate commit, and added the test suggested in https://github.com/bitcoin/bitcoin/pull/31363#issuecomment-2742606528.
* Some smaller things listed below:

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008491083)
Marking resolved.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008491413)
Good idea. Done through a `ClusterSet::HoldsGraphIndexes()` function.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008491150)
Done.

💬 rsafier commented on issue "Enable PCP by default?":
(https://github.com/bitcoin/bitcoin/issues/31663#issuecomment-2744896938)
Router Model: CR1000A (Verizon FIOS)
Platform: MacOS 15.3.2
Version: v29.0rc2
Successfully mapped via NAT-PMP, verified inbound connectable

```
bitcoind -natpmp -debug=net -listen=1 -maxconnections=60
...
2025-03-22T01:48:33Z [net] portmap: Got unsupported PCP version response, falling back to NAT-PMP
2025-03-22T01:48:33Z [net] natpmp: Requesting port mapping port 8333 from gateway x.x.x.x
2025-03-22T01:48:33Z [net] natpmp: Received response of 12 bytes: [xxx]
2025-03-22T01:48:33Z [net] natpmp
...

💬 fanquake commented on issue "build: make macOS build Clang only":
(https://github.com/bitcoin/bitcoin/issues/30206#issuecomment-2744920866)
> The last commit makes the macOS builds on Guix Clang only.

Seems like that commit is missing the diff to actually remove the GCC toolchain from the macOS build? Applying that causes the build to fail:
```diff
diff --git a/contrib/guix/manifest.scm b/contrib/guix/manifest.scm
index 4e7e955218..f1e3db81c8 100644
--- a/contrib/guix/manifest.scm
+++ b/contrib/guix/manifest.scm
@@ -544,7 +544,6 @@ inspecting signatures in Mach-O binaries.")
gzip
xz
;; Build tools
-
...

🚀 fanquake merged a pull request: "contrib: Make deterministic-coverage error messages more readable"
(https://github.com/bitcoin/bitcoin/pull/32074)

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r2008636799)
This has been rewritten.

⚠️ Dan9470000 opened an issue: "Dear Cypherpunk, SLH-DSA & SAI-15, NO Offense, Peace Out."
(https://github.com/bitcoin/bitcoin/issues/32119)
### Motivation

This my identity if y'all not believe 4fbbc8e089720d559de2e4ba351ef411ee602a86c7da1a05894d5d7bd831685f for Opportunity Cost and Just listen to what is conveyed not to who is presenting it and send me the Entropy Pool Product and Ciphertext like QSC01 send it to my home and i wanna help to execute ideas, Bitcoin is an easily confused asset of Positivism Falsehood and the Byzantine Devil, What Solution? SAI-15 and SLH-DSA.

### Possible solution

If you can't believe me, send me yo
...

✅ fanquake closed an issue: "Dear Cypherpunk, SLH-DSA & SAI-15, NO Offense, Peace Out."
(https://github.com/bitcoin/bitcoin/issues/32119)

💬 Dan9470000 commented on issue "SAI-15 and i can execution idea.":
(https://github.com/bitcoin/bitcoin/issues/32075#issuecomment-2744965769)
Will this be implemented or not, Brruhh?. Let's Discuss and Forget about this account, focus on cryptographic math, I am very open-minded to accept criticism.