💬 fanquake commented on pull request "fuzz: coinselection: cover `SetBumpFeeDiscount`":
(https://github.com/bitcoin/bitcoin/pull/31806#issuecomment-2742720048)
cc @marcofleon
(https://github.com/bitcoin/bitcoin/pull/31806#issuecomment-2742720048)
cc @marcofleon
💬 fanquake commented on pull request "miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()`":
(https://github.com/bitcoin/bitcoin/pull/31734#issuecomment-2742725629)
cc @darosior
(https://github.com/bitcoin/bitcoin/pull/31734#issuecomment-2742725629)
cc @darosior
💬 maflcko commented on pull request "fuzz: split `coinselection` harness":
(https://github.com/bitcoin/bitcoin/pull/31870#issuecomment-2742747821)
review ACK ba82240553ddd534287845e10bc76b46b45329fe 👐
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK ba82240553dd
...
(https://github.com/bitcoin/bitcoin/pull/31870#issuecomment-2742747821)
review ACK ba82240553ddd534287845e10bc76b46b45329fe 👐
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK ba82240553dd
...
⚠️ Davidoff2778 opened an issue: "Vytvořit žádost o podporu | Kapesní možnost"
(https://github.com/bitcoin/bitcoin/issues/32108)
https://m.pocketoption.com/en/cabinet/support/create?o=10,31,85&a=form&field=deposit_id&id=68233033
(https://github.com/bitcoin/bitcoin/issues/32108)
https://m.pocketoption.com/en/cabinet/support/create?o=10,31,85&a=form&field=deposit_id&id=68233033
💬 BrandonOdiwuor commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2742830552)
@maflcko The assumption was, providing default signet challenge is not so useful as it would result in the loss of default the signet configurations, hence did not include the check
https://github.com/bitcoin/bitcoin/blob/2db00278ea571d0f734609f9fefecfa75c16ee34/src/kernel/chainparams.cpp#L393-L408
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2742830552)
@maflcko The assumption was, providing default signet challenge is not so useful as it would result in the loss of default the signet configurations, hence did not include the check
https://github.com/bitcoin/bitcoin/blob/2db00278ea571d0f734609f9fefecfa75c16ee34/src/kernel/chainparams.cpp#L393-L408
✅ willcl-ark closed an issue: "Vytvořit žádost o podporu | Kapesní možnost"
(https://github.com/bitcoin/bitcoin/issues/32108)
(https://github.com/bitcoin/bitcoin/issues/32108)
:lock: fanquake locked an issue: "Vytvořit žádost o podporu | Kapesní možnost"
(https://github.com/bitcoin/bitcoin/issues/32108)
(https://github.com/bitcoin/bitcoin/issues/32108)
🤔 Sjors reviewed a pull request: "multiprocess: add bitcoin-mine test program"
(https://github.com/bitcoin/bitcoin/pull/30437#pullrequestreview-2705328965)
Code reviewed 5554f9cb4abf7e1852dd79d2d75e714fa8cbeadd.
Rebase looks good, but found a bug in the test.
(https://github.com/bitcoin/bitcoin/pull/30437#pullrequestreview-2705328965)
Code reviewed 5554f9cb4abf7e1852dd79d2d75e714fa8cbeadd.
Rebase looks good, but found a bug in the test.
💬 Sjors commented on pull request "multiprocess: add bitcoin-mine test program":
(https://github.com/bitcoin/bitcoin/pull/30437#discussion_r2007217890)
In 5554f9cb4abf7e1852dd79d2d75e714fa8cbeadd "test: add interface_ipc_mining.py test calling bitcoin-mine":
On macOS the limit is 104, which I run into when using a RAM disk with `--tmpdir=/Volumes/RAMDisk/tmp`.
Additionally, our temp path has funny characters, e.g. `/tmp/test_runner_₿_🏃_20250321_104521` so we need to length in bytes.
```diff
diff --git a/test/functional/interface_ipc_mining.py b/test/functional/interface_ipc_mining.py
index c9eedfba5d..73b9a3fb6b 100755
--- a/test/f
...
(https://github.com/bitcoin/bitcoin/pull/30437#discussion_r2007217890)
In 5554f9cb4abf7e1852dd79d2d75e714fa8cbeadd "test: add interface_ipc_mining.py test calling bitcoin-mine":
On macOS the limit is 104, which I run into when using a RAM disk with `--tmpdir=/Volumes/RAMDisk/tmp`.
Additionally, our temp path has funny characters, e.g. `/tmp/test_runner_₿_🏃_20250321_104521` so we need to length in bytes.
```diff
diff --git a/test/functional/interface_ipc_mining.py b/test/functional/interface_ipc_mining.py
index c9eedfba5d..73b9a3fb6b 100755
--- a/test/f
...
📝 vasild opened a pull request: "fuzz: avoid returning non-conforming results from FuzzedSock::GetSockName()"
(https://github.com/bitcoin/bitcoin/pull/32109)
It would be a bug in `getsockname(2)` if it returns a result that is smaller than the returned socket address family. For example, if it indicates that the result is less than `sizeof(sockaddr_in6)` and sets `sa_family` equal to `AF_INET6` in the output.
In other words, the `name->sa_family` in the output should be consistent with the returned `*name_len`.
The current code could fail to do that if:
* the caller provides `sockaddr_in6` and an input value of `*name_len=28`
* `ConsumeRandom
...
(https://github.com/bitcoin/bitcoin/pull/32109)
It would be a bug in `getsockname(2)` if it returns a result that is smaller than the returned socket address family. For example, if it indicates that the result is less than `sizeof(sockaddr_in6)` and sets `sa_family` equal to `AF_INET6` in the output.
In other words, the `name->sa_family` in the output should be consistent with the returned `*name_len`.
The current code could fail to do that if:
* the caller provides `sockaddr_in6` and an input value of `*name_len=28`
* `ConsumeRandom
...
💬 vasild commented on pull request "fuzz: add targets for PCP and NAT-PMP port mapping requests":
(https://github.com/bitcoin/bitcoin/pull/31676#discussion_r2007258156)
Thanks for fixing this! Much better this way, but not enough - it could still return e.g. IPv6 address that is smaller than the expected size for an IPv6 address, possibly confusing callers to read data past the end of the buffer. Also, minor thing, it forgot to set `errno` when returning an error (`-1`).
Addressed in https://github.com/bitcoin/bitcoin/pull/32109
(https://github.com/bitcoin/bitcoin/pull/31676#discussion_r2007258156)
Thanks for fixing this! Much better this way, but not enough - it could still return e.g. IPv6 address that is smaller than the expected size for an IPv6 address, possibly confusing callers to read data past the end of the buffer. Also, minor thing, it forgot to set `errno` when returning an error (`-1`).
Addressed in https://github.com/bitcoin/bitcoin/pull/32109
💬 vasild commented on pull request "fuzz: avoid returning non-conforming results from FuzzedSock::GetSockName()":
(https://github.com/bitcoin/bitcoin/pull/32109#issuecomment-2742918691)
cc @darosior, @marcofleon
(https://github.com/bitcoin/bitcoin/pull/32109#issuecomment-2742918691)
cc @darosior, @marcofleon
📝 jurraca opened a pull request: "contrib: document asmap-tool commands more thoroughly"
(https://github.com/bitcoin/bitcoin/pull/32110)
This README was a little sparse in my opinion, and was missing a mention of the `diff-addrs` command. This PR also adds detail to the help text for the `--fill` flag.
The README updates add background and examples for each command, split in two sections (encode/decode and diff/diff-addrs). This is intended to help people know how and when to run the commands available in the `asmap-tool.py` script.
However, I could use some confirmation on the behavior of the `--fill` flag. It's true that
...
(https://github.com/bitcoin/bitcoin/pull/32110)
This README was a little sparse in my opinion, and was missing a mention of the `diff-addrs` command. This PR also adds detail to the help text for the `--fill` flag.
The README updates add background and examples for each command, split in two sections (encode/decode and diff/diff-addrs). This is intended to help people know how and when to run the commands available in the `asmap-tool.py` script.
However, I could use some confirmation on the behavior of the `--fill` flag. It's true that
...
🚀 fanquake merged a pull request: "fuzz: split `coinselection` harness"
(https://github.com/bitcoin/bitcoin/pull/31870)
(https://github.com/bitcoin/bitcoin/pull/31870)
💬 vasild commented on pull request "fuzz: avoid returning non-conforming results from FuzzedSock::GetSockName()":
(https://github.com/bitcoin/bitcoin/pull/32109#issuecomment-2743024516)
`9c3298eb04...52b65186e1`: fix CI (lint and win64 build)
(https://github.com/bitcoin/bitcoin/pull/32109#issuecomment-2743024516)
`9c3298eb04...52b65186e1`: fix CI (lint and win64 build)
🤔 pablomartin4btc reviewed a pull request: "wallet: Disable creating and loading legacy wallets"
(https://github.com/bitcoin/bitcoin/pull/31250#pullrequestreview-2705644380)
Concept ACK
Light cr (by commit - will do another round next week) & tACK 32a522f2d825957f0c85d7b4ea9185a053b018e3
Verified when I try to load a legacy wallet (via RPC or from `QT` menu) I get:
"_`... The wallet appears to be a Legacy wallet, please use the wallet migration tool (migratewallet RPC).`_"
Also, running `QT` with legacy wallets in the `settings.json` will produce same output above closing the app with that error description ("_`Error: Failed to open database path...`_").
...
(https://github.com/bitcoin/bitcoin/pull/31250#pullrequestreview-2705644380)
Concept ACK
Light cr (by commit - will do another round next week) & tACK 32a522f2d825957f0c85d7b4ea9185a053b018e3
Verified when I try to load a legacy wallet (via RPC or from `QT` menu) I get:
"_`... The wallet appears to be a Legacy wallet, please use the wallet migration tool (migratewallet RPC).`_"
Also, running `QT` with legacy wallets in the `settings.json` will produce same output above closing the app with that error description ("_`Error: Failed to open database path...`_").
...
⚠️ maflcko reopened an issue: "bitcoind immediately segfaults on ppc64 openbsd 7.4"
(https://github.com/bitcoin/bitcoin/issues/29517)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
v26.0 and v26.1rc1 both build successfully on big endian ppc64 openbsd 7.4 but when starting, bitcoind immediately segfaults. CPU is POWER9.
Unfortunately, gdb on this platform also crashes when attempting to debug so all I have is this:
```
$ egdb bitcoind bitcoind.core
GNU gdb (GDB) 9.2
Copyright (C) 2020 Free S
...
(https://github.com/bitcoin/bitcoin/issues/29517)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
v26.0 and v26.1rc1 both build successfully on big endian ppc64 openbsd 7.4 but when starting, bitcoind immediately segfaults. CPU is POWER9.
Unfortunately, gdb on this platform also crashes when attempting to debug so all I have is this:
```
$ egdb bitcoind bitcoind.core
GNU gdb (GDB) 9.2
Copyright (C) 2020 Free S
...
💬 maflcko commented on issue "bitcoind immediately segfaults on ppc64 openbsd 7.4":
(https://github.com/bitcoin/bitcoin/issues/29517#issuecomment-2743158064)
Can you try if this happens with 29.0rc2 as well? https://github.com/bitcoin/bitcoin/releases/tag/v29.0rc2
I am asking, because it is using a new build system (cmake), so things may have changed.
Can you try with both g++ and clang++, again? Also, do all binaries in the `build_dir/bin` crash, or just bitcoind? Also, can you compile and run a simple stand-alone `std::cout << "Hi"` program?
(https://github.com/bitcoin/bitcoin/issues/29517#issuecomment-2743158064)
Can you try if this happens with 29.0rc2 as well? https://github.com/bitcoin/bitcoin/releases/tag/v29.0rc2
I am asking, because it is using a new build system (cmake), so things may have changed.
Can you try with both g++ and clang++, again? Also, do all binaries in the `build_dir/bin` crash, or just bitcoind? Also, can you compile and run a simple stand-alone `std::cout << "Hi"` program?
💬 kevkevinpal commented on pull request "test: replace hardcoded fee with node relay fee based calculation":
(https://github.com/bitcoin/bitcoin/pull/32058#issuecomment-2743163279)
Concept ACK [6aff347](https://github.com/bitcoin/bitcoin/pull/32058/commits/6aff3477349e51180cf4f62784d07a4d4ce00603)
This looks to address the TODO correctly
(https://github.com/bitcoin/bitcoin/pull/32058#issuecomment-2743163279)
Concept ACK [6aff347](https://github.com/bitcoin/bitcoin/pull/32058/commits/6aff3477349e51180cf4f62784d07a4d4ce00603)
This looks to address the TODO correctly
💬 laanwj commented on pull request "fuzz: avoid returning non-conforming results from FuzzedSock::GetSockName()":
(https://github.com/bitcoin/bitcoin/pull/32109#issuecomment-2743167723)
Concept ACK
> if it indicates that the result is less than sizeof(sockaddr_in6) and sets sa_family equal to AF_INET6 in the output.
FWIW, i've tried to make our code robust to this case by adding the length checks in ab1d3ece026844e682676673b8a461964a5b3ce4.
But it's a very unlikely OS bug and this change will likely result in more useful test coverage.
(https://github.com/bitcoin/bitcoin/pull/32109#issuecomment-2743167723)
Concept ACK
> if it indicates that the result is less than sizeof(sockaddr_in6) and sets sa_family equal to AF_INET6 in the output.
FWIW, i've tried to make our code robust to this case by adding the length checks in ab1d3ece026844e682676673b8a461964a5b3ce4.
But it's a very unlikely OS bug and this change will likely result in more useful test coverage.