Bitcoin Core Github
43 subscribers
123K links
Download Telegram
💬 pinheadmz commented on issue "b-msghand invoked oom-killer: Master (v28.99) crashing during IBD":
(https://github.com/bitcoin/bitcoin/issues/31561#issuecomment-2741951050)
I don't think you *can* prune with txindex! I added a 1 TB volume -- this was the mainnet server for the BOSS2025 program, specifically the RPC scavenger hunt challenge.

There were several crashes, I can't remember the height they started at but it was long before 800000.

The conf file just had `txindex=1` but I must have turned on `debug=1` on the command line when the crashes started
💬 fanquake commented on pull request "refactor: Enforces Txid and Wtxid types in RelayTransaction":
(https://github.com/bitcoin/bitcoin/pull/32104#issuecomment-2742089261)
cc @marcofleon & #31001.
💬 sr-gi commented on pull request "refactor: Enforces Txid and Wtxid types in RelayTransaction":
(https://github.com/bitcoin/bitcoin/pull/32104#issuecomment-2742096552)
Oh, I didn't realize Marco was already working on this. I saw this when updating the Erlay PR and thought it may be good to standalone fix. I'm happy to close it if you're planning to get it addressed @marcofleon
⚠️ bonczis opened an issue: "A"
(https://github.com/bitcoin/bitcoin/issues/32107)
### Motivation

A

### Possible solution

_No response_

### Useful Skills

* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* ...


### Guidance for new contributors

Want to work on this issue?

For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
:lock: fanquake locked an issue: "A"
(https://github.com/bitcoin/bitcoin/issues/32107)
💬 TheCharlatan commented on pull request "fuzz: Use immediate task runner to increase fuzz stability":
(https://github.com/bitcoin/bitcoin/pull/31841#issuecomment-2742339375)
Post-merge ACK
fanquake closed an issue: "intermittent issue in p2p_orphan_handling.py"
(https://github.com/bitcoin/bitcoin/issues/31700)
🚀 fanquake merged a pull request: "test: Fix intermittent issue in p2p_orphan_handling.py"
(https://github.com/bitcoin/bitcoin/pull/32092)
🚀 fanquake merged a pull request: "doc: add guidance for RPC to developer notes"
(https://github.com/bitcoin/bitcoin/pull/30142)
💬 ajtowns commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2742398706)
> I had an idea I wanted to suggest here. What if instead of adding C bindings to the bitcoin/bitcoin git repository we took inspiration from @darosior's thoughts about [project scope](https://delvingbitcoin.org/t/antoine-poinsot-on-bitcoin-cores-priorities/1470) and developed the C, rust, and python bindings in a separate bitcoin-core/bindings repository, or even separate bitcoin-core/bindings-{c,rust,python} repositories?

I think this is an interesting idea, and may be worth exploring indep
...
💬 User087 commented on issue "Add a `indexesdir` option to hold the indexes directory":
(https://github.com/bitcoin/bitcoin/issues/32099#issuecomment-2742402726)
> Do you have `txindex` enabled or disabled?

Enabled - the context of the question is that I think this would be useful for anyone running with `txindex` enabled; I'm not assuming `indexesdir` would be necessary if it's kept disabled (just as someone with a sufficiently pruned blockchain doesn't need to worry about `blocksdir` either).
fanquake closed an issue: "Write access to Testing Guide for 29.0 RC"
(https://github.com/bitcoin/bitcoin/issues/32102)
💬 fanquake commented on issue "Write access to Testing Guide for 29.0 RC":
(https://github.com/bitcoin/bitcoin/issues/32102#issuecomment-2742452052)
Added.
💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2742479648)
> Maybe I need to think about it more, but I don't see how a similar process could play out between the C++ API and the C bindings, or how there could be other benefits to the C++ code from just maintaining the C bindings. I could see there being benefits from developing the bindings, but would expect those to be the same regardless of repository layout.

I think I was conflating the introduction of some consolidating code here, like a separate context, methods that map to multiple calls to ou
...
💬 maflcko commented on pull request "ci: run test-each-commit on merge to master":
(https://github.com/bitcoin/bitcoin/pull/32103#issuecomment-2742553313)
> Would it not in that case be simpler to checkout the PR `HEAD` commit, fetch and rebase onto master

Again, I don't think this is possible.

In your example the rebase succeeds, because it is not needed. See:

```
git pull --rebase origin master
From https://github.com/willcl-ark/bitcoin
* branch master -> FETCH_HEAD
Current branch dummy-branch is up to date.
```

However, in the general case, it is not possible to rebase all commits of all pull requests on
...
💬 fanquake commented on pull request "build: Drop option to disable hardening.":
(https://github.com/bitcoin/bitcoin/pull/32071#issuecomment-2742557455)
@davidgumberg want to rebase here?
💬 fanquake commented on pull request "refactor: Remove redundant and confusing calls to IsArgSet":
(https://github.com/bitcoin/bitcoin/pull/31896#issuecomment-2742558962)
@ryanofsky Want to take another look?
💬 fanquake commented on pull request "wallet: removed duplicate call to GetDescriptorScriptPubKeyMan":
(https://github.com/bitcoin/bitcoin/pull/32023#issuecomment-2742562905)
https://cirrus-ci.com/task/5112314648592384?logs=ci#L5356:
```bash
[01:20:03.641] Run scriptpubkeyman with args ['/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/bin/fuzz', '-runs=1', PosixPath('/ci_container_base/ci/scratch/qa-assets/fuzz_corpora/scriptpubkeyman')]INFO: Running with entropic power schedule (0xFF, 100).
[01:20:03.641] INFO: Seed: 2231869594
[01:20:03.641] INFO: Loaded 1 modules (623423 inline 8-bit counters): 623423 [0x556e6d276398, 0x556e6d30e6d7),
[01:20:03.641
...
🚀 fanquake merged a pull request: "torcontrol: Limit reconnect timeout to max seconds and log delay in whole seconds"
(https://github.com/bitcoin/bitcoin/pull/31979)