💬 theuni commented on pull request "build: Fix shared lib linking for darwin with lld":
(https://github.com/bitcoin/bitcoin/pull/27628#issuecomment-1544340008)
> > And @hebasto, because I know you love libtool hacks ;)
>
> I believe we'll manage to switch to CMake earlier :)

Hahaha, you're probably right about that. But at least this way there's no "well it didn't work with autotools so it doesn't have to work with CMake" excuse :p

📝 fanquake opened a pull request: "doc: remove version number from bips.md"
(https://github.com/bitcoin/bitcoin/pull/27629)
This always just needs "bumping" (see previous rc type pulls), and the version number is already whichever version of the code you acquired bips.md with.

💬 instagibbs commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#discussion_r1191458103)
done

💬 MarcoFalke commented on pull request "doc: remove version number from bips.md":
(https://github.com/bitcoin/bitcoin/pull/27629#issuecomment-1544343736)
lgtm ACK 308caf326db5619141f0c224fa48410293d59330

📝 sdaftuar opened a pull request: "p2p: Increase tx relay rate"
(https://github.com/bitcoin/bitcoin/pull/27630)
In the presence of smaller transactions on the network, blocks can sustain a higher relay rate than 7tx/second. In this event, the per-peer inventory queues can grow too large.

Using 11 tx/second as an estimate for the max network throughput, this commit bumps the rate up to 22 tx/s (for inbound peers), providing a factor of 2 safety margin.

Outbound peers continue to receive relayed transactions at 2.5x the rate of inbound peers, for a rate of 55tx/second.

Note that this triples the pe
...

👍 theStack approved a pull request: "doc: remove version number from bips.md"
(https://github.com/bitcoin/bitcoin/pull/27629#pullrequestreview-1423066729)
ACK 308caf326db5619141f0c224fa48410293d59330

👍 theStack approved a pull request: "doc: remove version number from bips.md"
(https://github.com/bitcoin/bitcoin/pull/27629#pullrequestreview-1423066713)
ACK 308caf326db5619141f0c224fa48410293d59330

👍 hebasto approved a pull request: "doc: remove version number from bips.md"
(https://github.com/bitcoin/bitcoin/pull/27629#pullrequestreview-1423074680)
ACK 308caf326db5619141f0c224fa48410293d59330

💬 Tia939 commented on pull request "p2p: Stop relaying non-mempool txs":
(https://github.com/bitcoin/bitcoin/pull/27625#issuecomment-1544386670)
> `mapRelay` (used to relay announced transactions that are no longer in the mempool) has issues:
>
> * It doesn't have an absolute memory limit, only an implicit one based on the rate of transaction announcements
> * It doesn't have a use-case EDIT: see below
>
> Fix all issues by removing `mapRelay`.
>
> For more context, on why a transaction may have been removed from the mempool, see
>
> https://github.com/bitcoin/bitcoin/blob/c2f2abd0a4f4bd18bfca41b632d21d803479f3f4/src/txmempo
...

💬 ajtowns commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#discussion_r1191480873)
Let me rephrase. What I meant was that `in_flight_same_peer` confused me: "we just received the block from this peer, of course it was in flight, how else would it get to us?". But what the bool is actually telling us is that we had deliberately asked this peer for this block, it wasn't just spontaneously sent to us.

💬 localbool commented on issue "One core in CPU usage rate remains at 100% for a long time, causing serious delays in new blocks and forks":
(https://github.com/bitcoin/bitcoin/issues/27623#issuecomment-1544399013)
@huzhenyuan bitcoin core developers are working on your issue. They are serious and would refund any money you lost on this stake block drama reported by bitmex research.

You can read read the logs , how much they care about you:

https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2023-05-11

💬 hebasto commented on pull request "wallet: fix deadlock in bdb read write operation":
(https://github.com/bitcoin/bitcoin/pull/27556#issuecomment-1544400131)
Does this PR makes https://github.com/bitcoin/bitcoin/blob/137a98c5a22e058ed7a7997a0a4dbd75301de51e/test/sanitizer_suppressions/tsan#L28 outdated?

💬 achow101 commented on pull request "[23.2] Backports for rc1":
(https://github.com/bitcoin/bitcoin/pull/27624#issuecomment-1544400457)
ACK a26ff204f0f0355749a1b61136437623b325f8fb

Diffs match as expected

💬 achow101 commented on pull request "[25.0] Backports for rc2":
(https://github.com/bitcoin/bitcoin/pull/27613#issuecomment-1544400861)
ACK 7ef71e30c9bc108e29dec008490db5a0fa051629

👍 hebasto approved a pull request: "wallet: fix deadlock in bdb read write operation"
(https://github.com/bitcoin/bitcoin/pull/27556#pullrequestreview-1423109956)
Approach ACK de202f860b3f79774d5235dec59a140fa5c82fa7.

💬 fanquake commented on pull request "[25.0] Backports for rc2":
(https://github.com/bitcoin/bitcoin/pull/27613#issuecomment-1544404869)
Added a version bump for `25.0rc2`.

💬 ryanofsky commented on pull request "refactor: Add util::Result failure values, multiple error and warning messages":
(https://github.com/bitcoin/bitcoin/pull/25665#issuecomment-1544405658)
Thanks for the review.

Note: @martinus left several review comments on https://github.com/bitcoin/bitcoin/pull/25722#pullrequestreview-1386736519, which is based on this PR, which apply to this PR and can improve it a little. I'm planning to update this PR to incorporate the suggestions.

💬 pinheadmz commented on pull request "net: call getaddrinfo() in detachable thread to prevent stalling":
(https://github.com/bitcoin/bitcoin/pull/27557#discussion_r1191495146)
TIL I can probably replace this with `std::atomic_bool`

💬 glozow commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1544414801)
> without https://github.com/bitcoin/bitcoin/pull/26711 we are still letting things into mempool that are possibly problematic, no?

You're right. Every time we think about it a bit longer, another not-quite-ideal edge case comes up. Especially with full mempools and eviction being something to consider.

I think it was too early to open this. I've pushed a change to disallow any dependency between parents, which is where all these stupid edge cases come from (but is probably not a comon use
...

💬 pinheadmz commented on pull request "indexes: Read the locator's top block during init, allow interaction with reindex-chainstate":
(https://github.com/bitcoin/bitcoin/pull/25193#discussion_r1191500724)
Another side effect of this PR is I don't think we use the `locator` at all anymore besides its tip hash ?!