💬 0xB10C commented on pull request "test: replace assert with assert_equal and assert_greater_than":
(https://github.com/bitcoin/bitcoin/pull/32091#issuecomment-2735498232)
had a quick look, lgtm ACK 387385ba1edf9febdc75d39bd77b35b29714b3d0

💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r2002562814)
> Why is this needed (now, and not with Qt 5)?

Qt 6 has a completely different build system from Qt 5.

> Why aren't the depends outputs already suitable for static linking?

Not "depends output" but rather pkg-config output.

> Why do we need to restrict the search paths, nothing should be looking outside of depends?

Because that is the goal of depends, isn't it?

💬 saikiran57 commented on pull request "wallet: removed duplicate call to GetDescriptorScriptPubKeyMan":
(https://github.com/bitcoin/bitcoin/pull/32023#issuecomment-2735571011)
HI @furszy can you please give some clarity on this comment https://github.com/bitcoin/bitcoin/pull/32023#issuecomment-2731126667

📝 Sjors opened a pull request: "doc: clarify that testnet min-difficulty is not optional"
(https://github.com/bitcoin/bitcoin/pull/32095)
When 20 minutes have gone by on testnet3 or testnet4, the next block `MUST` have difficulty 1. I've seen people be confused about this several times now in recent months. It doesn't help that the code comment is wrong. So fixing that.

💬 Sjors commented on pull request "doc: clarify that testnet min-difficulty is not optional":
(https://github.com/bitcoin/bitcoin/pull/32095#issuecomment-2735661223)
Note that there's a recent proposal to drop this rule entirely: https://gnusha.org/pi/bitcoindev/688E575D-C370-4D7D-A6DB-11E0B56710B1@sprovoost.nl/T/#m08b97860799484a7f1a388892f86649065c11503

💬 BrandonOdiwuor commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2735687207)
rebased and removed the leftover debug statement

💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2735687589)
https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2542998445:

> concept ACK
>
> i've got few warnings during build:
>
> ```
> /home/pyth/cpp/bitcoin/src/qt/sendcoinsdialog.cpp: In constructor ‘SendCoinsDialog::SendCoinsDialog(const
> PlatformStyle*, QWidget*)’:
> /home/pyth/cpp/bitcoin/src/qt/sendcoinsdialog.cpp:91:56: warning: ‘void QCheckBox::stateChanged(int)’ is d
> eprecated: Use checkStateChanged() instead [-Wdeprecated-declarations]
> 91 | connect(ui->checkB
...

💬 BrandonOdiwuor commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#discussion_r2002704851)
@maflcko fixed

💬 hodlinator commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r2002650307)
Would be good to remove this line from d79dab0fa999002a0c5b70c1688240e2a5032ce1 in this PR.

💬 BrandonOdiwuor commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2735712124)
@jsarenik @carnhofdaki the behaviour default signet is not changed. I have updated the PR description to include this in case it was unclear.

This patch only affects custom signets with `signetchallenge` and the goal was to run those on custom directories `signet_XXXXXXXX` so as not to interfere with the default signet which runs on `signet` directory if you run multiple signets

💬 l0rinc commented on pull request "improve MallocUsage() accuracy":
(https://github.com/bitcoin/bitcoin/pull/28531#discussion_r2002746377)
After https://github.com/bitcoin/bitcoin/pull/30718 this should likely be:
```suggestion
utxo_to_spend=confirmed_utxos.pop(0), target_vsize=32500)
```

💬 Sjors commented on pull request "Drop testnet3":
(https://github.com/bitcoin/bitcoin/pull/31974#issuecomment-2735823728)
Rebased after #32088 and #32057, which both simplify this PR.

📝 Sjors opened a pull request: "Move some tests and documentation from testnet3 to testnet4"
(https://github.com/bitcoin/bitcoin/pull/32096)
In preparation for dropping testnet3 entirely in #31974 this PR migrates a few things to testnet4:

* the ZMQ examples
* developer docs
* various unit tests

It drops `testnet3` from `MAGIC_BYTES` in the test framework, since no test uses it.

💬 Sjors commented on pull request "Move some tests and documentation from testnet3 to testnet4":
(https://github.com/bitcoin/bitcoin/pull/32096#issuecomment-2735840269)
I'm unsure if I got the `argsman_tests` changes right.

🤔 hodlinator reviewed a pull request: "build: Switch to Qt 6"
(https://github.com/bitcoin/bitcoin/pull/30997#pullrequestreview-2697452534)
Code review 6bc347dfd55dd88ed216aae437a716e4cc4d4dde

💬 hodlinator commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r2002785421)
nit: Seems like this list used to be alphabetically ordered.

Similar in ubsan:
`implicit-integer-sign-change:*/qarraydata.h` should probably be after `implicit-integer-sign-change:*/new_allocator.h`.

💬 hodlinator commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r2002758330)
Should minimum libgcc version be documented in dependencies.md?

💬 hodlinator commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r2002835161)
Thanks for expanding the description!

💬 hodlinator commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r2002766420)
nit: More correct?
```suggestion
The current precise version for Qt is specified in [qt_details.mk](/depends/packages/qt_details.mk).
```

💬 Sjors commented on pull request "Move some tests and documentation from testnet3 to testnet4":
(https://github.com/bitcoin/bitcoin/pull/32096#discussion_r2002846230)
a0c134c4525e6ab6ca937b744ced6d963c389c96: I don't see any harm in just using mainnet for ZMQ, so maybe that's better?