💬 Sjors commented on pull request "Shuffle depends instructions and recommend modern make for macOS":
(https://github.com/bitcoin/bitcoin/pull/32086#discussion_r2000416335)
I pushed a variation.

💬 Sjors commented on pull request "ci: build multiprocess on most jobs":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2732019454)
Will rebase when the base PR does so, or is merged.

💬 vasild commented on pull request "build: enable libc++ hardening in debug builds":
(https://github.com/bitcoin/bitcoin/pull/31424#issuecomment-2732053677)
The documentation that I linked is explicit:

https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html

> _GLIBCXX_ASSERTIONS
Defined by default when compiling with no optimization, undefined by default when compiling with optimization. When defined, enables extra error checking in the form of precondition assertions, such as bounds checking in strings and null pointer checks when dereferencing smart pointers.

If you suspect that there is a bug in GCC or the documentation is
...

📝 Sjors opened a pull request: "test: switch wallet_crosschain.py to signet and drop testnet4"
(https://github.com/bitcoin/bitcoin/pull/32088)
It's sufficient to check only one test network, so this PR reverts the addition of testnet4 from #29775.

Testnet3 is deprecated. Instead of moving to testnet4, which might also be deprecated in the future, use signet.

💬 maflcko commented on pull request "build: enable libc++ hardening in debug builds":
(https://github.com/bitcoin/bitcoin/pull/31424#issuecomment-2732100998)
There is no GCC release with this feature yet (https://github.com/gcc-mirror/gcc/commit/361d230fd7800a7e749aba8ed020f54f5c26d504), so simply claiming that it is enabled by default is a bit misleading. I tried with the latest GCC release (14) and it didn't work.

💬 Sjors commented on pull request "test: switch wallet_crosschain.py to signet and drop testnet4":
(https://github.com/bitcoin/bitcoin/pull/32088#issuecomment-2732101734)
Suggested by @maflcko in https://github.com/bitcoin/bitcoin/pull/31974#discussion_r1995129869

cc @fjahr

💬 Sjors commented on pull request "Drop testnet3":
(https://github.com/bitcoin/bitcoin/pull/31974#discussion_r2000465650)
#32088

💬 maflcko commented on pull request "test: switch wallet_crosschain.py to signet and drop testnet4":
(https://github.com/bitcoin/bitcoin/pull/32088#discussion_r2000475122)
```suggestion
# Switch node 1 to any network different from regtest before starting it.
self.nodes[1].chain = 'signet'
# Disable network sync and prevent disk space warning on low resource CI
self.nodes[1].extra_args = ['-maxconnections=0', '-prune=550']
self.nodes[1].replace_in_config([('regtest=', 'signet='), ('[regtest]', '[signet]')])
```

nit in 213abf5f1ce9f0242d83e57f29eb696c9e77e755:

Could keep it a bit more general to reduce the churn i
...

🤔 maflcko reviewed a pull request: "test: switch wallet_crosschain.py to signet and drop testnet4"
(https://github.com/bitcoin/bitcoin/pull/32088#pullrequestreview-2693472556)
Concept ACK

🤔 hebasto reviewed a pull request: "ci: Drop ENABLE_HARDENING=OFF from clang-tidy"
(https://github.com/bitcoin/bitcoin/pull/32087#pullrequestreview-2693489474)
Post-merge ACK 7d34c19853e7a5528d69c5f30580e7e9712e61f0.

💬 Sjors commented on pull request "test: switch wallet_crosschain.py to signet and drop testnet4":
(https://github.com/bitcoin/bitcoin/pull/32088#discussion_r2000488071)
Done

💬 musaHaruna commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#issuecomment-2732148353)
Post ACK [52482cb](https://github.com/bitcoin/bitcoin/pull/32033/commits/52482cb24400f8c44ba9628aaaecb7c04b11beb2)

💬 maflcko commented on pull request "contrib: Make deterministic-coverage error messages more readable":
(https://github.com/bitcoin/bitcoin/pull/32074#issuecomment-2732155793)
@hodlinator I'll wait for you to give the ack/review on this, and once you are happy that your feedback is fully addressed, I'll move it out of draft

💬 hebasto commented on pull request "depends: Avoid using helper variables in toolchain file":
(https://github.com/bitcoin/bitcoin/pull/31360#issuecomment-2732199581)
> CI fails with https://cirrus-ci.com/task/6136289713455104?logs=ci#L531 :

It was an error during rebasing. Fixed.

Thank you!

⚠️ Prabhat1308 opened an issue: "Failure to run Fuzz tests when running with corpus"
(https://github.com/bitcoin/bitcoin/issues/32089)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

When running the fuzz tests with fuzz corpus raises an error
```
FUZZ=process_message build_fuzz/bin/fuzz qa-assets/fuzz_corpora/process_message/ ─╯
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 64371175
INFO: Loaded 1 modules (1252320 inline 8-bit counters): 1252320 [0x1061c8000, 0x1062f9be0),
INFO: Loaded 1 PC tables
...

👍 fanquake approved a pull request: "cmake: Check for `makensis` and `zip` tools before using them for optional `deploy` targets"
(https://github.com/bitcoin/bitcoin/pull/32019#pullrequestreview-2693581701)
ACK 1f9b2e150ce5aa192226d2daae73f7d678c47d65

💬 Prabhat1308 commented on issue "Failure to run Fuzz tests when running with corpus":
(https://github.com/bitcoin/bitcoin/issues/32089#issuecomment-2732222228)
I tried running with the
```
ASAN_OPTIONS=detect_container_overflow=0 FUZZ=process_message build_fuzz/bin/fuzz qa-assets/fuzz_corpora/process_message/
```
It crashes with the following log
```
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 917199606
INFO: Loaded 1 modules (1252320 inline 8-bit counters): 1252320 [0x109024000, 0x109155be0),
INFO: Loaded 1 PC tables (1252320 PCs): 1252320 [0x109155be0,0x10a4719e0),
INFO: 4126 files found in qa-assets/fuzz_corpora/pro
...

✅ fanquake closed an issue: "cmake: `makensis` isn't checked-for before use"
(https://github.com/bitcoin/bitcoin/issues/32018)

🚀 fanquake merged a pull request: "cmake: Check for `makensis` and `zip` tools before using them for optional `deploy` targets"
(https://github.com/bitcoin/bitcoin/pull/32019)

⚠️ hebasto opened an issue: "qa: `p2p_ibd_stalling.py --v1transport` fails"
(https://github.com/bitcoin/bitcoin/issues/32090)
https://github.com/hebasto/bitcoin-core-nightly/actions/runs/13914507401/job/38935007425:
```
320/321 - p2p_ibd_stalling.py --v1transport failed, Duration: 484 s

stdout:
2025-03-18T04:03:23.417000Z TestFramework (INFO): PRNG seed is: 8897219840825193112
2025-03-18T04:03:23.418000Z TestFramework (INFO): Initializing test directory /home/runner/work/bitcoin-core-nightly/bitcoin-core-nightly/test_runner_₿_🏃_20250318_034132/p2p_ibd_stalling_112
2025-03-18T04:03:23.719000Z TestFramework (INFO): Pre
...