🚀 fanquake merged a pull request: "ci: Drop ENABLE_HARDENING=OFF from clang-tidy"
(https://github.com/bitcoin/bitcoin/pull/32087)

💬 fanquake commented on pull request "Shuffle depends instructions and recommend modern make for macOS":
(https://github.com/bitcoin/bitcoin/pull/32086#discussion_r2000261713)
s/Bitcoin/Bitcoin Core/

> either on your local machine or through cross-compilation

I think this needs to be rephrased, or just dropped.

💬 fanquake commented on pull request "Shuffle depends instructions and recommend modern make for macOS":
(https://github.com/bitcoin/bitcoin/pull/32086#discussion_r2000262395)
Do we need to copy-paste things here, given you've already linked to somewhere else that already has the same info? In either case, `pkgconf` isn't needed with depends, so should be dropped.

💬 jsarenik commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#discussion_r2000274205)
Yes, it definitely looks like a stray leftover debug statement. No, I did not write a single line of Python code here. Maybe @ajtowns or @kallewoof may comment on that line.

💬 jsarenik commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#discussion_r2000344600)
Apologies for a stray comment. I was out of context "thanks" to GitHub app on Android.

🚀 fanquake merged a pull request: "test: Update coverage.cpp to drop linux restriction"
(https://github.com/bitcoin/bitcoin/pull/32059)

💬 Sjors commented on pull request "Shuffle depends instructions and recommend modern make for macOS":
(https://github.com/bitcoin/bitcoin/pull/32086#discussion_r2000408118)
The main install instructions pull in libevent, boost (and pkgconf) which are not needed for a depends build. That's not going to be obvious, as demonstrated by the fact that I didn't know `pkgconf` isn't needed :-) (which I'll drop)

💬 Sjors commented on pull request "Shuffle depends instructions and recommend modern make for macOS":
(https://github.com/bitcoin/bitcoin/pull/32086#discussion_r2000410100)
Apparently `pkgconf` isn't needed, see https://github.com/bitcoin/bitcoin/pull/32086#discussion_r2000262395

💬 Sjors commented on pull request "Shuffle depends instructions and recommend modern make for macOS":
(https://github.com/bitcoin/bitcoin/pull/32086#discussion_r2000416335)
I pushed a variation.

💬 Sjors commented on pull request "ci: build multiprocess on most jobs":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2732019454)
Will rebase when the base PR does so, or is merged.

💬 vasild commented on pull request "build: enable libc++ hardening in debug builds":
(https://github.com/bitcoin/bitcoin/pull/31424#issuecomment-2732053677)
The documentation that I linked is explicit:

https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html

> _GLIBCXX_ASSERTIONS
Defined by default when compiling with no optimization, undefined by default when compiling with optimization. When defined, enables extra error checking in the form of precondition assertions, such as bounds checking in strings and null pointer checks when dereferencing smart pointers.

If you suspect that there is a bug in GCC or the documentation is
...

📝 Sjors opened a pull request: "test: switch wallet_crosschain.py to signet and drop testnet4"
(https://github.com/bitcoin/bitcoin/pull/32088)
It's sufficient to check only one test network, so this PR reverts the addition of testnet4 from #29775.

Testnet3 is deprecated. Instead of moving to testnet4, which might also be deprecated in the future, use signet.

💬 maflcko commented on pull request "build: enable libc++ hardening in debug builds":
(https://github.com/bitcoin/bitcoin/pull/31424#issuecomment-2732100998)
There is no GCC release with this feature yet (https://github.com/gcc-mirror/gcc/commit/361d230fd7800a7e749aba8ed020f54f5c26d504), so simply claiming that it is enabled by default is a bit misleading. I tried with the latest GCC release (14) and it didn't work.

💬 Sjors commented on pull request "test: switch wallet_crosschain.py to signet and drop testnet4":
(https://github.com/bitcoin/bitcoin/pull/32088#issuecomment-2732101734)
Suggested by @maflcko in https://github.com/bitcoin/bitcoin/pull/31974#discussion_r1995129869

cc @fjahr

💬 Sjors commented on pull request "Drop testnet3":
(https://github.com/bitcoin/bitcoin/pull/31974#discussion_r2000465650)
#32088

💬 maflcko commented on pull request "test: switch wallet_crosschain.py to signet and drop testnet4":
(https://github.com/bitcoin/bitcoin/pull/32088#discussion_r2000475122)
```suggestion
# Switch node 1 to any network different from regtest before starting it.
self.nodes[1].chain = 'signet'
# Disable network sync and prevent disk space warning on low resource CI
self.nodes[1].extra_args = ['-maxconnections=0', '-prune=550']
self.nodes[1].replace_in_config([('regtest=', 'signet='), ('[regtest]', '[signet]')])
```

nit in 213abf5f1ce9f0242d83e57f29eb696c9e77e755:

Could keep it a bit more general to reduce the churn i
...

🤔 maflcko reviewed a pull request: "test: switch wallet_crosschain.py to signet and drop testnet4"
(https://github.com/bitcoin/bitcoin/pull/32088#pullrequestreview-2693472556)
Concept ACK

🤔 hebasto reviewed a pull request: "ci: Drop ENABLE_HARDENING=OFF from clang-tidy"
(https://github.com/bitcoin/bitcoin/pull/32087#pullrequestreview-2693489474)
Post-merge ACK 7d34c19853e7a5528d69c5f30580e7e9712e61f0.

💬 Sjors commented on pull request "test: switch wallet_crosschain.py to signet and drop testnet4":
(https://github.com/bitcoin/bitcoin/pull/32088#discussion_r2000488071)
Done

💬 musaHaruna commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#issuecomment-2732148353)
Post ACK [52482cb](https://github.com/bitcoin/bitcoin/pull/32033/commits/52482cb24400f8c44ba9628aaaecb7c04b11beb2)