💬 glozow commented on pull request "build: Remove manpages when making MacOS app":
(https://github.com/bitcoin/bitcoin/pull/32064#issuecomment-2727853200)
Rebased in #32062

💬 glozow commented on pull request "build: use make < 3.82 syntax for define directive":
(https://github.com/bitcoin/bitcoin/pull/32070#issuecomment-2727853502)
Rebased in #32062

💬 glozow commented on pull request "fuzz: provide more realistic values to the base58(check) decoders":
(https://github.com/bitcoin/bitcoin/pull/31917#issuecomment-2727855318)
Backported in #32062

👋 glozow's pull request is ready for review: "[29.x] backports and rc2"
(https://github.com/bitcoin/bitcoin/pull/32062)

🚀 fanquake merged a pull request: "qa: Fix TxIndex race conditions"
(https://github.com/bitcoin/bitcoin/pull/32010)

💬 andrewtoth commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1997875119)
Hmm actually it stops opening new connections after all connection slots and the addnode are filled. It logs request to open 5, but then never manages to open one if I set maxconnections below 10. It only works if I call sendrawtransaction shortly after startup before all slots are filled.

💬 Eunovo commented on pull request "[EXPERIMENTAL] Schnorr batch verification for blocks":
(https://github.com/bitcoin/bitcoin/pull/29491#discussion_r1997877541)
https://github.com/bitcoin/bitcoin/pull/29491/commits/454103832351311d11e16505ed1925bd5f1c6875: IIUC All the threads still share this batch. That means we still have the same locking problem; threads will be stuck waiting for the batch to be free. In my very rough implementation https://github.com/bitcoin-dev-tools/benchcoin/pull/41/commits/173f07dc4493de3d3a9420f6a966606913277e9d#diff-0f68d4063c2fb11000f9048e46478e26c0ea2622f7866d00b574f429c3a4db61 I opted to give each batch a thread to resolv
...

👍 fanquake approved a pull request: "qt: doc: adapt outdated binary paths to CMake changes"
(https://github.com/bitcoin-core/gui/pull/858#pullrequestreview-2689072572)
ACK 7ebc458a8cb994bc3c0c129da61353968d955bc2

💬 fanquake commented on pull request "refactor: modernize outdated trait patterns using helper aliases (C++14/C++17)":
(https://github.com/bitcoin/bitcoin/pull/31904#issuecomment-2728161946)
> As this is compile-time logic, i don't think this should actually affect the compiled code?

Yea, comparing the two branches only differs in version info in the binary.

🚀 fanquake merged a pull request: "refactor: modernize outdated trait patterns using helper aliases (C++14/C++17)"
(https://github.com/bitcoin/bitcoin/pull/31904)

💬 fanquake commented on pull request "[29.x] backports and rc2":
(https://github.com/bitcoin/bitcoin/pull/32062#issuecomment-2728233450)
Can also pull in https://github.com/bitcoin-core/gui/pull/858 (if not this rc than next).

📝 bigspider opened a pull request: "OP_CHECKCONTRACTVERIFY"
(https://github.com/bitcoin/bitcoin/pull/32080)
This is a first draft implementation of the `OP_CHECKCONTRACTVERIFY` (`CCV`) opcode.

`CCV` enables to build Script-based state machines that span across multiple transactions, by providing an ergonomic tool to commit to - and introspect - the Script and possibly some _data_ that is committed inside inputs or outputs.

Related to this PR:
- [Draft BIP specifications](https://github.com/bitcoin/bips/pull/1793).
- [Post on delving bitcoin](https://delvingbitcoin.org/t/op-checkcontractverify-
...

💬 bigspider commented on pull request "OP_CHECKCONTRACTVERIFY":
(https://github.com/bitcoin/bitcoin/pull/32080#issuecomment-2728360432)
I will look into the CI asap.

💬 fanquake commented on pull request "fuzz: Use serial task runner to increase fuzz stability":
(https://github.com/bitcoin/bitcoin/pull/31841#issuecomment-2728374587)
cc @marcofleon

💬 maflcko commented on pull request "qt: doc: adapt outdated binary paths to CMake changes":
(https://github.com/bitcoin-core/gui/pull/858#issuecomment-2728391524)
lgtm ACK 7ebc458a8cb994bc3c0c129da61353968d955bc2

💬 maflcko commented on pull request "qt: Add addressList field to SendCoinsRecipient for multiple addresses":
(https://github.com/bitcoin-core/gui/pull/857#issuecomment-2728394503)
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

💬 fanquake commented on pull request "build: align debugging flags to `-O0`":
(https://github.com/bitcoin/bitcoin/pull/29796#issuecomment-2728403796)
> Can you describe why you think it's important that they align?

💬 fanquake commented on pull request "doc: improve NODE_NETWORK_LIMITED documentation per BIP159":
(https://github.com/bitcoin/bitcoin/pull/31805#issuecomment-2728439567)
> Opened https://github.com/bitcoin/bips/pull/1768 and putting this in draft for now.

That has been merged.

💬 Prabhat1308 commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#issuecomment-2728473188)
re-ACK [`52482cb`](https://github.com/bitcoin/bitcoin/pull/32033/commits/52482cb24400f8c44ba9628aaaecb7c04b11beb2)

💬 maflcko commented on pull request "docs: fix typos":
(https://github.com/bitcoin/bitcoin/pull/32006#discussion_r1998121846)
this can probably be dropped completely. I'd guess it was written back when CI on open source was an fresh and possibly unknown concept. However, today, it seems common sense to require passing CI for all CI tasks, just like the code is required to compile on all supported build configs (even if they are not tested by CI). But the requirement that code must compile on all supported build configs isn't mentioned here either.

So, I'd say to either remove this (as it is common sense), or reword
...