💬 Chand-ra commented on pull request "test: replace hardcoded fee with node relay fee based calculation":
(https://github.com/bitcoin/bitcoin/pull/32058#discussion_r1997662972)
> not sure about using float and then int again. Why is this needed?

The fee in satoshis must be integer, so I added those as a precautionary measure. Looking back at it, they do seem redundant.

> Also, changing FEE may change the test logic, so it seems better to adjust manually

Isn't that the point of the change suggested by the `TODO` tag though? To make `FEE` adapt dynamically to a change in `minRelayTxFee`?

💬 fjahr commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#discussion_r1997671044)
fixed

💬 fjahr commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#discussion_r1997671110)
Indeed, nice.

💬 fjahr commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#issuecomment-2727563285)
Addressed @TheCharlatan 's comments, sorry for invalidating the ACKs again but diff should be easy to review: https://github.com/bitcoin/bitcoin/compare/0d10f1a66436cd2ddab6b04247bcd6c4747cccc3..52482cb24400f8c44ba9628aaaecb7c04b11beb2

👍 TheCharlatan approved a pull request: "test: Check datadir cleanup after assumeutxo was successful"
(https://github.com/bitcoin/bitcoin/pull/32033#pullrequestreview-2688762231)
Re-ACK 52482cb24400f8c44ba9628aaaecb7c04b11beb2

💬 andrewtoth commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1997696790)
I tried again with `-debug=privatebroadcast`. It does indeed just wait at 0 connections. The only relevant logs are
```
[privatebroadcast] Requesting 5 new connections due to txid=<redacted>, wtxid=<redacted>
[privatebroadcast] Request to increment the needed new connections by 5, changed from 0 to 5
```

Also had `-debug=net -debug=tor`, and no new connections were attempted.

💬 l0rinc commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#issuecomment-2727626203)
utACK 52482cb24400f8c44ba9628aaaecb7c04b11beb2

The build failure seems unrelated

💬 l0rinc commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#discussion_r1997696997)
nit: `node.datadir_path / node.chain / "chainstate_snapshot"` could be extracted to obviate that it's checked multiple times

💬 andrewtoth commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1997703505)
What did work was setting `-maxconnections=1` and then `-addnode=<local node>`. This did create a single blocks only peer along with the addnode peer, but it was able to use private broadcast. So, seems like there is a switch somewhere that disables this if `-maxconnections=0` exactly?

💬 fjahr commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#discussion_r1997707260)
Will do if I have to retouch

💬 mabu44 commented on pull request "test: Check datadir cleanup after assumeutxo was successful":
(https://github.com/bitcoin/bitcoin/pull/32033#issuecomment-2727714824)
Re-ACK 52482cb24400f8c44ba9628aaaecb7c04b11beb2

💬 fanquake commented on issue "doc: Mempool Policy documentation Outdated since TRUC":
(https://github.com/bitcoin/bitcoin/issues/32067#issuecomment-2727829866)
cc @glozow

⚠️ fanquake pinned an issue: "29.0 RC Testing Guide Feedback"
(https://github.com/bitcoin/bitcoin/issues/32026)
This issue is to discuss the [29.0 Release Candidate Testing Guide](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/29.0-Release-Candidate-Testing-Guide). If you have any feedback on the document, please leave a comment here.

Note: This is for feedback on the document, not on Bitcoin Core or on the 29.0 changes.

Thank you for taking a look at the guide and leaving your feedback.

ps. The initial page was co-authored-by:
@arejula27
@musaHaruna
@Prabhat1308
As part of the 2025 [Chaincode l
...

💬 glozow commented on pull request "test: fix intermittent failure in p2p_orphan_handling.py":
(https://github.com/bitcoin/bitcoin/pull/32063#issuecomment-2727852730)
Rebased in #32062

💬 glozow commented on pull request "build: Remove manpages when making MacOS app":
(https://github.com/bitcoin/bitcoin/pull/32064#issuecomment-2727853200)
Rebased in #32062

💬 glozow commented on pull request "build: use make < 3.82 syntax for define directive":
(https://github.com/bitcoin/bitcoin/pull/32070#issuecomment-2727853502)
Rebased in #32062

💬 glozow commented on pull request "fuzz: provide more realistic values to the base58(check) decoders":
(https://github.com/bitcoin/bitcoin/pull/31917#issuecomment-2727855318)
Backported in #32062

👋 glozow's pull request is ready for review: "[29.x] backports and rc2"
(https://github.com/bitcoin/bitcoin/pull/32062)

🚀 fanquake merged a pull request: "qa: Fix TxIndex race conditions"
(https://github.com/bitcoin/bitcoin/pull/32010)

💬 andrewtoth commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1997875119)
Hmm actually it stops opening new connections after all connection slots and the addnode are filled. It logs request to open 5, but then never manages to open one if I set maxconnections below 10. It only works if I call sendrawtransaction shortly after startup before all slots are filled.