📝 mzumsande opened a pull request: "test: fix intermittent failure in p2p_orphan_handling.py"
(https://github.com/bitcoin/bitcoin/pull/32063)
If the mocktime is bumped before the node has successfully disconnected the peer, the requests for both parents could be spread over two GETDATAS: The first time `GetRequestsToSend` is invoked it would only request one tx from peer2, because the other one would only be available after peer1 was disconnected and its outstanding txrequest cleared.
So two GETDATAs would be sent, which would make the test fail.

Fixes #31700

💬 ryanofsky commented on pull request "refactor: Improve assumeutxo state representation":
(https://github.com/bitcoin/bitcoin/pull/30214#issuecomment-2722882679)
I think I agree with all that, and think chainstate objects should just contain information for chainstatemanager to deal with them, not to have "rich" data or application specific data. I also think depending on what you want to do with chainstates, block status flags may provide enough information, but they are not equivalent to the old `Chainstate::m_disabled` field or the new `Chainstate::m_validity` field replacing it, since block flags only tell you about validity back to the last snapshot
...

💬 fjahr commented on issue "Fully validated AssumeUTXO starts revalidating after restart":
(https://github.com/bitcoin/bitcoin/issues/32029#issuecomment-2722961366)
I would still be concept ACK on a PR from @mzumsande if it doesn't turn out to be too complicated. I think James built in a lot of belts and suspenders because initially not everyone was fully on board with the concept and it makes sense to clean this up now if it's just redundant work.

🤔 pablomartin4btc reviewed a pull request: "qa: clarify and document one assumeutxo test case with malleated snapshot"
(https://github.com/bitcoin/bitcoin/pull/31907#pullrequestreview-2683628002)
post-merge ACK e5ff4e416ecc8a51367022eb8a7a291f8cbc0c65

The updated case looks obviously much clearer now (3rd commit body explains the change very well too) and I'm in favour of the [mentioned](https://github.com/bitcoin/bitcoin/pull/31907#pullrequestreview-2661853159) follow-ups.

🚀 fanquake merged a pull request: "consensus: Remove checkpoints (take 2)"
(https://github.com/bitcoin/bitcoin/pull/31649)

💬 achow101 commented on issue "v29.0 Testing":
(https://github.com/bitcoin/bitcoin/issues/32052#issuecomment-2723007926)
#31844 Broke MacOS codesigning and notarization as it adds the manpage to the app, which `signapple` currently cannot cover in its signature. Since we did not have the manpage there before, and I don't think MacOS can even use that manpage, I think it would be reasonable to drop that from the app. I think we can skip codesigning for 29.0rc1.

💬 pablomartin4btc commented on pull request "doc: Update documentation to include Clang/llvm based coverage report generation":
(https://github.com/bitcoin/bitcoin/pull/31933#discussion_r1994471346)
small nit:
```suggestion
Generating the raw profile data based on `ctest` and functional tests execution:
```
Or remove both and clarify it below before each execution (or any alternative you might have).

🤔 pablomartin4btc reviewed a pull request: "doc: Update documentation to include Clang/llvm based coverage report generation"
(https://github.com/bitcoin/bitcoin/pull/31933#pullrequestreview-2683653107)
ACK 7f57ad00d301b9564ece511d2e99cb0678b21174

I think the feedback about [`CMAKE_BUILD_TYPE`](https://github.com/bitcoin/bitcoin/pull/31933#discussion_r1993037907) needs to be addressed.

Since the functional tests were added (for the report generation), is it worth adding the `fuzz`?

📝 achow101 opened a pull request: "build: Remove manpages when making MacOS app"
(https://github.com/bitcoin/bitcoin/pull/32064)
When creating the MacOS app, the only file that should be in `Bitcoin-Qt.app/Contents/MacOS` is `Bitcoin-Qt. Since #31844, there was also a `share/` containing the manpage for bitcoin-qt. This manpage is not useful to app users, and it is also causing code signing issues. Thus the directory should be removed when making the app.

Fixes https://github.com/bitcoin/bitcoin/issues/32052#issuecomment-2723007926

💬 davidgumberg commented on pull request "Require sqlite when building the wallet":
(https://github.com/bitcoin/bitcoin/pull/31961#issuecomment-2723097952)
crACK https://github.com/bitcoin/bitcoin/commit/36b6f36ac4724cb2c9ed0e25314c3bbf55e4ebb8

🚀 fanquake merged a pull request: "depends: remove `NO_HARDEN` option"
(https://github.com/bitcoin/bitcoin/pull/32038)

👍 fanquake approved a pull request: "build: Remove manpages when making MacOS app"
(https://github.com/bitcoin/bitcoin/pull/32064#pullrequestreview-2683941479)
ACK 80b5e7f2cb7fbfbd724e1f52b00c0e72b79a200b

✅ fanquake closed an issue: "v29.0 Testing"
(https://github.com/bitcoin/bitcoin/issues/32052)

🚀 fanquake merged a pull request: "build: Remove manpages when making MacOS app"
(https://github.com/bitcoin/bitcoin/pull/32064)

💬 fanquake commented on pull request "contrib: Fix `gen-bitcoin-conf.sh`":
(https://github.com/bitcoin/bitcoin/pull/32049#issuecomment-2723294891)
Backported in #32062.

⚠️ achow101 reopened an issue: "v29.0 Testing"
(https://github.com/bitcoin/bitcoin/issues/32052)
Umbrella issue for 29.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.

Let us know which version you tested on which operating system.

If you find an issue, please search Github for known issues first and then open a new Github issue.

This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.

See [29.0 Release Notes Draft](https://github.com/bitcoin-core/bitcoi
...

💬 Prabhat1308 commented on pull request "contrib: Update coverage.cpp macro to support macOS":
(https://github.com/bitcoin/bitcoin/pull/32059#issuecomment-2723306164)
tACK [611151e](https://github.com/bitcoin/bitcoin/pull/32059/commits/611151eae75ed756437442a5d0356f525c73dd00)

🚀 fanquake merged a pull request: "Require sqlite when building the wallet"
(https://github.com/bitcoin/bitcoin/pull/31961)

💬 ZKcash-IrishGov commented on something "":
(https://github.com/bitcoin/bitcoin/commit/a24419f8bed5e1145ce171dbbdad957750585471#r153704902)
rbmwgtoj4z9npg9nu8wb9q4dejsy5js35oaicefzg3mbf3ncxzu815o7k9ecfagt6ozqp3rxx4g7a3etqajahm4w4j4cyy51sbe4c8zm

💬 fanquake commented on pull request "contrib: Update coverage.cpp macro to support macOS":
(https://github.com/bitcoin/bitcoin/pull/32059#discussion_r1994664138)
Why do we need to specify platforms here, rather than just `__clang__` (especially if you're now going to add fallbacks)?