💬 ismaelsadeeq commented on pull request "wallet, rpc: deprecate settxfee and paytxfee":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1991338308)
yes

🚀 fanquake merged a pull request: "validation, fix: Use wtxid instead of txid in `CheckEphemeralSpends`"
(https://github.com/bitcoin/bitcoin/pull/32025)

💬 Sjors commented on pull request "Require sqlite when building the wallet":
(https://github.com/bitcoin/bitcoin/pull/31961#issuecomment-2717654904)
Taken both suggestions.

📝 fanquake opened a pull request: "depends: remove `NO_HARDEN` option"
(https://github.com/bitcoin/bitcoin/pull/32038)
This was only needed to work around a (Libtool related iirc) Windows issue, when hardening was disabled. I can no-longer recreate this failure, so it'd be good to remove this Windows carveout.

⚠️ Aste525 opened an issue: "SAI-15, Add Heterodyning 140 kHz slow down to 22 kHz."
(https://github.com/bitcoin/bitcoin/issues/32039)
### Please describe the feature you'd like to see added.

// SAI-15 Key Generation and Encryption Framework

def generate_key(self):

return secrets.token_bytes(399)

def encrypt(self, plaintext, key):

if len(key) != 399:

raise ValueError("Key must be exactly 399 bytes")

ciphertext = bytearray()

for i, byte in enumerate(plaintext):

key_byte = key[i % 399]

ciphertext.append(byte ^ key_byte)

return bytes(ciphertext)

// Message Schedule and Compre
...

💬 hebasto commented on pull request "Require sqlite when building the wallet":
(https://github.com/bitcoin/bitcoin/pull/31961#issuecomment-2717700877)
> Taken both suggestions.
>
> @hebasto native fuzz build is unhappy

```diff
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -171,7 +171,7 @@ jobs:
generate-options: '-DBUILD_GUI=ON -DWITH_BDB=ON -DWITH_ZMQ=ON -DBUILD_BENCH=ON -DWERROR=ON'
job-name: 'Win64 native, VS 2022'
- job-type: fuzz
- generate-options: '-DVCPKG_MANIFEST_NO_DEFAULT_FEATURES=ON -DVCPKG_MANIFEST_FEATURES="sqlite" -DBUILD_GUI=OFF -DBUILD_FOR_FUZZING=
...

✅ maflcko closed an issue: "SAI-15, Add Heterodyning 140 kHz slow down to 22 kHz."
(https://github.com/bitcoin/bitcoin/issues/32039)

💬 laanwj commented on pull request "depends: remove `NO_HARDEN` option":
(https://github.com/bitcoin/bitcoin/pull/32038#issuecomment-2717727013)
Concept ACK, for a project like this it's unreasonable to disable hardening features, there is no reason to maintain this functionailty.

💬 maflcko commented on issue "Doc: Feature deprecation and removal process documentation.":
(https://github.com/bitcoin/bitcoin/issues/31980#issuecomment-2717763726)
See https://github.com/bitcoin/bitcoin/pull/30142

💬 theStack commented on pull request "validation, fix: Use wtxid instead of txid in `CheckEphemeralSpends`":
(https://github.com/bitcoin/bitcoin/pull/32025#issuecomment-2717832304)
post-merge code-review ACK e637dc2c01c3b566e6c51c911c5881a8d206c924
good find 👌

💬 vasild commented on pull request "net: replace manual reference counting of CNode with shared_ptr":
(https://github.com/bitcoin/bitcoin/pull/32015#issuecomment-2717860925)
Some comments from the other PRs:

_from https://github.com/bitcoin/bitcoin/pull/10738#issue-240283546:_
> Special care must be taken, though, to only delete CNodes from a single thread, and to control which thread that is.

In `master` deletion of `CNode` objects could happen in the `net` thread or in the `main` thread. In other words, some `CNode` object might be destroyed in the `net` thread and another `CNode` object might be destroyed in the `main` thread. I do not see any problem wit
...

💬 maflcko commented on pull request "descriptors: inference process, do not return unparsable multisig descriptors":
(https://github.com/bitcoin/bitcoin/pull/31404#issuecomment-2717861487)
Could turn into draft while CI is failing and feedback is waiting to be addressed?

💬 Aste525 commented on issue "SAI-15, Add Heterodyning 140 kHz slow down to 22 kHz.":
(https://github.com/bitcoin/bitcoin/issues/32039#issuecomment-2717888439)
أَنَا أُحِبُّكَ فِي اللَّهِ

Pada Rab, 12 Mar 2025, 19.28, maflcko ***@***.***> menulis:

> Closed #32039 <https://github.com/bitcoin/bitcoin/issues/32039> as
> completed.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issues/32039#event-16712828234>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BLBOSABI5PD5ML5EDZHJFYD2UAR7TAVCNFSM6AAAAABY3M2CWKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWG4YTEOBS
...

:lock: fanquake locked an issue: "SAI-15, Add Heterodyning 140 kHz slow down to 22 kHz."
(https://github.com/bitcoin/bitcoin/issues/32039)

💬 ryanofsky commented on pull request "cmake: Avoid fuzzer "multiple definition of `main'" errors":
(https://github.com/bitcoin/bitcoin/pull/31992#issuecomment-2717920553)
> Why do we want IPC enabled for the fuzzing builds? It's not used/tested by our fuzzing harnesses.

To be clear, this PR isn't enabling IPC in the fuzzing CI configuration, just fixing a more general build system bug which causes that configuration to be broken. But a followup PR #30975 does enable IPC in the fuzzing CI configuration for a few reasons:

- To test ENABLE_IPC option in different scenarios and uncover incompatibilities like this
- To make the fuzz configuration more similar t
...

💬 darosior commented on pull request "Implement OP_CHECKSIGFROMSTACK(VERIFY)":
(https://github.com/bitcoin/bitcoin/pull/29270#issuecomment-2717951506)
@reardencode could you start by getting it merged and deployed on inquisition first? I'm not sure how another PR to Core for this would be useful at this point.

💬 ryanofsky commented on pull request "cmake: Avoid fuzzer "multiple definition of `main'" errors":
(https://github.com/bitcoin/bitcoin/pull/31992#issuecomment-2717962615)
Also while the PR description mentions the `ENABLE_IPC` / `SANITIZERS=fuzzer`incompatibility to motivate this change, I think the change is a more general bugfix and makes sense for a variety of reasons listed previously in https://github.com/bitcoin/bitcoin/pull/31741#issuecomment-2663597395:

> (1) It fixes the CI bug
> (2) It documents sanitize_interface and removes an attribute(weak) hack.
> (3) It doesn't compile libraries with a flag intended to bring in a main() function.
> (4) It pr
...

👍 hodlinator approved a pull request: "cmake: Check for `makensis` and `zip` tools before using them for optional `deploy` targets"
(https://github.com/bitcoin/bitcoin/pull/32019#pullrequestreview-2678590991)
re-ACK b86eb5f45a6df456d6aa80d62dd5b720ecfe917c

Would prefer something a bit more terse as mentioned in https://github.com/bitcoin/bitcoin/pull/32019#discussion_r1988781317, but not a blocker for me.

📝 furszy converted_to_draft a pull request: "descriptors: inference process, do not return unparsable multisig descriptors"
(https://github.com/bitcoin/bitcoin/pull/31404)
The internal script-to-descriptor inference procedure shouldn't return invalid
descriptors or ones that fail the string-to-descriptor parsing process. These
two procedures should always support seamless roundtrips.

This inlines `InferScript`/`InferDescriptor` to the actual descriptors
`ParseScript` logic for the multisig path, ensuring only valid descriptors are
produced.

Examples where this presents an issue:
1) Because the legacy wallet allowed the import of invalid scripts, the pro
...

👍 hebasto approved a pull request: "Require sqlite when building the wallet"
(https://github.com/bitcoin/bitcoin/pull/31961#pullrequestreview-2678573414)
ACK 564c54f3371b6faf50be2c7e7b6280357c90e62c.

Left a couple of nits and the following notes.

1. For some BSD systems, we document how to build BDB in depends. Now, it builds `sqlite` along with `bdb`. I don't believe it's critical, especially with BDB being removed soon.

2. re [comment](https://github.com/bitcoin/bitcoin/pull/31961#issuecomment-2717203847):
> I initially considered dropping the `NO_WALLET` option from depends. Most other depends packages refer to the library name rathe
...