🚀 hebasto merged a pull request: "qa: Enable feature_init.py on Windows"
(https://github.com/bitcoin/bitcoin/pull/32021)

🤔 janb84 reviewed a pull request: "test: Use rpc_deprecated only for testing deprecation"
(https://github.com/bitcoin/bitcoin/pull/31977#pullrequestreview-2678106250)
Concept ACK [b1c80fa](https://github.com/bitcoin/bitcoin/commit/b1c80fab0c026a40f2901958abdeedb9dd36c30d)

Suggested small comment change for clarity, feel free to ignore.

💬 janb84 commented on pull request "test: Use rpc_deprecated only for testing deprecation":
(https://github.com/bitcoin/bitcoin/pull/31977#discussion_r1991291419)
nit: Needed to read this comment several times before understanding, suggested small change for clarity.
```suggestion
# Please ensure that the -deprecatedrpc flag for all the RPC methods
# mentioned above is used in their respective functional tests,
# where the RPC functionality is actually tested.
```

💬 ismaelsadeeq commented on pull request "Fee Estimation via Fee rate Forecasters":
(https://github.com/bitcoin/bitcoin/pull/30157#discussion_r1991298562)
I will update this here #31664

💬 ismaelsadeeq commented on pull request "Fee Estimation via Fee rate Forecasters":
(https://github.com/bitcoin/bitcoin/pull/30157#discussion_r1991301116)
No, `conf_target` is a struct can not be passed to `strprintf`

💬 ismaelsadeeq commented on pull request "Fee Estimation via Fee rate Forecasters":
(https://github.com/bitcoin/bitcoin/pull/30157#discussion_r1991309323)
It is` 0.25` * `DEFAULT_BLOCK_MAX_WEIGHT` see https://delvingbitcoin.org/t/mempool-based-fee-estimation-on-bitcoin-core/703/2 where the term was used.

💬 l0rinc commented on issue "Fully validated AssumeUTXO starts revalidating after restart":
(https://github.com/bitcoin/bitcoin/issues/32029#issuecomment-2717612056)
Thanks for the clarification @fjahr, I thought the reverification causes the utxo set to dump again (it's why I though https://github.com/bitcoin/bitcoin/pull/31645 could help) - which incidentally took about the same time for me in previous runs.

It's possible that this final run (when I didn't cancel the reverification) was indeed in debug mode - (though `gettxoutsetinfo` in `Debug` "only" takes 13 minutes).

@mzumsande, the `DB_ASSUMEUTXO_VALIDATED` experiment may not be necessary in light o
...

💬 ismaelsadeeq commented on pull request "wallet, rpc: deprecate settxfee and paytxfee":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1991338308)
yes

🚀 fanquake merged a pull request: "validation, fix: Use wtxid instead of txid in `CheckEphemeralSpends`"
(https://github.com/bitcoin/bitcoin/pull/32025)

💬 Sjors commented on pull request "Require sqlite when building the wallet":
(https://github.com/bitcoin/bitcoin/pull/31961#issuecomment-2717654904)
Taken both suggestions.

📝 fanquake opened a pull request: "depends: remove `NO_HARDEN` option"
(https://github.com/bitcoin/bitcoin/pull/32038)
This was only needed to work around a (Libtool related iirc) Windows issue, when hardening was disabled. I can no-longer recreate this failure, so it'd be good to remove this Windows carveout.

⚠️ Aste525 opened an issue: "SAI-15, Add Heterodyning 140 kHz slow down to 22 kHz."
(https://github.com/bitcoin/bitcoin/issues/32039)
### Please describe the feature you'd like to see added.

// SAI-15 Key Generation and Encryption Framework

def generate_key(self):

return secrets.token_bytes(399)

def encrypt(self, plaintext, key):

if len(key) != 399:

raise ValueError("Key must be exactly 399 bytes")

ciphertext = bytearray()

for i, byte in enumerate(plaintext):

key_byte = key[i % 399]

ciphertext.append(byte ^ key_byte)

return bytes(ciphertext)

// Message Schedule and Compre
...

💬 hebasto commented on pull request "Require sqlite when building the wallet":
(https://github.com/bitcoin/bitcoin/pull/31961#issuecomment-2717700877)
> Taken both suggestions.
>
> @hebasto native fuzz build is unhappy

```diff
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -171,7 +171,7 @@ jobs:
generate-options: '-DBUILD_GUI=ON -DWITH_BDB=ON -DWITH_ZMQ=ON -DBUILD_BENCH=ON -DWERROR=ON'
job-name: 'Win64 native, VS 2022'
- job-type: fuzz
- generate-options: '-DVCPKG_MANIFEST_NO_DEFAULT_FEATURES=ON -DVCPKG_MANIFEST_FEATURES="sqlite" -DBUILD_GUI=OFF -DBUILD_FOR_FUZZING=
...

✅ maflcko closed an issue: "SAI-15, Add Heterodyning 140 kHz slow down to 22 kHz."
(https://github.com/bitcoin/bitcoin/issues/32039)

💬 laanwj commented on pull request "depends: remove `NO_HARDEN` option":
(https://github.com/bitcoin/bitcoin/pull/32038#issuecomment-2717727013)
Concept ACK, for a project like this it's unreasonable to disable hardening features, there is no reason to maintain this functionailty.

💬 maflcko commented on issue "Doc: Feature deprecation and removal process documentation.":
(https://github.com/bitcoin/bitcoin/issues/31980#issuecomment-2717763726)
See https://github.com/bitcoin/bitcoin/pull/30142

💬 theStack commented on pull request "validation, fix: Use wtxid instead of txid in `CheckEphemeralSpends`":
(https://github.com/bitcoin/bitcoin/pull/32025#issuecomment-2717832304)
post-merge code-review ACK e637dc2c01c3b566e6c51c911c5881a8d206c924
good find 👌

💬 vasild commented on pull request "net: replace manual reference counting of CNode with shared_ptr":
(https://github.com/bitcoin/bitcoin/pull/32015#issuecomment-2717860925)
Some comments from the other PRs:

_from https://github.com/bitcoin/bitcoin/pull/10738#issue-240283546:_
> Special care must be taken, though, to only delete CNodes from a single thread, and to control which thread that is.

In `master` deletion of `CNode` objects could happen in the `net` thread or in the `main` thread. In other words, some `CNode` object might be destroyed in the `net` thread and another `CNode` object might be destroyed in the `main` thread. I do not see any problem wit
...

💬 maflcko commented on pull request "descriptors: inference process, do not return unparsable multisig descriptors":
(https://github.com/bitcoin/bitcoin/pull/31404#issuecomment-2717861487)
Could turn into draft while CI is failing and feedback is waiting to be addressed?

💬 Aste525 commented on issue "SAI-15, Add Heterodyning 140 kHz slow down to 22 kHz.":
(https://github.com/bitcoin/bitcoin/issues/32039#issuecomment-2717888439)
أَنَا أُحِبُّكَ فِي اللَّهِ

Pada Rab, 12 Mar 2025, 19.28, maflcko ***@***.***> menulis:

> Closed #32039 <https://github.com/bitcoin/bitcoin/issues/32039> as
> completed.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issues/32039#event-16712828234>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BLBOSABI5PD5ML5EDZHJFYD2UAR7TAVCNFSM6AAAAABY3M2CWKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWG4YTEOBS
...