💬 Eunovo commented on pull request "Ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#issuecomment-2708070578)
Thanks for the reviews @l0rinc and @mzumsande . Due to your feedback, I have opened the PR for general review.

🤔 musaHaruna reviewed a pull request: "test: Fix authproxy named args debug logging"
(https://github.com/bitcoin/bitcoin/pull/31955#pullrequestreview-2669050326)
Tested ACK [fac1dd9](https://github.com/bitcoin/bitcoin/commit/fac1dd9dffba1033245c283bc0468e801c14e910)

with change:
``DEBUG:BitcoinRPC:-1-> getblockhash [] {}
{
"jsonrpc": "2.0",
"method": "getblockhash",
"params": {},
"id": 1
}

without change:
`DEBUG:RPC Test:Testing Positional Arguments Only
DEBUG:BitcoinRPC:-1-> getblockhash {}
{
"jsonrpc": "2.0",
"method": "getblockhash",
"params": {},
"id": 1
}
`
Also the new helper function helped in makes the json
...

👍 hebasto approved a pull request: "doc: link to benchcoin over bitcoinperf"
(https://github.com/bitcoin/bitcoin/pull/31996#pullrequestreview-2669098867)
ACK 611999e09777716d1fa686254db20845aff3dffe. I agree. I've had a great experience using it.

🚀 hebasto merged a pull request: "doc: link to benchcoin over bitcoinperf"
(https://github.com/bitcoin/bitcoin/pull/31996)

🚀 hebasto merged a pull request: "doc: warn against having qt6 installed on macOS"
(https://github.com/bitcoin/bitcoin/pull/32017)

💬 hebasto commented on issue "Having qt(@6) breaks build for qt@5 on macOS 15.0 and 13.7":
(https://github.com/bitcoin/bitcoin/issues/31009#issuecomment-2708222708)
> > I opened [#32017](https://github.com/bitcoin/bitcoin/pull/32017) to document this behavior. I suggest we add that PR to the milestone and remove this issue from it. The actual problem can be solved later.
>
> In that case, this issue shouldn't be a blocker for the v29.0 release.

Removed from the 29.0 milestone.

👍 hebasto approved a pull request: "doc: add note to Windows build about stripping bins"
(https://github.com/bitcoin/bitcoin/pull/32002#pullrequestreview-2669121676)
ACK c94195c077ff227e5e2d80e803e1400d7f60812b.

✅ hebasto closed an issue: "docs: Windows build intructions result in a large binary"
(https://github.com/bitcoin/bitcoin/issues/30593)

🚀 hebasto merged a pull request: "doc: add note to Windows build about stripping bins"
(https://github.com/bitcoin/bitcoin/pull/32002)

🤔 fjahr reviewed a pull request: "qa: Fix TxIndex race conditions"
(https://github.com/bitcoin/bitcoin/pull/32010#pullrequestreview-2669125069)
Code review ACK 12a1d5d813640addc8186e7fc882777f5a078164

💬 fjahr commented on pull request "qa: Fix TxIndex race conditions":
(https://github.com/bitcoin/bitcoin/pull/32010#discussion_r1986065651)
nit: I would have put this into `test_framework/test_framework.py` so it can live among its peers `sync_blocks` et al and we would save the import from util. But fine to keep as is.

💬 stratospher commented on pull request "validation: set BLOCK_FAILED_CHILD correctly":
(https://github.com/bitcoin/bitcoin/pull/31835#discussion_r1986067516)
right makes sense, I've moved it to `blockchain_tests.cpp`.

💬 stratospher commented on pull request "validation: set BLOCK_FAILED_CHILD correctly":
(https://github.com/bitcoin/bitcoin/pull/31835#issuecomment-2708240139)
also added 1 more commit 1771866 (taken from https://github.com/bitcoin/bitcoin/pull/16856) since I ran into [this situation](https://github.com/bitcoin/bitcoin/blob/17718660b8c95d1c12124ba2f38baf286a3bddf2/src/test/blockchain_tests.cpp#L151) when using the fuzzer from https://github.com/bitcoin/bitcoin/pull/31533

💬 mabu44 commented on pull request "Docs: fix typos in documentation files":
(https://github.com/bitcoin/bitcoin/pull/32011#issuecomment-2708412062)
crACK 5601bab4f8b01fdef7a54c9e397d513217ab1c1f

💬 moonsettler commented on pull request "BIP-119 (OP_CHECKTEMPLATEVERIFY) (no activation)":
(https://github.com/bitcoin/bitcoin/pull/31989#issuecomment-2708422352)
I don't know how many times we have played this game, but on a positive note ofc I Concept ACK

💬 grubles commented on issue "bitcoind immediately segfaults on ppc64 openbsd 7.4":
(https://github.com/bitcoin/bitcoin/issues/29517#issuecomment-2708435047)
Update: I got access to a POWER9 machine again and tried the ports v27.1. It builds but still segfaults immediately.

💬 stringintech commented on pull request "validation: stricter internal handling of invalid blocks":
(https://github.com/bitcoin/bitcoin/pull/31405#issuecomment-2708437327)
Concept ACK.

I wrote two test cases to understand the general behavior of `InvalidateBlock`, not specifically to test this PR's changes:
```
A->B->C->D->E->F (main chain)
A->B->C->G (fork 1)
A->B->H->I->J (fork 2)
A->B->H->K (fork 3)
```

In the [first test](https://github.com/stringintech/bitcoin/blob/1b36dd6a66a44e8756d92e71baa7676646b5f1ce/src/test/validation_block_tests.cpp#L455), I invalidate block C (on active chain) which should invalidate C, D, E, F, and G. The [second test](h
...

💬 hodlinator commented on pull request "qa: Fix TxIndex race conditions":
(https://github.com/bitcoin/bitcoin/pull/32010#discussion_r1986138492)
Looking at the test_framework.py functions, they're about syncing *between* nodes. Maybe this one could be called `wait_on_txindex()`, but the RPC object uses "synced", so I'm not sure.

💬 mabu44 commented on pull request "cmake: Check for `makensis` tool before using it":
(https://github.com/bitcoin/bitcoin/pull/32019#issuecomment-2708461024)
tACK deea0988720aab65b3cc6d80b50bbf0d537adb24

Got same result as @hodlinator on Debian.

🤔 l0rinc reviewed a pull request: "doc: add missing copyright headers"
(https://github.com/bitcoin/bitcoin/pull/31864#pullrequestreview-2669260943)
Not entirely clear to me when which MIT license URL we're using and when we're using year ranges and when single years.

The changes since my last ack:

<details>
<summary>patch</summary>


```patch
diff --git a/src/clientversion.cpp b/src/clientversion.cpp
--- a/src/clientversion.cpp(revision f4fec329f5353d2b904659e129ade239fee09d89)
+++ b/src/clientversion.cpp(date 1741466438223)
@@ -96,6 +96,6 @@
"\n" +
"\n" +
_("This is experimental software
...