💬 fanquake commented on issue "GCC 13: `-Wdangling-reference` output":
(https://github.com/bitcoin/bitcoin/issues/26926#issuecomment-1542538866)
Closing, now that #27605 has been merged.

✅ fanquake closed an issue: "GCC 13: `-Wdangling-reference` output"
(https://github.com/bitcoin/bitcoin/issues/26926)

💬 fanquake commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1542546467)
Concept ACK - when you get a chance, can you put together a backport PR for `25.x`, so we can see the changes. I think if we want to do that, it'd be preferable to get it into `rc2`.

💬 fanquake commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1542551108)
https://github.com/bitcoin/bitcoin/pull/27125/checks?check_run_id=13380672723
```bash
clang-tidy-16 -p=/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu -quiet /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/zmq/zmqnotificationinterface.cpp
zmq/zmqnotificationinterface.cpp:48:62: error: std::move of the const variable 'gb' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
return std:
...

💬 fanquake commented on pull request "ci: Remove CI_EXEC bloat":
(https://github.com/bitcoin/bitcoin/pull/27616#issuecomment-1542551991)
Concept ACK

💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1542559776)
Updated 87479b2c3a6e5044baf41343e5287ff4bef0547a -> 5ff63a09a9edd1204b2cc56cf6f48a44adab7bb3 ([removeBlockstorageArgs_26](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_27) -> [removeBlockstorageArgs_27](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_27), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_26..removeBlockstorageArgs_27))
* Reverted previous change as suggested by @ryanofsky in [comment](https://github.com/bi
...

💬 fanquake commented on issue "Intermittent failures in interface_usdt_mempool.py":
(https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-1542571731)
master @ e0a70c5b4f2c691e8d6b507c8ce879f0b0424254. https://cirrus-ci.com/task/5247512164958208:
```bash
node0 2023-05-10T17:29:06.449483Z (mocktime: 2023-05-24T17:29:09Z) [httpworker.1] [rpc/request.cpp:181] [parse] [rpc] ThreadRPCServer method=getrawmempool user=__cookie__
test 2023-05-10T17:29:06.450000Z TestFramework (INFO): Polling buffer...
test 2023-05-10T17:29:06.486000Z TestFramework (INFO): Ensuring mempool:rejected event was handled successfully...
test 2023-05-10T17:29:
...

👍 ryanofsky approved a pull request: "refactor, kernel: Decouple ArgsManager from blockstorage"
(https://github.com/bitcoin/bitcoin/pull/27125#pullrequestreview-1421110102)
Code review ACK 5ff63a09a9edd1204b2cc56cf6f48a44adab7bb3. Since last ACK just added std::move and fixed commit title. Sorry for the noise!

⚠️ Spyson opened an issue: "Recovering BTC sent to this Bitcoin address bc1q45puhw8zc5qpgzuuxnefakxckmnldulpgmp0la"
(https://github.com/bitcoin/bitcoin/issues/27619)

✅ pinheadmz closed an issue: "Recovering BTC sent to this Bitcoin address bc1q45puhw8zc5qpgzuuxnefakxckmnldulpgmp0la"
(https://github.com/bitcoin/bitcoin/issues/27619)

💬 sr-gi commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#discussion_r1190289606)
> Wouldn't it be better to make the insertion conditional on `txinfo.m_time <= now - UNCONDITIONAL_RELAY_DELAY` ?

Yeah, I think that makes perfect sense, given there is no point in adding something to the filter if we are going to unconditionally serve it anyway.

> Even then this approach seems like it can trigger false positives fairly easily, since the rolling bloom filter capacity is only 3500 txs?

It may indeed. I haven't got my head around how to properly compute what are the odds
...

💬 grubles commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-1542674907)
Here's the `feature_addrman.py` output:

```
% ./test/functional/feature_addrman.py --tracerpc
2023-05-10T19:08:15.391000Z TestFramework (INFO): PRNG seed is: 3864180829922889342
2023-05-10T19:08:15.392000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_nfcjzxjq
-1-> getblockcount {}
<-1- [0.001573] 199
...

📝 theStack opened a pull request: "test: miner: add coverage for `-blockmintxfee` setting"
(https://github.com/bitcoin/bitcoin/pull/27620)
This PR adds missing test coverage for the `-blockmintxfee` option, which can be used by miners to specify the lowest fee-rate for transactions to be included in blocks. The setting was introduced in PR #9380 (commit daec955fd68bd0da036a5b446b54ffb01108adcd), with the rationale to decouple different minimum fees from `-minrelaytxfee`. According to the PR description it _"should be set by miners to reflect their marginal cost of transmitting extra bytes."_.

On each iteration, the test creates
...

⚠️ hebasto opened an issue: "v25.0 testing"
(https://github.com/bitcoin/bitcoin/issues/27621)
Umbrella issue for 25.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.

Let us know which version you tested on which operating system.

If you find an issue, please search Github for known issues first and then open a new Github issue.

*This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.*

See [25.0 Draft Release Notes](https://github.com/bitcoin-c
...

💬 hebasto commented on issue "Release schedule for 25.0":
(https://github.com/bitcoin/bitcoin/issues/26549#issuecomment-1542693454)
[Here](https://github.com/bitcoin/bitcoin/issues/27621) is an umbrella issue for 25.0 testing.

💬 glozow commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1542695316)
Had a chat with @sdaftuar offline about how safe this RPC is for a miner to expose. He gave an example of a "parent pays for child" package that is currently handled poorly, and a small fix to prevent it. I've added the small fix and a test that contains an example.

Imagine a diamond shape and mempool minfeerate is 5sat/vB:
```
grandparent
5650sat
5649vB
/ \
parent1 parent2
191sat 191sat
191vB 191vB
\ /
child
...

💬 sr-gi commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#discussion_r1190326642)
> Wouldn't it be better to make the insertion conditional on `txinfo.m_time <= now - UNCONDITIONAL_RELAY_DELAY` ?

Also wouldn't that also apply here? https://github.com/bitcoin/bitcoin/blob/27c40e3dcf280a137bcfaa787674c26781d911b8/src/net_processing.cpp#L5688

💬 instagibbs commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1542712701)
note that the :gem: issue still exists in https://github.com/bitcoin/bitcoin/pull/26711 , where the ultimate subpackage(including the child) would let everything in.

with the fix, hopefully, now every sub-package that is let in the mempool must have a child that pays

💬 theuni commented on pull request "build: LLVM 16 & LLD based macOS toolchain":
(https://github.com/bitcoin/bitcoin/pull/21778#issuecomment-1542729737)
> - -bind_at_load support.

I explored this today, and it seems this feature is deprecated. It has been replaced by `fixup_chains` [as of ld64 v512.4](https://github.com/apple-opensource/ld64/commit/03dfd5524c89ea8e1d3a01c8a487934fb5433514). Here's a [write-up on the new functionality](https://www.emergetools.com/blog/posts/iOS15LaunchTime). For ldd (in conflict with what the site above says), the new functionality kicks in when [`OSX_MIN_VERSION` >= 11.0](https://github.com/llvm/llvm-project/
...

💬 willcl-ark commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#issuecomment-1542733164)
Concept ACK