Bitcoin Core Github
44 subscribers
119K links
Download Telegram
📝 fanquake opened a pull request: "doc: update location of minisketch repository"
(https://github.com/bitcoin/bitcoin/pull/31997)
This repository is now at https://github.com/bitcoin-core/minisketch.
👍 hebasto approved a pull request: "doc: update location of minisketch repository"
(https://github.com/bitcoin/bitcoin/pull/31997#pullrequestreview-2661261332)
ACK 972b604dc423f4a2212f5460d08a7f759ea44311.
💬 Sjors commented on pull request "scripted-diff: rename libmultiprocess repository":
(https://github.com/bitcoin/bitcoin/pull/31982#issuecomment-2701076266)
tACK 18749efb07266da5fc8d5a5786ace23d5a42a816

I tested by having depends make `MULTIPROCESS=1` and it fetches it from the new place.

Note that on master it works fine too, because there's a redirect (for now):

```
wget https://github.com/chaincodelabs/libmultiprocess/archive/1954f7f65661d49e700c344eae0fc8092decf975.tar.gz
```
👍 theStack approved a pull request: "qa: clarify and document assumeutxo tests"
(https://github.com/bitcoin/bitcoin/pull/31907#pullrequestreview-2661274494)
ACK e5ff4e416ecc8a51367022eb8a7a291f8cbc0c65
👍 hebasto approved a pull request: "scripted-diff: rename libmultiprocess repository"
(https://github.com/bitcoin/bitcoin/pull/31982#pullrequestreview-2661276891)
ACK 18749efb07266da5fc8d5a5786ace23d5a42a816.
💬 fanquake commented on pull request "scripted-diff: rename libmultiprocess repository":
(https://github.com/bitcoin/bitcoin/pull/31982#issuecomment-2701090667)
Also see https://github.com/bitcoin-core/libmultiprocess/pull/166.
💬 fanquake commented on pull request "doc: update location of minisketch repository":
(https://github.com/bitcoin/bitcoin/pull/31997#issuecomment-2701091731)
Also see: https://github.com/bitcoin-core/minisketch/pull/92.
💬 l0rinc commented on pull request "doc: link to benchcoin over bitcoinperf":
(https://github.com/bitcoin/bitcoin/pull/31996#issuecomment-2701094276)
ACK 611999e09777716d1fa686254db20845aff3dffe

Thanks for updating
🚀 hebasto merged a pull request: "scripted-diff: rename libmultiprocess repository"
(https://github.com/bitcoin/bitcoin/pull/31982)
💬 l0rinc commented on pull request "RFC: Add implicit constructor for `_hex` to `uint256` and remove `consteval_ctor`":
(https://github.com/bitcoin/bitcoin/pull/31991#discussion_r1981508710)
I'll try that, it would likely clarify our byte ordering problem as well
👍 stickies-v approved a pull request: "[28.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/31648#pullrequestreview-2661290228)
ACK e57359c7dd75283363b5f82675531af167742da5
💬 willcl-ark commented on pull request "BIP-119 (OP_CHECKTEMPLATEVERIFY) (no activation)":
(https://github.com/bitcoin/bitcoin/pull/31989#issuecomment-2701106684)
@jamesob I'd be happy to help you keep this thread focused by moderating off-topic comments and pointing them to the appropriate forums.

You've suggested and linked to Delving which seems appropriate for general/conceptual discussion, however there is no thread/post over there to actually point folks to.
Would you mind starting a thread over there so that we have somewhere concrete to point these types of discussions to?
hebasto closed an issue: "build: macOS fuzz instructions broken using latest macOS linker"
(https://github.com/bitcoin/bitcoin/issues/31049)
🚀 hebasto merged a pull request: "doc: update fuzz instructions when on macOS"
(https://github.com/bitcoin/bitcoin/pull/31954)
💬 hebasto commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2701126873)
> [@hebasto's](https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2675061518) are in a different order/selected differently, but the ones I manually checked seem to match...

Here is my shell command:
```sh
find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
```
💬 Sjors commented on pull request "Add waitNext() to BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/31283#issuecomment-2701132902)
@ryanofsky what would be a good way for a consumer of `waitNext()`, directly or via IPC, to abort a wait? Currently only a node shutdown can interrupt it, but in the context of a Template Provider, a stratum client disconnect should probably also abort the wait.
fanquake closed an issue: "Improve description of the `filename` parameter of `loadwallet` RPC"
(https://github.com/bitcoin/bitcoin/issues/30269)
💬 fanquake commented on issue "Improve description of the `filename` parameter of `loadwallet` RPC":
(https://github.com/bitcoin/bitcoin/issues/30269#issuecomment-2701134084)
Closing, given #30302 has been merged.
💬 hebasto commented on issue "Source code mapping for debugger has changed since cmake":
(https://github.com/bitcoin/bitcoin/issues/31204#issuecomment-2701137950)
@hodlinator

Mind submitting a PR?
👍 hodlinator approved a pull request: "ci: Test cross-built Windows executables on Windows natively"
(https://github.com/bitcoin/bitcoin/pull/31176#pullrequestreview-2661348106)
re-ACK 515c64c743d581f84b8be45e5d16968d02264389

- Great that @davidgumberg caught the disrespected exit codes.
- Thanks for adjusting the names!

Realized we also have "macOS-cross, gui, no tests" on Cirrus. Might be nice to also have the equivalent "macOS, test cross-built"?
The Linux/Mac delta is smaller and the compilers the same so probably not as useful in practice.