💬 Sjors commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2701016447)
> behaving differently to the unsigned binaries currently produced by master

I don't think they are. @davidgumberg did you compare this behavior against master?

💬 fanquake commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2701022855)
> I don't think they are. @davidgumberg did you compare this behavior against master?

https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2699746082.

📝 fanquake opened a pull request: "doc: link to benchcoin over bitcoinperf"
(https://github.com/bitcoin/bitcoin/pull/31996)
Seems like linking to https://github.com/bitcoin-dev-tools/benchcoin is now the best thing to do here.

💬 fjahr commented on pull request "test: Use rpc_deprecated only for testing deprecation":
(https://github.com/bitcoin/bitcoin/pull/31977#discussion_r1981464904)
Right, will add it back if I retouch.

💬 Sjors commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#issuecomment-2701037432)
> From what I understand, it's for efficiency.

I understand the general reason, but the code itself and the nuance for different sighash flags is hard to follow.

💬 fanquake commented on pull request "scripted-diff: rename libmultiprocess repository":
(https://github.com/bitcoin/bitcoin/pull/31982#issuecomment-2701048304)
I've made the transfer. See https://github.com/bitcoin-core/libmultiprocess.

👋 fanquake's pull request is ready for review: "scripted-diff: rename libmultiprocess repository"
(https://github.com/bitcoin/bitcoin/pull/31982)

💬 hodlinator commented on issue "Source code mapping for debugger has changed since cmake":
(https://github.com/bitcoin/bitcoin/issues/31204#issuecomment-2701051806)
I find it okay to have to set a mapping for the root directory, but I currently need things like:
```
"/home/hodlinator/b2/build/src/test/util/test/util/": "/home/hodlinator/b2/src/test/util/"
```
Note how the subdirectory needs to be repeated for it to work: `test/util/test/util/`

Same thing happened for rkrux [above](https://github.com/bitcoin/bitcoin/issues/31204#issuecomment-2681660181):
```
...valid location was found at /Users/rkrux/projects/bitcoin/build/src/wallet/wallet/wallet.cpp
```

💬 l0rinc commented on pull request "wallet: Replace "non-0" with "non-zero" in translatable error message":
(https://github.com/bitcoin/bitcoin/pull/31987#issuecomment-2701061871)
ACK 18e83534ace7aa2d26bc7dfa521b1d591b66edfa

While I would prefer changing the extracted strings here, it's not very important.

📝 fanquake opened a pull request: "doc: update location of minisketch repository"
(https://github.com/bitcoin/bitcoin/pull/31997)
This repository is now at https://github.com/bitcoin-core/minisketch.

👍 hebasto approved a pull request: "doc: update location of minisketch repository"
(https://github.com/bitcoin/bitcoin/pull/31997#pullrequestreview-2661261332)
ACK 972b604dc423f4a2212f5460d08a7f759ea44311.

💬 Sjors commented on pull request "scripted-diff: rename libmultiprocess repository":
(https://github.com/bitcoin/bitcoin/pull/31982#issuecomment-2701076266)
tACK 18749efb07266da5fc8d5a5786ace23d5a42a816

I tested by having depends make `MULTIPROCESS=1` and it fetches it from the new place.

Note that on master it works fine too, because there's a redirect (for now):

```
wget https://github.com/chaincodelabs/libmultiprocess/archive/1954f7f65661d49e700c344eae0fc8092decf975.tar.gz
```

👍 theStack approved a pull request: "qa: clarify and document assumeutxo tests"
(https://github.com/bitcoin/bitcoin/pull/31907#pullrequestreview-2661274494)
ACK e5ff4e416ecc8a51367022eb8a7a291f8cbc0c65

👍 hebasto approved a pull request: "scripted-diff: rename libmultiprocess repository"
(https://github.com/bitcoin/bitcoin/pull/31982#pullrequestreview-2661276891)
ACK 18749efb07266da5fc8d5a5786ace23d5a42a816.

💬 fanquake commented on pull request "scripted-diff: rename libmultiprocess repository":
(https://github.com/bitcoin/bitcoin/pull/31982#issuecomment-2701090667)
Also see https://github.com/bitcoin-core/libmultiprocess/pull/166.

💬 fanquake commented on pull request "doc: update location of minisketch repository":
(https://github.com/bitcoin/bitcoin/pull/31997#issuecomment-2701091731)
Also see: https://github.com/bitcoin-core/minisketch/pull/92.

💬 l0rinc commented on pull request "doc: link to benchcoin over bitcoinperf":
(https://github.com/bitcoin/bitcoin/pull/31996#issuecomment-2701094276)
ACK 611999e09777716d1fa686254db20845aff3dffe

Thanks for updating

🚀 hebasto merged a pull request: "scripted-diff: rename libmultiprocess repository"
(https://github.com/bitcoin/bitcoin/pull/31982)

💬 l0rinc commented on pull request "RFC: Add implicit constructor for `_hex` to `uint256` and remove `consteval_ctor`":
(https://github.com/bitcoin/bitcoin/pull/31991#discussion_r1981508710)
I'll try that, it would likely clarify our byte ordering problem as well

👍 stickies-v approved a pull request: "[28.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/31648#pullrequestreview-2661290228)
ACK e57359c7dd75283363b5f82675531af167742da5