👍 theStack approved a pull request: "test: added coverage to mining_basic.py"
(https://github.com/bitcoin/bitcoin/pull/27603#pullrequestreview-1420617170)
ACK a7b46a1feae60e38fe4bdcacf5034f44cae49222

💬 instagibbs commented on pull request "Improve performance of p2p inv to send queues":
(https://github.com/bitcoin/bitcoin/pull/27610#issuecomment-1542201540)
ACK https://github.com/bitcoin/bitcoin/pull/27610/commits/5b3406094f2679dfb3763de4414257268565b943

Significant reduction in CPU usage when influx of transactions is high and sustained. Allows an additional INV to trickle per additional 200 INV backlog.

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1542220359)
trivial re-ACK 886a473fc48f2c7d67436b5d9ac5643cd007e27f 🐗

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: trivial re-ACK 886a
...

💬 sdaftuar commented on pull request "p2p: Avoid prematurely clearing download state for other peers":
(https://github.com/bitcoin/bitcoin/pull/27608#discussion_r1189926154)
Oops -- will fix in a followup. Thanks for catching.

💬 kouloumos commented on issue "rpc: Allow importing wallets by data instead of by filename":
(https://github.com/bitcoin/bitcoin/issues/27597#issuecomment-1542272946)
Is there a specific reason that you need to pass around the whole wallet? You might be able to do a work-around with descriptor wallets (default wallet type since [23.0](https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-23.0.md#wallet)) using the `{list,import}descriptors` RPCs.

💬 fanquake commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542275484)
Ok. This isn't a bug, and can be fixed by reading the documentation. i.e https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md. Closing for now.

✅ fanquake closed an issue: "Method not found"
(https://github.com/bitcoin/bitcoin/issues/27617)

💬 Zero-1729 commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542296157)
Post merge ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

Verified key fingerprint checks out in my local keychain.

💬 jamesob commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542307429)
ACK russ

💬 jamesob commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542309525)

I'm also unable to verify the GPG key.

📝 MarcoFalke converted_to_draft a pull request: "ci: Run iwyu on all src files"
(https://github.com/bitcoin/bitcoin/pull/27571)
This makes it easier to look at the CI output of a file without having to manually add it first to the list.

🤔 instagibbs reviewed a pull request: "rpc: allow submitpackage to be called outside of regtest"
(https://github.com/bitcoin/bitcoin/pull/27609#pullrequestreview-1420792155)
concept ACK

💬 instagibbs commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#discussion_r1190006006)
the string `packagerelay` doesn't exist yet in the codebase

💬 Jackwumingjie commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542318987)
@fanquake I have installed the sqlite, but other error display:
<img width="1078" alt="image" src="https://github.com/bitcoin/bitcoin/assets/39093109/a989acd1-9867-4dd4-b2c2-e1ebc9822660">

💬 MarcoFalke commented on issue "The `libbitcoinkernel` Project":
(https://github.com/bitcoin/bitcoin/issues/24303#issuecomment-1542335212)
Let's continue discussion in #27587?

✅ MarcoFalke closed an issue: "The `libbitcoinkernel` Project"
(https://github.com/bitcoin/bitcoin/issues/24303)

💬 0xB10C commented on pull request "Improve performance of p2p inv to send queues":
(https://github.com/bitcoin/bitcoin/pull/27610#issuecomment-1542339344)
Compared where the time is spent in the `b-msghand` thread on a mainnet `master` and a mainnet 5b3406094f2679dfb3763de4414257268565b943 node that were both running for a while. Followed [eklitzke's flamegraph.md](https://github.com/eklitzke/bitcoin/blob/flamegraphs/doc/flamegraphs.md#generating-a-profile) to create the flamegraphs below. This seems to be indeed a nice performance improvement. The second flamegraph looks _healthier_.

`master`:

![flamegraph-master](https://github.com/bitcoi
...

💬 sipa commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542347503)
@Jackwumingjie Did you recompile?

💬 jamesob commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1542375384)
> What's your feeling on how important figuring out the fix for the pruning issue is at the moment? People don't consider it blocking https://github.com/bitcoin/bitcoin/pull/24008, right?

Right, pruning issues shouldn't block #24008 - those changes need to happen regardless of how we manage pruning with snapshots.

I'll reproduce/investigate the pruning issues over the coming days. But it's worth noting that @Sjors didn't see any regressions in pruning on this branch _before_ loading the sn
...

💬 instagibbs commented on pull request "p2p: Avoid prematurely clearing download state for other peers":
(https://github.com/bitcoin/bitcoin/pull/27608#discussion_r1190051098)
Is this block required anymore now that `ProcessBlock` will call it for us?