💬 fanquake commented on pull request "doc: clarify processing of mempool-msgs when NODE_BLOOM":
(https://github.com/bitcoin/bitcoin/pull/27559#discussion_r1189726780)
@0xB10C did you want to follow up here?

💬 hebasto commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1189731837)
GCC 13 introduced a broken behavior, and we usually do not modify our correct code to make a broken compiler happy. Considering that this is the only line in test code, I lean to agree with this change.

💬 fanquake commented on pull request "ci: Remove CI_EXEC bloat in test/06_script_b.sh":
(https://github.com/bitcoin/bitcoin/pull/27573#issuecomment-1541930822)
Merging this now. #27125 is going to be re-rebased to deal with the (minor) conflict. That PR is also waiting on at least one followup comment.

🚀 fanquake merged a pull request: "ci: Remove CI_EXEC bloat in test/06_script_b.sh"
(https://github.com/bitcoin/bitcoin/pull/27573)

💬 josibake commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1541934810)
post-merge ACK https://github.com/bitcoin/bitcoin/commit/59ebee3fb4181baf20fab263cf1b587ece1bd5e2

Solid track record of review and work on the project. Aside from the obvious fit for an interfaces maintainer, ryanofsky has a track record of thorough review and being able to clearly articulate his reasoning

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1189743041)
Seems unrelated, so maybe do in a follow-up or not at all?

💬 hebasto commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1189744019)
As the test is execute in a single thread, is it big deal to hold `::cs_main` during the entire test case?

Why not to use the pattern as https://github.com/bitcoin/bitcoin/blob/fa266c4bbf564308ddbc12653527226506902084/src/test/interfaces_tests.cpp#L130-L132
?

👋 MarcoFalke's pull request is ready for review: "ci: Run iwyu on all src files"
(https://github.com/bitcoin/bitcoin/pull/27571)

💬 MarcoFalke commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1189746443)
Likely due to a LOCKS_EXCLUDED?

👍 fanquake approved a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611#pullrequestreview-1420387226)
ACK e23088707be2c3bf247f4b777290c8e401db48cb - deals with almost all follow up comments out of #27491.

💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1541983546)
Rebased 8f94f059b3af5ecaf175a95389ba5e73b724203b -> 886a473fc48f2c7d67436b5d9ac5643cd007e27f ([removeBlockstorageArgs_23](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_23) -> [removeBlockstorageArgs_24](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_24), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_23..removeBlockstorageArgs_24))
* Fixed conflicts with https://github.com/bitcoin/bitcoin/pull/27573

💬 hebasto commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541991193)
Concept ACK.

💬 poiuty commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1541991306)
@ayeowch, I ran the script on several vps. Generated a lot of traffic and CPU load increased.
But, the time `bitcoind` was using 100% CPU (single thread) I didn't see much network traffic.

<img src="https://img.poiuty.com/a/ae/f9a79fffd2136c3cfba61a103c3575ae.jpg">

<img src="https://img.poiuty.com/a/d6/9ab34f93219d8f00e91e283c2c750ed6.jpg">

<img src="https://img.poiuty.com/a/58/40789731a81d2332a97a7305fb54af58.jpg">

💬 hebasto commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1189764071)
> Likely due to a LOCKS_EXCLUDED?

Right, in `Chainstate::InvalidateBlock`.

👍 hebasto approved a pull request: "refactor: Replace global find_value function with UniValue::find_value method"
(https://github.com/bitcoin/bitcoin/pull/27605#pullrequestreview-1420414448)
re-ACK fa266c4bbf564308ddbc12653527226506902084

:lock: fanquake locked an issue: "wiadomośc"
(https://github.com/bitcoin-core/gui/issues/718)

:lock: fanquake locked an issue: "View JPEG-encoded data"
(https://github.com/bitcoin-core/gui/issues/707)

🚀 fanquake merged a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611)

💬 hebasto commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#issuecomment-1542019486)
Maybe notice the GCC-13 bug in the comments for `#define WITH_LOCK`?

🤔 hebasto reviewed a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611#pullrequestreview-1420434054)
Post-merge ACK e23088707be2c3bf247f4b777290c8e401db48cb.