📝 osrm opened a pull request: "doc: fix typo and update subtree to resolve CI errors (#31949)"
(https://github.com/bitcoin/bitcoin/pull/31950)
# Description
This PR addresses a simple typo in the file src/secp256k1/src/wycheproof/ecdsa_secp256k1_sha256_bitcoin_test.json, correcting the word "occurences" to "occurrences."

In addition to this typo fix, I updated the subtree for src/secp256k1 to ensure compatibility with the latest changes in the upstream repository. This was necessary due to CI errors related to the previous version of the subtree.

This is related to [PR #31949](https://github.com/bitcoin/bitcoin/pull/31949#issue-
...

✅ maflcko closed a pull request: "wallet: BIP 326 sequence based anti-fee-snipe for taproot inputs"
(https://github.com/bitcoin/bitcoin/pull/24128)

💬 maflcko commented on pull request "wallet: BIP 326 sequence based anti-fee-snipe for taproot inputs":
(https://github.com/bitcoin/bitcoin/pull/24128#issuecomment-2682170560)
Closing for now as up-for-grabs

✅ maflcko closed a pull request: "doc: fix typo and update subtree to resolve CI errors (#31949)"
(https://github.com/bitcoin/bitcoin/pull/31950)

💬 maflcko commented on pull request "doc: fix typo and update subtree to resolve CI errors (#31949)":
(https://github.com/bitcoin/bitcoin/pull/31950#issuecomment-2682175838)
pls no ai slop

💬 rkrux commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#issuecomment-2682201267)
I'm reviewing this PR again and will leave a review later.

Re: https://github.com/bitcoin/bitcoin/pull/31622#discussion_r1963414552

> I still can't wrap my head around the logic of how and why we drop non_witness_utxos.

@Sjors From what I understand, it's for efficiency. If a PSBT contains only witness v1 utxos, then the PSBT doesn't need (and can be removed) information for the previous transactions (`non_witness_utxos`) since signing the segwit v1 inputs commits to the values of the A
...

📝 fanquake locked a pull request: "doc: fix typo and update subtree to resolve CI errors (#31949)"
(https://github.com/bitcoin/bitcoin/pull/31950)
# Description
This PR addresses a simple typo in the file src/secp256k1/src/wycheproof/ecdsa_secp256k1_sha256_bitcoin_test.json, correcting the word "occurences" to "occurrences."

In addition to this typo fix, I updated the subtree for src/secp256k1 to ensure compatibility with the latest changes in the upstream repository. This was necessary due to CI errors related to the previous version of the subtree.

This is related to [PR #31949](https://github.com/bitcoin/bitcoin/pull/31949#issue-
...

⚠️ fanquake opened an issue: "ci: failure in interface_usdt_utxocache.py"
(https://github.com/bitcoin/bitcoin/issues/31951)
https://github.com/bitcoin/bitcoin/actions/runs/13501527489/job/37720897174?pr=31945:
```bash
UTXOCacheChange(outpoint=fab2396e3f726e1801b9e7303cf294783a3fd7e19ddc8f2dfa55e25b01575b3e:0, height=77, value=5000000000sat, is_coinbase=True)
test 2025-02-24T16:25:34.721000Z TestFramework (INFO): check that we successfully traced 2 adds and 1 spent
test 2025-02-24T16:25:34.721000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):

...

🤔 pablomartin4btc reviewed a pull request: "refactor: CLI cleanups"
(https://github.com/bitcoin/bitcoin/pull/31887#pullrequestreview-2641354371)
cr ACK ccc34a26170ef8c63a6f211eda4464e954873e89

Regarding the 3rd [commit](3252f3bab02605129a568112f650ef3cb29703b7):
- for the exceptions case, perhaps this can be done in a separate PR as I can see other places where we are using `class` outside `CLI` if we want to be consistent (and if we think we won't require encapsulation for them).
- for the `*RequestHandler`, are we sure the internal representation of these objects and what they expose won't change at any time in the future? It look
...

👍 fanquake approved a pull request: "depends: Update libmultiprocess library to fix CI failures"
(https://github.com/bitcoin/bitcoin/pull/31945#pullrequestreview-2641354989)
ACK 01f771576608403dbfc5dee4fcdd84ef262f9390

🚀 fanquake merged a pull request: "depends: Update libmultiprocess library to fix CI failures"
(https://github.com/bitcoin/bitcoin/pull/31945)

🤔 pablomartin4btc reviewed a pull request: "Add assumeutxo chainparams to release-process.md"
(https://github.com/bitcoin/bitcoin/pull/31940#pullrequestreview-2641362331)
ACK 8b5a50cb353d9524db38a3cfd537bac7a770e1a6

:lock: fanquake locked an issue: "clang ubsan build fails link step after cmake migration"
(https://github.com/bitcoin/bitcoin/issues/31947)

✅ fanquake closed an issue: "TestFramework: TestShell.reset() will always fail"
(https://github.com/bitcoin/bitcoin/issues/31131)

🚀 fanquake merged a pull request: "test: fix TestShell initialization and reset()"
(https://github.com/bitcoin/bitcoin/pull/31415)

📝 fanquake converted_to_draft a pull request: "RFC: build: support for pre-compiled headers."
(https://github.com/bitcoin/bitcoin/pull/31053)
This cuts off roughly a third of my total build time, either with `-j8` or `-j24`.

There are many different ways to go about adding pre-compiled header support with CMake. This is probably the simplest and most naive, but it has a substantial impact.

I used [ClangBuildAnalyzer](https://github.com/aras-p/ClangBuildAnalyzer) to measure the headers which took the most amount of time to parse while building the kernel library. I did this under the assumption that those are probably the most in
...

✅ maflcko closed an issue: "intermittent ipc_tests (Timeout)"
(https://github.com/bitcoin/bitcoin/issues/31921)

💬 maflcko commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2682277126)
Looks like this missed feature-freeze and can be removed from the milestone for now?

💬 maflcko commented on issue "cmake: incorrectly reporting MSVC as using ccache":
(https://github.com/bitcoin/bitcoin/issues/31771#issuecomment-2682283428)
Is the msvc compile a blocker for the release? I've removed the milestone from https://github.com/bitcoin/bitcoin/pull/30861 because it looks more like an involved feature than a bugfix, so maybe it can be removed here as well?

💬 fanquake commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2682314458)
I'm going to re-add it, it'd be good to fix because there are a number of regressions here.