:lock: fanquake locked an issue: "Btc mining"
(https://github.com/bitcoin/bitcoin/issues/27612)

💬 Sjors commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1541467462)
When running 8f431ad3b600a8f7e6dff83354ac3475b8936505 I noticed (and reproduced) that `-prune` is not fully honored when loading a snapshot and doing background validation. When I set `-prune=550` the blocks dir ends up somewhere between 3 and 5 GB. Judging by the blk….dat timestamps it seems that both the snapshot and background IBD hold on to more blocks than they should. Tested on Ubuntu 23.04 and with coinstats- and blockfilterindex enabled. The first time I tested I allowed the node to sync
...

🤔 darosior reviewed a pull request: "Improve performance of p2p inv to send queues"
(https://github.com/bitcoin/bitcoin/pull/27610#pullrequestreview-1419935557)
utACK 5b3406094f2679dfb3763de4414257268565b943

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1541493057)
Nice.

re-ACK 24f1ace25081040af80ba4cf1636592266d8dbb5 🌦

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: re-ACK 24f1ace25
...

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1541494448)
trivial rebase re-ACK 8f94f059b3af5ecaf175a95389ba5e73b724203b 🗝

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: trivial reba
...

💬 Sjors commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1541496964)
My highest `bytessent_per_msg` is 65 MB (mostly to the university nodes and Bitnodes), i.e. a lot less than the 2.5 GB @ayeowch is seeing. CPU still calm. My node has 114 inbound connections (and 10 out).

💬 TheCharlatan commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541546516)
Updated d0767a9e0af367cbcc4ff7fce3758ece7d62861f -> ef39bdf0f709db1b3bfa07adddce7cccbd774109 ([followUp27491_0](https://github.com/TheCharlatan/bitcoin/tree/followUp27491_0) -> [followUp27491_1](https://github.com/TheCharlatan/bitcoin/tree/followUp27491_1), [compare](https://github.com/TheCharlatan/bitcoin/compare/followUp27491_0..followUp27491_1))
* Addressed @MarcoFalke's [comment](https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541456801), removing exception docstring.
* Added s
...

👍 MarcoFalke approved a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611#pullrequestreview-1420053321)
lgtm, found another nit, feel free to ignore

💬 MarcoFalke commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#discussion_r1189539373)
The return type is wrong, too. So maybe remove this line as well, as it is redundant with the line above it. Also, in the line above, can remove the return type, as it is redundant with the C++ code?

💬 MarcoFalke commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#discussion_r1189540735)
Same

💬 MarcoFalke commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#discussion_r1189543228)
I think the scripted diff can be dropped, given that it fails? Maybe include this diff in the previous commit?

📝 hebasto converted_to_draft a pull request: "Enable HW-accelerated implementations of SHA256 for MSVC builds"
(https://github.com/bitcoin/bitcoin/pull/24773)
This PR enables AVX2, SSE4.1 and x86 SHA-NI implementations of SHA256 instead of the "standard" one.

**NOTE about testing**. During runtime the SHA-NI implementation is available only if a CPU has the `sha_ni` flag set.

💬 MarcoFalke commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1189586654)
I wonder if we can make those two getters return `Result`s, instead of throwing exceptions.

I tried that in the past because there was an unguarded call in the gui, which would then cause a segfault, but that seems now fixed. Still, low-prio and long-term this may be a thing to keep in mind.

💬 TheCharlatan commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541627066)
Updated ef39bdf0f709db1b3bfa07adddce7cccbd774109 -> e23088707be2c3bf247f4b777290c8e401db48cb ([followUp27491_1](https://github.com/TheCharlatan/bitcoin/tree/followUp27491_1) -> [followUp27491_2](https://github.com/TheCharlatan/bitcoin/tree/followUp27491_2), [compare](https://github.com/TheCharlatan/bitcoin/compare/followUp27491_1..followUp27491_2))
* Addressed @MarcoFalke's [comment](https://github.com/bitcoin/bitcoin/pull/27611#discussion_r1189539373), but kept the first line of the docstring
...

💬 Sjors commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1541635412)
@ayeowch running that particular script against a modest Intel i5-8400 with 6 cores, either from another computer on the LAN or from the machine itself, I don't see any noticeable CPU difference (compared to all the other stuff its running). Even when downloading 10GB of headers in a few minutes, which is probably a faster download rate than you experienced given the total (though you tally disconnected peers too I suppose).

💬 Sjors commented on pull request "assumeutxo: net_processing changes":
(https://github.com/bitcoin/bitcoin/pull/24008#discussion_r1189596088)
I only meant the comparison to `MinimumChainWork()`.

💬 fanquake commented on pull request "rpc: append rpcauth.py hash in config and show pass":
(https://github.com/bitcoin/bitcoin/pull/27588#issuecomment-1541643064)
@st3b1t note that you've left the commit messages from the squashed commits in e1046eca9d637dfd29599d156a57a8a3a7440b23.

🚀 fanquake merged a pull request: "p2p: Avoid prematurely clearing download state for other peers"
(https://github.com/bitcoin/bitcoin/pull/27608)

👍 MarcoFalke approved a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611#pullrequestreview-1420153649)
lgtm

🚀 fanquake merged a pull request: "add ryanofsky to trusted-keys"
(https://github.com/bitcoin/bitcoin/pull/27604)