👍 theStack approved a pull request: "test: fix TestShell initialization and reset()"
(https://github.com/bitcoin/bitcoin/pull/31415#pullrequestreview-2634390510)
Tested ACK 303f8cca0568d2ca77189c4eccdfc7a6913c958d

🤔 sipa reviewed a pull request: "cluster mempool: introduce TxGraph"
(https://github.com/bitcoin/bitcoin/pull/31363#pullrequestreview-2634380073)
Addressed most comments. I will address the `PostLinearize` related ones later.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966264402)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966264642)
Removed it.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966264980)
It's mostly to avoid consuming 12 bytes from the fuzz data for every transaction; added a comment.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966264497)
This has been rewritten already.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966266270)
Fixed.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966266151)
I've added a comment. `~Ref` triggers observable behavior in TxGraph, so the simulation controls when it gets called (and its ordering w.r.t. other operations).

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966265505)
This dates from a time when the fuzz test allowed up to 1000 steps, and it felt unnecessary to support cases with unboundedly growing numbers of removed transactions. I've just dropped it.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966267798)
Done, largely.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966270811)
Indeed, done.

✅ yancyribbens closed an issue: "Fuzzing Bitcoin Core with clang-16"
(https://github.com/bitcoin/bitcoin/issues/31922)

💬 yancyribbens commented on issue "Fuzzing Bitcoin Core with clang-16":
(https://github.com/bitcoin/bitcoin/issues/31922#issuecomment-2675759929)
> What are the exact steps to reproduce?

Following the docs here: https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md. `cmake --preset=libfuzzer` was fine, it was the next `cmake --build build_fuzz` that was failing.

Looks like nuking `./bld-fzz` did the trick. Should have thought to try a fresh checkout. Thanks!

💬 instagibbs commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966322708)
major reading comprehension issues it seems

💬 instagibbs commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966324252)
yes, thanks

💬 instagibbs commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966333596)
hah, was my first guess that I doubted :)

💬 instagibbs commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1966335575)
saw the updated comment/code in SanityCheck, makes sense

💬 instagibbs commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#issuecomment-2675849453)
verified changes, just waiting on further PostLinearization commentary

via `git range-diff master 11135464c5c3aef1ce8d2823120467a522ce2c87 d5abb86439e79d4adfbfbd46f833268bbca0bf6e`

💬 yancyribbens commented on pull request "Wallet: Add `maxfeerate` wallet startup option":
(https://github.com/bitcoin/bitcoin/pull/29278#discussion_r1966342676)
```suggestion
- A new wallet startup option `-maxfeerate` is added.
```

💬 yancyribbens commented on pull request "Wallet: Add `maxfeerate` wallet startup option":
(https://github.com/bitcoin/bitcoin/pull/29278#discussion_r1966343083)
```suggestion
// m_max_tx_fee. This is merely a belt-and-suspenders check).
```