💬 fanquake commented on pull request "refactor: Remove redundant definitions":
(https://github.com/bitcoin/bitcoin/pull/29492#issuecomment-2672364141)
Closing for now.

💬 ryanofsky commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2672364401)
> Setting `base_dir` to `CMAKE_SOURCE_DIR` won't be helpful in cases when a worktree or a build directory resides outside of the repository root, for example, it is a sibling directory.

I don't understand why it wouldn't be helpful when a worktree is outside the repository root. If source directories are `/tree1/` and `/tree2` and build directories are `/tree1/build` and `/tree2/build` I would expect source paths like `src/init.cpp` to be treated like `../src/init.cpp` in both cases and for
...

💬 fanquake commented on pull request "refactor: Remove redundant definitions":
(https://github.com/bitcoin/bitcoin/pull/29492#discussion_r1964153309)
Maybe we can circle back with a future version.

✅ fanquake closed an issue: "CI: Failed pulls from docker.io causing jobs to fail"
(https://github.com/bitcoin/bitcoin/issues/31797)

🚀 fanquake merged a pull request: "ci: Switch to gcr.io mirror to avoid rate limits"
(https://github.com/bitcoin/bitcoin/pull/31906)

💬 fanquake commented on pull request "doc: add missing copyright headers":
(https://github.com/bitcoin/bitcoin/pull/31864#discussion_r1964160825)
I have changes for this locally, but the value is low, and ideally all of this code will soon be removed.

💬 hebasto commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2672379835)
> I do understand that setting `base_dir` to `CMAKE_SOURCE_DIR` will not work if developers are placing their build directories completely outside of their source directories, or at inconsistent depths within their source directories, but this seems much less common and not really a consideration if we are just deciding on a default base_dir value.

Right. As for the PR author, it was not clear to me which cases are more common and which are less common, so I tried to take a more general appro
...

💬 hebasto commented on pull request "cmake: Set top-level target output locations":
(https://github.com/bitcoin/bitcoin/pull/31161#issuecomment-2672397183)
> Code review ACK [879569c](https://github.com/bitcoin/bitcoin/commit/879569cab4e5b400350f3b95d7bee71b49636591) (no changes since last review other than rebase), but [again](https://github.com/bitcoin/bitcoin/pull/31161#issuecomment-2631914588) I think this PR should be prefixed with [BREAKING] or [INCOMPATIBLE] or [!] or ‼️ or ⚠️ and have a clear message to developers about what it does like "**Warning**: This PR changes build locations of newly built executables like `bitcoind` and `test_bitco
...

✅ fanquake closed a pull request: "Silent payment index (for light wallets and consistency check)"
(https://github.com/bitcoin/bitcoin/pull/28241)

💬 fanquake commented on pull request "Silent payment index (for light wallets and consistency check)":
(https://github.com/bitcoin/bitcoin/pull/28241#issuecomment-2672407221)
Closing this for now, given after a year and a half it's still a draft, based on a draft, based on another PR that is still being worked on. Maybe a new PR can be opened in future.

💬 jsarenik commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2672409040)
How will the default signet directory name be here with this patch?

Could it possibly stay `signet` for the default [Signet](https://en.bitcoin.it/wiki/Signet)? I think the advantages of one default Signet are huge, one of them being the fact you can use [mempool.space/signet](https://mempool.space/signet). There is now a working faucet at [alt.signetfaucet.com](https://alt.signetfaucet.com/).

💬 1440000bytes commented on pull request "Implement OP_CHECKSIGFROMSTACK(VERIFY)":
(https://github.com/bitcoin/bitcoin/pull/29270#issuecomment-2672409877)
Quoting a line from a recent post written by AJ as a soft forking guide:

> Open a PR for the changes to core, along with thorough tests

https://ajtowns.github.io/bfg/finalization.html

✅ fanquake closed a pull request: "Implement OP_CHECKTEMPLATEVERIFY"
(https://github.com/bitcoin/bitcoin/pull/29280)

💬 fanquake commented on pull request "Implement OP_CHECKTEMPLATEVERIFY":
(https://github.com/bitcoin/bitcoin/pull/29280#issuecomment-2672416455)
Closing for now, given https://github.com/bitcoin/bitcoin/pull/29198 was closed.

📝 instagibbs opened a pull request: "fuzz: add basic TxOrphanage::EraseForBlock cov"
(https://github.com/bitcoin/bitcoin/pull/31918)
Currently uncovered

💬 fanquake commented on pull request "fuzz: Mutate -max_len= during generation phase":
(https://github.com/bitcoin/bitcoin/pull/30371#issuecomment-2672445780)
> Turning into draft for now, to allow for more time to benchmark and evaluate this.

Any more thoughts on this?

✅ maflcko closed a pull request: "fuzz: Mutate -max_len= during generation phase"
(https://github.com/bitcoin/bitcoin/pull/30371)

💬 fanquake commented on pull request "ci: run in worktrees":
(https://github.com/bitcoin/bitcoin/pull/31787#issuecomment-2672448003)
Is this still meant to be a draft?

💬 i-am-yuvi commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2672450161)
@jsarenik read the PR description https://github.com/bitcoin/bitcoin/pull/29838#issue-2233837348

✅ willcl-ark closed a pull request: "[WIP] net: return result from addnode RPC"
(https://github.com/bitcoin/bitcoin/pull/30381)