💬 kevkevinpal commented on pull request "doc: add release note for #27432 (utxo-to-sqlite tool)":
(https://github.com/bitcoin/bitcoin/pull/31879#issuecomment-2661204063)
ACK [95722d0](https://github.com/bitcoin/bitcoin/pull/31879/commits/95722d048a85a313b35c69459680f734feb67695)

💬 kevkevinpal commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1957232376)
instead of removing this test we can keep it if we restart the node with the previous max orphan amount

```
self.restart_node(0, extra_args=["-maxorphantx=" + str(DEFAULT_MAX_ORPHAN_TRANSACTIONS)])
```

and we can probably move `DEFAULT_MAX_ORPHAN_TRANSACTIONS` into this `test_max_orphan_amount` and rename it to `max_orphan_amount` since this isnt the default max orphan amount anymore.

If we still don't want this test we can remove `DEFAULT_MAX_ORPHAN_TRANSACTIONS` since it is only use
...

💬 am-sq commented on pull request "doc: clarify loadwallet path loading for wallets":
(https://github.com/bitcoin/bitcoin/pull/30302#discussion_r1957237059)
Fixed- thanks!

💬 am-sq commented on pull request "doc: clarify loadwallet path loading for wallets":
(https://github.com/bitcoin/bitcoin/pull/30302#discussion_r1957237067)
Done!

💬 am-sq commented on pull request "doc: clarify loadwallet path loading for wallets":
(https://github.com/bitcoin/bitcoin/pull/30302#discussion_r1957237099)
Good point, removed example to simplify.

💬 am-sq commented on pull request "doc: clarify loadwallet path loading for wallets":
(https://github.com/bitcoin/bitcoin/pull/30302#discussion_r1957237107)
Done

💬 am-sq commented on pull request "doc: clarify loadwallet path loading for wallets":
(https://github.com/bitcoin/bitcoin/pull/30302#discussion_r1957237129)
Done

💬 i-am-yuvi commented on pull request "test: Rename send_message to send_without_ping":
(https://github.com/bitcoin/bitcoin/pull/31859#issuecomment-2661290722)
Concept ACK
I agree!

🤔 hebasto reviewed a pull request: "build: move `rpc/external_signer` to node library"
(https://github.com/bitcoin/bitcoin/pull/31865#pullrequestreview-2619558416)
Post-merge ACK e501246e77cc36cff222fb07aed2fd1316e11e19.

💬 hebasto commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2661312894)
> > I'm not sure about the `guix-build-096525e92cc2/output/dist-archive/bitcoin-096525e92cc2-codesignatures-e252afe1296a.tar.gz` artifact in the output.
>
> Not sure about it in what way?

Oh, I missed [this](https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2654397674) comment, which resolves my concerns.

💬 hebasto commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2661323430)
> Tested a Windows-specific part:
>
> ```
> $ env HOSTS=x86_64-w64-mingw32
> $ ./contrib/guix/guix-build
> $ ./contrib/guix/guix-codesign
> $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
> ac50a82cb146e016d5d643460dc4ff7452a70497f2d95f76cee2bcfd82724ab6 guix-build-096525e92cc2/output/dist-archive/bitcoin-096525e92cc2-codesignatures-e252afe1296a.tar.gz
> 504608f78dc2be04bda41dc212d3cbb09afd270485884b03b426ad596b4b3
...

🤔 i-am-yuvi reviewed a pull request: "doc: add missing copyright headers"
(https://github.com/bitcoin/bitcoin/pull/31864#pullrequestreview-2619570364)
ACK 01b9a6183eb58dffac00f053e2742d924c84c721

💬 hebasto commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2661370269)
I've redone the entire process from scratch using [these](https://github.com/pinheadmz/bitcoin-detached-sigs/tree/achow101-macos-notarization-096525e92cc2) signatures:
```
207621cdc43868870f4136e9e6784a2a3e9ba89ec1edc6fa92b315cfa3c4432c guix-build-096525e92cc2/output/arm64-apple-darwin-codesigned/SHA256SUMS.part
111016205f0a2ac732feb934acb3e8a36d5251f119d8fa9215790310ba46c31d guix-build-096525e92cc2/output/arm64-apple-darwin-codesigned/bitcoin-096525e92cc2-arm64-apple-darwin.tar.gz
a1228dd
...

🚀 fanquake merged a pull request: "doc: add release note for #27432 (utxo-to-sqlite tool)"
(https://github.com/bitcoin/bitcoin/pull/31879)

📝 hebasto opened a pull request: "cmake: Add optional source files to libraries directly"
(https://github.com/bitcoin/bitcoin/pull/31880)
This PR provides an extended alternative to https://github.com/bitcoin/bitcoin/pull/31268, featuring the following differences:
1. A new `TargetSourcesWithCompileOptions` module has been introduced to minimise code verbosity and enhance readability.
2. In addition to changes for `bitcoin_crypto` and `crc32c`, the build script for the `minisketch` library has been reworked. In particular, [this comment](https://github.com/bitcoin/bitcoin/pull/30911#discussion_r1953081930) has been addressed and
...

💬 hebasto commented on pull request "cmake: add optional source files to bitcoin_crypto and crc32c directly":
(https://github.com/bitcoin/bitcoin/pull/31268#issuecomment-2661419077)
https://github.com/bitcoin/bitcoin/pull/31880 provides an extended alternative to this PR.

Since this one has already been reviewed, I'm OK with merging it as is.

⚠️ hebasto opened an issue: "qa: `wallet_importdescriptors` failure "TypeError: 'bool' object is not subscriptable""
(https://github.com/bitcoin/bitcoin/issues/31881)
From https://github.com/bitcoin/bitcoin/actions/runs/13355177559/job/37296904714:
```
244/317 - wallet_importdescriptors.py --descriptors failed, Duration: 13 s

stdout:
2025-02-16T12:59:56.602000Z TestFramework (INFO): PRNG seed is: 3316204795374696824
2025-02-16T12:59:56.602000Z TestFramework (INFO): Initializing test directory /Users/runner/work/bitcoin/bitcoin/ci/scratch/test_runner/test_runner_₿_🏃_20250216_125556/wallet_importdescriptors_99
2025-02-16T12:59:57.273000Z TestFramework (INFO):
...

💬 s373nZ commented on pull request "cmake: Add `libbitcoinkernel` target":
(https://github.com/bitcoin/bitcoin/pull/31869#issuecomment-2661469280)
ACK https://github.com/bitcoin/bitcoin/commit/3a914ab96bdeb70cdf848dd74deda5a80d0a7f78

Tested compilation as per the usage example in the description with the same results -- no rebuild between targets `libbitcoinkernel` and `bitcoinkernel`. Kernel library is installable via `--component libbitcoinkernel`, but `--component bitcoinkernel` is not recognized. Works as expected.

While testing, I learned to generate with a clean `build` directory, or pass `--fresh` so that `-DBUILD_KERNEL_LIB`
...

⚠️ GregTonoski opened an issue: "bitcoind shouldn't fail to progress with synchronization: endless [leveldb] Generated table... logs"
(https://github.com/bitcoin/bitcoin/issues/31882)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

bitcoind doesn't progress with synchronization despite approx. 4 months lag, doesn't consume much CPU or RAM, uses disk IO, produces large amount of logs like e.g. `[leveldb] Generated table #3982690@4: 31588 keys, 2162389 bytes` for hours (there was a test for more than 8 hours).

### Expected behaviour

bitcoind finishes synchronization in an hour or so.

### Steps to reproduce

Precondi
...

⚠️ instagibbs opened an issue: "SignatureCreator should supply auxiliary data argument for additional bip340 signature security"
(https://github.com/bitcoin/bitcoin/issues/31883)
https://github.com/bitcoin/bitcoin/blob/db36a92c02b83f2e6477a5a55fc061319f7cc6a3/src/script/sign.cpp#L87

It's additive and should be a pretty easy lift?