💬 hodlinator commented on pull request "Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior":
(https://github.com/bitcoin/bitcoin/pull/30529#discussion_r1956787128)
Was about to add built-in `assert` in a small fix in #31874, took the opportunity to tentatively add `assert_true()`.

🚀 achow101 merged a pull request: "build: move `rpc/external_signer` to node library"
(https://github.com/bitcoin/bitcoin/pull/31865)

🤔 furszy reviewed a pull request: "wallet: fix rescanning inconsistency"
(https://github.com/bitcoin/bitcoin/pull/31629#pullrequestreview-2618920102)
utACK 4818da809f0e300016390dd41e02c6067ffa008f

📝 l0rinc opened a pull request: "RFC: SortedWrite descending by hash"
(https://github.com/bitcoin/bitcoin/pull/31875)
This is an extension of [optimization: increase default LevelDB write batch size to 64 MiB](https://github.com/bitcoin/bitcoin/pull/31645) - draft for now to receive comments.

It looks like sorting the coins before flushing speeds up `MemTable` insertion considerably (will move the image to comments, after undrafting):

Ran a few `assumeUTXO` loads and a few complete reindexes to check the L
...

📝 l0rinc converted_to_draft a pull request: "RFC: SortedWrite descending by hash"
(https://github.com/bitcoin/bitcoin/pull/31875)
This is an extension of [optimization: increase default LevelDB write batch size to 64 MiB](https://github.com/bitcoin/bitcoin/pull/31645) - draft for now to receive comments.

It looks like sorting the coins before flushing speeds up `MemTable` insertion considerably (will move the image to comments, after undrafting):

Ran a few `assumeUTXO` loads and a few complete reindexes to check the L
...

💬 achow101 commented on pull request "wallet: fix rescanning inconsistency":
(https://github.com/bitcoin/bitcoin/pull/31629#issuecomment-2660391333)
ACK 4818da809f0e300016390dd41e02c6067ffa008f

💬 achow101 commented on pull request "test: cover base[32|58|64] with symmetric roundtrip fuzz (and padding) tests":
(https://github.com/bitcoin/bitcoin/pull/30746#issuecomment-2660410374)
f919d919eb8425ef2bb25aa0ebf61c90ab9b07fa

✅ achow101 closed an issue: "Potential crash (assert) rescanning wallet"
(https://github.com/bitcoin/bitcoin/issues/31474)

🚀 achow101 merged a pull request: "wallet: fix rescanning inconsistency"
(https://github.com/bitcoin/bitcoin/pull/31629)

💬 achow101 commented on pull request "random: Initialize variables in hardware RNG functions":
(https://github.com/bitcoin/bitcoin/pull/31863#issuecomment-2660417019)
ACK 99755e04ffadd5daad53c686f4f0feee2232eeb2

🚀 achow101 merged a pull request: "test: cover base[32|58|64] with symmetric roundtrip fuzz (and padding) tests"
(https://github.com/bitcoin/bitcoin/pull/30746)

💬 achow101 commented on issue "guix: Unable to reproduce macOS SDK tarball on Fedora 40":
(https://github.com/bitcoin/bitcoin/issues/31873#issuecomment-2660423530)
> `pkgdiff` reports the contents of the two tarballs are identical:

Try `diffoscope` (be prepared for very long output, and probably very long runtime).

💬 achow101 commented on pull request "wallet: fix crash on double block disconnection":
(https://github.com/bitcoin/bitcoin/pull/31757#issuecomment-2660425278)
Concept ACK

💬 achow101 commented on pull request "Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior":
(https://github.com/bitcoin/bitcoin/pull/30529#issuecomment-2660436771)
ACK a85e8c0e6158fad2408bda5cb1e36da707eb081b

🚀 achow101 merged a pull request: "random: Initialize variables in hardware RNG functions"
(https://github.com/bitcoin/bitcoin/pull/31863)

💬 l0rinc commented on pull request "qa wallet: Activate dormant checks in wallet_multisig_descriptor_psbt.py":
(https://github.com/bitcoin/bitcoin/pull/31874#discussion_r1956826301)
Good find!
In other cases we seem to simply compare with the expected boolean value, e.g. https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_addrman.py#L89 - is that an option here?

🤔 l0rinc requested changes to a pull request: "qa wallet: Activate dormant checks in wallet_multisig_descriptor_psbt.py"
(https://github.com/bitcoin/bitcoin/pull/31874#pullrequestreview-2618982626)
Good find, two observations/requests:
*) Can we use `assert_equal(all(), True)` for consistency?
*) Can we convert the remaining `assert all()` constructs to whatever we will end up using here?

💬 l0rinc commented on pull request "qa wallet: Activate dormant checks in wallet_multisig_descriptor_psbt.py":
(https://github.com/bitcoin/bitcoin/pull/31874#discussion_r1956826562)
Can we unify the remaining `assert all()` constructs as well, e.g. https://github.com/bitcoin/bitcoin/blob/master/test/functional/wallet_conflicts.py#L152 ?

🚀 achow101 merged a pull request: "Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior"
(https://github.com/bitcoin/bitcoin/pull/30529)

💬 achow101 commented on pull request "contrib: add tool to convert compact-serialized UTXO set to SQLite database":
(https://github.com/bitcoin/bitcoin/pull/27432#issuecomment-2660447738)
ACK 4080b66cbec2b6fc2fcfd7356941236f65d508e3