💬 achow101 commented on pull request "doc: build: Fix instructions for msvc gui builds":
(https://github.com/bitcoin/bitcoin/pull/31851#issuecomment-2660364547)
ACK c3fa043ae560289759b6f836ac62736d97ba91bf

🚀 achow101 merged a pull request: "doc: build: Fix instructions for msvc gui builds"
(https://github.com/bitcoin/bitcoin/pull/31851)

💬 achow101 commented on pull request "build: move `rpc/external_signer` to node library":
(https://github.com/bitcoin/bitcoin/pull/31865#issuecomment-2660374335)
ACK e501246e77cc36cff222fb07aed2fd1316e11e19

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956785027)
Indeed, fixed.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956785498)
Done. I have actually added a bunch of functions (`IsAcceptable()`, `IsOptimal()`, `NeedsSplitting()`, and further on also `IsOversized()`) and mostly rewritten the long conditions involving `m_quality` to use these functions instead.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956785650)
I have expanded on this. LMK if it's clearer now.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956785706)
Done.

📝 hodlinator opened a pull request: "qa wallet: Activate dormant checks in wallet_multisig_descriptor_psbt.py"
(https://github.com/bitcoin/bitcoin/pull/31874)
Conditions had virtually no effect, lets activate them.

Also adds `assert_true()` which (unlike built-in `assert`) is kept in optimized Python executions, discussed in https://github.com/bitcoin/bitcoin/pull/30529#discussion_r1893029530

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956786541)
I see this was a bit confusing, I have expanded the explanation.

But what I meant to convey was that (M) **in staging** means that if the transaction does not exist in main, it doesn't exist in staging either. A (P) in staging just means it exists there. LMK if the new explanation is clearer.

💬 hodlinator commented on pull request "Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior":
(https://github.com/bitcoin/bitcoin/pull/30529#discussion_r1956787128)
Was about to add built-in `assert` in a small fix in #31874, took the opportunity to tentatively add `assert_true()`.

🚀 achow101 merged a pull request: "build: move `rpc/external_signer` to node library"
(https://github.com/bitcoin/bitcoin/pull/31865)

🤔 furszy reviewed a pull request: "wallet: fix rescanning inconsistency"
(https://github.com/bitcoin/bitcoin/pull/31629#pullrequestreview-2618920102)
utACK 4818da809f0e300016390dd41e02c6067ffa008f

📝 l0rinc opened a pull request: "RFC: SortedWrite descending by hash"
(https://github.com/bitcoin/bitcoin/pull/31875)
This is an extension of [optimization: increase default LevelDB write batch size to 64 MiB](https://github.com/bitcoin/bitcoin/pull/31645) - draft for now to receive comments.

It looks like sorting the coins before flushing speeds up `MemTable` insertion considerably (will move the image to comments, after undrafting):

Ran a few `assumeUTXO` loads and a few complete reindexes to check the L
...

📝 l0rinc converted_to_draft a pull request: "RFC: SortedWrite descending by hash"
(https://github.com/bitcoin/bitcoin/pull/31875)
This is an extension of [optimization: increase default LevelDB write batch size to 64 MiB](https://github.com/bitcoin/bitcoin/pull/31645) - draft for now to receive comments.

It looks like sorting the coins before flushing speeds up `MemTable` insertion considerably (will move the image to comments, after undrafting):

Ran a few `assumeUTXO` loads and a few complete reindexes to check the L
...

💬 achow101 commented on pull request "wallet: fix rescanning inconsistency":
(https://github.com/bitcoin/bitcoin/pull/31629#issuecomment-2660391333)
ACK 4818da809f0e300016390dd41e02c6067ffa008f

💬 achow101 commented on pull request "test: cover base[32|58|64] with symmetric roundtrip fuzz (and padding) tests":
(https://github.com/bitcoin/bitcoin/pull/30746#issuecomment-2660410374)
f919d919eb8425ef2bb25aa0ebf61c90ab9b07fa

✅ achow101 closed an issue: "Potential crash (assert) rescanning wallet"
(https://github.com/bitcoin/bitcoin/issues/31474)

🚀 achow101 merged a pull request: "wallet: fix rescanning inconsistency"
(https://github.com/bitcoin/bitcoin/pull/31629)

💬 achow101 commented on pull request "random: Initialize variables in hardware RNG functions":
(https://github.com/bitcoin/bitcoin/pull/31863#issuecomment-2660417019)
ACK 99755e04ffadd5daad53c686f4f0feee2232eeb2

🚀 achow101 merged a pull request: "test: cover base[32|58|64] with symmetric roundtrip fuzz (and padding) tests"
(https://github.com/bitcoin/bitcoin/pull/30746)