💬 mzumsande commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956737572)
the numbers don't add up for me: the tests creates 100 large orphans, sends 20, sends 1 small tx, then sends another 40 large orphans, and finally asserts that there are less than 101 entries in the orphanage. This would also be true without any eviction.

💬 achow101 commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#issuecomment-2660362190)
ACK 3c89cab06a6259fa70eaf3a78c01ee42780c4e27

⚠️ davidgumberg opened an issue: "guix: Unable to reproduce macOS SDK tarball on Fedora 40"
(https://github.com/bitcoin/bitcoin/issues/31873)
Following the instructions in [`contrib/macdeploy/README.md`](https://github.com/bitcoin/bitcoin/tree/master/contrib/macdeploy#readme) to generate the macOS SDK tarball that is used during GUIX builds on Fedora 40, I am not able to reproduce the hash in the readme for the generated tarball. I have reproduced this on two different Fedora 40 machines, and with a Fedora 40 docker image, but the issue does not appear when generating the tarball in an Ubuntu 24.04 docker image, or on a macOS Sequoia
...

💬 achow101 commented on pull request "doc: build: Fix instructions for msvc gui builds":
(https://github.com/bitcoin/bitcoin/pull/31851#issuecomment-2660364547)
ACK c3fa043ae560289759b6f836ac62736d97ba91bf

🚀 achow101 merged a pull request: "doc: build: Fix instructions for msvc gui builds"
(https://github.com/bitcoin/bitcoin/pull/31851)

💬 achow101 commented on pull request "build: move `rpc/external_signer` to node library":
(https://github.com/bitcoin/bitcoin/pull/31865#issuecomment-2660374335)
ACK e501246e77cc36cff222fb07aed2fd1316e11e19

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956785027)
Indeed, fixed.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956785498)
Done. I have actually added a bunch of functions (`IsAcceptable()`, `IsOptimal()`, `NeedsSplitting()`, and further on also `IsOversized()`) and mostly rewritten the long conditions involving `m_quality` to use these functions instead.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956785650)
I have expanded on this. LMK if it's clearer now.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956785706)
Done.

📝 hodlinator opened a pull request: "qa wallet: Activate dormant checks in wallet_multisig_descriptor_psbt.py"
(https://github.com/bitcoin/bitcoin/pull/31874)
Conditions had virtually no effect, lets activate them.

Also adds `assert_true()` which (unlike built-in `assert`) is kept in optimized Python executions, discussed in https://github.com/bitcoin/bitcoin/pull/30529#discussion_r1893029530

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1956786541)
I see this was a bit confusing, I have expanded the explanation.

But what I meant to convey was that (M) **in staging** means that if the transaction does not exist in main, it doesn't exist in staging either. A (P) in staging just means it exists there. LMK if the new explanation is clearer.

💬 hodlinator commented on pull request "Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior":
(https://github.com/bitcoin/bitcoin/pull/30529#discussion_r1956787128)
Was about to add built-in `assert` in a small fix in #31874, took the opportunity to tentatively add `assert_true()`.

🚀 achow101 merged a pull request: "build: move `rpc/external_signer` to node library"
(https://github.com/bitcoin/bitcoin/pull/31865)

🤔 furszy reviewed a pull request: "wallet: fix rescanning inconsistency"
(https://github.com/bitcoin/bitcoin/pull/31629#pullrequestreview-2618920102)
utACK 4818da809f0e300016390dd41e02c6067ffa008f

📝 l0rinc opened a pull request: "RFC: SortedWrite descending by hash"
(https://github.com/bitcoin/bitcoin/pull/31875)
This is an extension of [optimization: increase default LevelDB write batch size to 64 MiB](https://github.com/bitcoin/bitcoin/pull/31645) - draft for now to receive comments.

It looks like sorting the coins before flushing speeds up `MemTable` insertion considerably (will move the image to comments, after undrafting):

Ran a few `assumeUTXO` loads and a few complete reindexes to check the L
...

📝 l0rinc converted_to_draft a pull request: "RFC: SortedWrite descending by hash"
(https://github.com/bitcoin/bitcoin/pull/31875)
This is an extension of [optimization: increase default LevelDB write batch size to 64 MiB](https://github.com/bitcoin/bitcoin/pull/31645) - draft for now to receive comments.

It looks like sorting the coins before flushing speeds up `MemTable` insertion considerably (will move the image to comments, after undrafting):

Ran a few `assumeUTXO` loads and a few complete reindexes to check the L
...

💬 achow101 commented on pull request "wallet: fix rescanning inconsistency":
(https://github.com/bitcoin/bitcoin/pull/31629#issuecomment-2660391333)
ACK 4818da809f0e300016390dd41e02c6067ffa008f

💬 achow101 commented on pull request "test: cover base[32|58|64] with symmetric roundtrip fuzz (and padding) tests":
(https://github.com/bitcoin/bitcoin/pull/30746#issuecomment-2660410374)
f919d919eb8425ef2bb25aa0ebf61c90ab9b07fa

✅ achow101 closed an issue: "Potential crash (assert) rescanning wallet"
(https://github.com/bitcoin/bitcoin/issues/31474)