💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956622416)
I made it `DEFAULT_RESERVED_ORPHAN_WEIGHT_PER_PEER * 10`
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956622416)
I made it `DEFAULT_RESERVED_ORPHAN_WEIGHT_PER_PEER * 10`
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956622474)
done
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956622474)
done
🚀 achow101 merged a pull request: "test: Add test for rpcwhitelistdefault"
(https://github.com/bitcoin/bitcoin/pull/29858)
(https://github.com/bitcoin/bitcoin/pull/29858)
💬 achow101 commented on pull request "rpc: Remove deprecated dummy alias for listtransactions::label":
(https://github.com/bitcoin/bitcoin/pull/31413#issuecomment-2660121039)
ACK fa8e0956c23789fb819ad1b31377711df091ec1b
(https://github.com/bitcoin/bitcoin/pull/31413#issuecomment-2660121039)
ACK fa8e0956c23789fb819ad1b31377711df091ec1b
💬 l0rinc commented on pull request "Update CONTRIBUTING.md":
(https://github.com/bitcoin/bitcoin/pull/31872#issuecomment-2660122835)
@Syed-AbdurRahaman2006, please stop this random spam!
(https://github.com/bitcoin/bitcoin/pull/31872#issuecomment-2660122835)
@Syed-AbdurRahaman2006, please stop this random spam!
💬 luke-jr commented on pull request "random: Initialize variables in hardware RNG functions":
(https://github.com/bitcoin/bitcoin/pull/31863#issuecomment-2660155170)
> improve code clarity.
Initializing variables that do not need initializing is *worse* for code clarity.
If you want to silence buggy static analysis, I don't mind (~0), but it's not a code clarity fix...
(https://github.com/bitcoin/bitcoin/pull/31863#issuecomment-2660155170)
> improve code clarity.
Initializing variables that do not need initializing is *worse* for code clarity.
If you want to silence buggy static analysis, I don't mind (~0), but it's not a code clarity fix...
💬 tnndbtc commented on pull request "test: autogenerate bash completion":
(https://github.com/bitcoin/bitcoin/pull/30860#discussion_r1956655374)
Since there is a discussion (https://github.com/bitcoin/bitcoin/issues/17289#issuecomment-618736031) on whether it will slow down when user hit TAB key to send request to bitcoind for auto completion, what about we add those cword==1 commands in contrib/completions/bash/bitcoin-cli.bash so that it will not rely on the startup of bitcoind?
The suggested code is pasted below and tested:
# create cword==1 block to avoid the calling of bitcoind to get auto complete
commands =
...
(https://github.com/bitcoin/bitcoin/pull/30860#discussion_r1956655374)
Since there is a discussion (https://github.com/bitcoin/bitcoin/issues/17289#issuecomment-618736031) on whether it will slow down when user hit TAB key to send request to bitcoind for auto completion, what about we add those cword==1 commands in contrib/completions/bash/bitcoin-cli.bash so that it will not rely on the startup of bitcoind?
The suggested code is pasted below and tested:
# create cword==1 block to avoid the calling of bitcoind to get auto complete
commands =
...
💬 furszy commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956636482)
upps, yes. Thx.
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956636482)
upps, yes. Thx.
💬 furszy commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956619790)
> Trying to understand why the AbandonTransaction was overloaded.
Just to avoid the extra map lookup when we already have access to the wtx.
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956619790)
> Trying to understand why the AbandonTransaction was overloaded.
Just to avoid the extra map lookup when we already have access to the wtx.
💬 furszy commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956639524)
doesn't hurt to add it.
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956639524)
doesn't hurt to add it.
💬 furszy commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956655963)
"External wallets" are wallets that were created on a different node instance. You can either load them by path, using the dump/import functionality or just by moving them manually into the wallets/ directory.
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956655963)
"External wallets" are wallets that were created on a different node instance. You can either load them by path, using the dump/import functionality or just by moving them manually into the wallets/ directory.
💬 sipa commented on pull request "random: Initialize variables in hardware RNG functions":
(https://github.com/bitcoin/bitcoin/pull/31863#issuecomment-2660161679)
Eagerly awaiting C++26's explicit `[[indeterminate]]` [initialization](https://en.cppreference.com/w/cpp/language/attributes/indeterminate).
(https://github.com/bitcoin/bitcoin/pull/31863#issuecomment-2660161679)
Eagerly awaiting C++26's explicit `[[indeterminate]]` [initialization](https://en.cppreference.com/w/cpp/language/attributes/indeterminate).
💬 furszy commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956660785)
We haven't started following this pattern in the wallet sources yet. Might be better to do it all at once in a single PR and verify that nothing breaks (which should be the case because we don't use the witness id).
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956660785)
We haven't started following this pattern in the wallet sources yet. Might be better to do it all at once in a single PR and verify that nothing breaks (which should be the case because we don't use the witness id).
💬 furszy commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956668649)
> Is the following scenario handled by the usual handling or via this new one?
>
> > User has their node running and receive a coinbase transaction, and then the node is stopped. User restarts the node after a long time and meanwhile that transaction was invalidated (block invalidated), and at the time of loading the wallet the correct balance is shown.
This new one.
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956668649)
> Is the following scenario handled by the usual handling or via this new one?
>
> > User has their node running and receive a coinbase transaction, and then the node is stopped. User restarts the node after a long time and meanwhile that transaction was invalidated (block invalidated), and at the time of loading the wallet the correct balance is shown.
This new one.
💬 tnndbtc commented on issue "contrib: Autogenerate bash completion":
(https://github.com/bitcoin/bitcoin/issues/17289#issuecomment-2660181474)
One improvement to the slowness due to RPC on auto completion is to add those first level (cword==1) commands in contrib/completions/bash/bitcoin-cli.bash, then it will not rely on RPC to bitcoind. And, for any give release, run functional test with --overwrite to generate bitcoin-cli.bash then it should have a good coverage on supported commands.
I put more details in https://github.com/bitcoin/bitcoin/pull/30860/files#r1956655374 with sample code, which is validated in my mac Apple M1 chip.
...
(https://github.com/bitcoin/bitcoin/issues/17289#issuecomment-2660181474)
One improvement to the slowness due to RPC on auto completion is to add those first level (cword==1) commands in contrib/completions/bash/bitcoin-cli.bash, then it will not rely on RPC to bitcoind. And, for any give release, run functional test with --overwrite to generate bitcoin-cli.bash then it should have a good coverage on supported commands.
I put more details in https://github.com/bitcoin/bitcoin/pull/30860/files#r1956655374 with sample code, which is validated in my mac Apple M1 chip.
...
💬 fanquake commented on pull request "doc: Improve dependencies documentation":
(https://github.com/bitcoin/bitcoin/pull/31634#discussion_r1956673569)
What does this mean? I'm not sure it's correct.
(https://github.com/bitcoin/bitcoin/pull/31634#discussion_r1956673569)
What does this mean? I'm not sure it's correct.
💬 tnndbtc commented on pull request "test: autogenerate bash completion":
(https://github.com/bitcoin/bitcoin/pull/30860#issuecomment-2660193274)
I tested the code in mac(Apple M1 chip) and it worked fine. Steps are:
# run test and generate contrib/completions/bash/bitcoin-cli.bash:
% build/test/functional/test_runner.py test/functional/tool_cli_bash_completion.py --tmpdir /tmp --nocleanup --overwrite
# validate bash-completion on mac:
% brew info bash-completion
# switch to bash shell
% bash
# source the bash_completion script
% . /opt/homebrew/etc/profile.d/bash_completion.sh
# source bitcoin-cli bash
% source contrib
...
(https://github.com/bitcoin/bitcoin/pull/30860#issuecomment-2660193274)
I tested the code in mac(Apple M1 chip) and it worked fine. Steps are:
# run test and generate contrib/completions/bash/bitcoin-cli.bash:
% build/test/functional/test_runner.py test/functional/tool_cli_bash_completion.py --tmpdir /tmp --nocleanup --overwrite
# validate bash-completion on mac:
% brew info bash-completion
# switch to bash shell
% bash
# source the bash_completion script
% . /opt/homebrew/etc/profile.d/bash_completion.sh
# source bitcoin-cli bash
% source contrib
...
💬 davidgumberg commented on pull request "build: Make config warnings fatal if -DWCONFIGURE_ERROR=ON":
(https://github.com/bitcoin/bitcoin/pull/31665#issuecomment-2660211682)
Rebased to fix merge conflict.
(https://github.com/bitcoin/bitcoin/pull/31665#issuecomment-2660211682)
Rebased to fix merge conflict.
💬 davidgumberg commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1956687815)
It's also fair if you just think #31665 is a bad approach and this is more evidence of that.
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1956687815)
It's also fair if you just think #31665 is a bad approach and this is more evidence of that.
💬 l0rinc commented on pull request "optimization: speed up block serialization":
(https://github.com/bitcoin/bitcoin/pull/31868#discussion_r1956688357)
Absolutely, I already have other optimization ideas in mind after that's merged.
The reviewers can decide the preferred merge order, I don't mind rebasing or doing it in multiple PRs - there's a lot of work left with serialization anyway.
(https://github.com/bitcoin/bitcoin/pull/31868#discussion_r1956688357)
Absolutely, I already have other optimization ideas in mind after that's merged.
The reviewers can decide the preferred merge order, I don't mind rebasing or doing it in multiple PRs - there's a lot of work left with serialization anyway.