💬 achow101 commented on pull request "doc: Improve dependencies documentation":
(https://github.com/bitcoin/bitcoin/pull/31634#issuecomment-2660049612)
ACK a759ea3e920dcba52798755ba9f3891f914afbb0

🚀 achow101 merged a pull request: "net: reduce CAddress usage to CService or CNetAddr"
(https://github.com/bitcoin/bitcoin/pull/31854)

💬 jonatack commented on pull request "net: reduce CAddress usage to CService or CNetAddr":
(https://github.com/bitcoin/bitcoin/pull/31854#issuecomment-2660058465)
Post-merge approach ACK. Good idea.

🚀 achow101 merged a pull request: "doc: Improve dependencies documentation"
(https://github.com/bitcoin/bitcoin/pull/31634)

💬 instagibbs commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956602557)
Let's set the upper range to DEFAULT_MAX_ORPHAN_ANNOUNCEMENTS?

💬 instagibbs commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956603725)
set the upper range to DEFAULT_ANCESTOR_SIZE_LIMIT_KVB * 4000? See no reason to not cover the full range (we could also increase the num_outs range to make larger ranges hit based on a bool?

📝 Syed-AbdurRahaman2006 opened a pull request: "Update CONTRIBUTING.md"
(https://github.com/bitcoin/bitcoin/pull/31872)
in line number 11 i changed the sentence because it is overstructured sentence in normal content from this line to "Open source often naturally revolves around a meritocracy where contributors earn trust from the developer community over time." to this "In open source projects, contributors gradually earn trust from the developer community, forming a natural meritocracy."

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear imp
...

✅ achow101 closed a pull request: "Update CONTRIBUTING.md"
(https://github.com/bitcoin/bitcoin/pull/31872)

💬 jonatack commented on pull request "Update CONTRIBUTING.md":
(https://github.com/bitcoin/bitcoin/pull/31872#discussion_r1956610196)
NACK. Not worth the change, and the patch is missing a space here.

💬 achow101 commented on pull request "test: Add test for rpcwhitelistdefault":
(https://github.com/bitcoin/bitcoin/pull/29858#issuecomment-2660095729)
ACK f0e5e4cdbec4df190c952d5a61d7a882a7e3b59e

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956621497)
done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956622416)
I made it `DEFAULT_RESERVED_ORPHAN_WEIGHT_PER_PEER * 10`

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956622474)
done

🚀 achow101 merged a pull request: "test: Add test for rpcwhitelistdefault"
(https://github.com/bitcoin/bitcoin/pull/29858)

💬 achow101 commented on pull request "rpc: Remove deprecated dummy alias for listtransactions::label":
(https://github.com/bitcoin/bitcoin/pull/31413#issuecomment-2660121039)
ACK fa8e0956c23789fb819ad1b31377711df091ec1b

💬 l0rinc commented on pull request "Update CONTRIBUTING.md":
(https://github.com/bitcoin/bitcoin/pull/31872#issuecomment-2660122835)
@Syed-AbdurRahaman2006, please stop this random spam!

💬 luke-jr commented on pull request "random: Initialize variables in hardware RNG functions":
(https://github.com/bitcoin/bitcoin/pull/31863#issuecomment-2660155170)
> improve code clarity.

Initializing variables that do not need initializing is *worse* for code clarity.

If you want to silence buggy static analysis, I don't mind (~0), but it's not a code clarity fix...

💬 tnndbtc commented on pull request "test: autogenerate bash completion":
(https://github.com/bitcoin/bitcoin/pull/30860#discussion_r1956655374)
Since there is a discussion (https://github.com/bitcoin/bitcoin/issues/17289#issuecomment-618736031) on whether it will slow down when user hit TAB key to send request to bitcoind for auto completion, what about we add those cword==1 commands in contrib/completions/bash/bitcoin-cli.bash so that it will not rely on the startup of bitcoind?

The suggested code is pasted below and tested:

# create cword==1 block to avoid the calling of bitcoind to get auto complete
commands =
...

💬 furszy commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956636482)
upps, yes. Thx.

💬 furszy commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1956619790)
> Trying to understand why the AbandonTransaction was overloaded.

Just to avoid the extra map lookup when we already have access to the wtx.