💬 ajtowns commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#discussion_r1188287489)
Doesn't this just change the fingerprinting vector from `GETDATA txid` to `FILTERCLEAR; FILTERADD whatever; MEMPOOL` ? In which case we're just as easily fingerprinted, but we spend more cpu while being fingerprinted?

💬 Sjors commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1539677521)
The above command on my listening node (running a mess of commits on top of master from ~March) returns localhost (probably my mempool instance) plus about 11 other peers. CPU use looks normal to me, it's not compiled with --enable-debug nor does it run with -debug. Last restart was 3 days ago.

💬 MarcoFalke commented on issue "GCC 13: `-Wdangling-reference` output":
(https://github.com/bitcoin/bitcoin/issues/26926#issuecomment-1539683573)
See https://github.com/bitcoin/bitcoin/pull/27605 for a code change. An alternative might be to locally or globally disable the warning.

For testing, one can use a fresh install of Fedora 38:

```
dnf install gcc-c++ libtool make autoconf automake python3 clang llvm lbzip2 patch xz cmake curl wget htop git vim ccache libevent-devel boost-devel qt5-qttools-devel qt5-qtbase-devel -y && git clone https://github.com/bitcoin/bitcoin.git ./bitcoin-core && cd bitcoin-core && ./autogen.
...

👍 hebasto approved a pull request: "add ryanofsky to trusted-keys"
(https://github.com/bitcoin/bitcoin/pull/27604#pullrequestreview-1418209420)
ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

My local gpg output:
```
$ gpg --list-keys 4D1B3D5ECBA1A7E05371EEBE46800E30FC748A66
pub rsa4096 2022-01-07 [SC] [expires: 2024-01-07]
4D1B3D5ECBA1A7E05371EEBE46800E30FC748A66
uid [ unknown] Ryan Ofsky <ryan@ofsky.org>
sub rsa4096 2022-01-07 [E] [expires: 2024-01-07]

```

💬 ArmchairCryptologist commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1539774342)
Just to confirm, after a day or so I'm seeing the same kind of CPU load increasing over time with the node I downgraded to 23.0.0, so this other issue probably was not introduced with 24.0.1.

Reducing maxconnections to a low-ish number (100 or less) seems to at least significantly delay the problem, though I can't say yet whether it'll mitigate it entirely.

> I didn't restart the node, but used the setban approach as pointed out here https://github.com/bitcoin/bitcoin/issues/27586#issuecom
...

⚠️ ETCorps opened an issue: "ihsota ottomakan"
(https://github.com/bitcoin/bitcoin/issues/27606)
### Motivation

```

> 3D33H333A3C33M333-3@33#333O3r33p333h3e33u333s3a33n333g3e33l333s3
> AutomaticRegenerativeHex:Binary hash:For protection of account info 3@3(*?)3#33{*?#/!}(*?)3O3r3(*?)3p3{*?#/!}3(*?)3h3e3(*?)3{*?#/!}u33(*?)3s3a3{*?#/!}(*?)3n33(*?)3g3{*?#/!}e3(*?)3l33(*?)3{*?#/!}s3
>
> (*?)=randomly generated alpha numerical value based on the roll of a six sided dice begining with 1 dice then two then three then for then five and on the sixth roll it will be no dice then the process
...

✅ willcl-ark closed an issue: "ihsota ottomakan"
(https://github.com/bitcoin/bitcoin/issues/27606)

💬 Sjors commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1539795569)
When I do `make` followed by `make deploy` on e82e73103ce81159f6f1a51408ce5411b88a12b2 on macOS 13.3.1 I end up with three files / folders:
1. Bitcoin-Qt.app (which Finder displays as "Bitcoin Core")
2. Bitcoin-Core.zip
3. dist/Bitcoin-Qt.app

It seems like only the zip file needs to be there?

💬 fanquake commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#issuecomment-1539811958)
Concept ACK

:lock: fanquake locked an issue: "ihsota ottomakan"
(https://github.com/bitcoin/bitcoin/issues/27606)

💬 hebasto commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#issuecomment-1539824898)
Concept ACK.

💬 GregTonoski commented on issue "Bitcoin Core startup is interrupted if there is the setting mintxfee=0 in bitcoin.conf":
(https://github.com/bitcoin/bitcoin/issues/26797#issuecomment-1539850711)
I confirm that the bug is fixed 25.0rc1 (I have verified on the https://bitcoincore.org/bin/bitcoin-core-25.0/test.rc1/bitcoin-25.0rc1-win64.zip).

💬 TheCharlatan commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1188449666)
That works :)

💬 TheCharlatan commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#issuecomment-1539887649)
Updated 43dec8806f679005d4484b229f433687526c9133 -> 1ae4d9a37b46a5e69ed79066408a6002c2cc0f73 ([kernelChainType_5](https://github.com/TheCharlatan/bitcoin/tree/kernelChainType_5) -> [kernelChainType_6](https://github.com/TheCharlatan/bitcoin/tree/kernelChainType_6), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelChainType_5..kernelChainType_6))

* Addressed @MarcoFalke's [comment](https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1188242770), changed throwing an excepti
...

👍 hebasto approved a pull request: "refactor: Replace global find_value function with UniValue::find_value method"
(https://github.com/bitcoin/bitcoin/pull/27605#pullrequestreview-1418388106)
ACK fa0d180f48d4e5253f58aced32768369f963d1c7, tested on Ubuntu 23.04 using GCC 13.0.1.

💬 MarcoFalke commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#issuecomment-1539948491)
> Ubuntu 23.04 using GCC 13.0.1

I think it ships with 12.2? https://packages.ubuntu.com/lunar/gcc

👍 stickies-v approved a pull request: "refactor: Replace global find_value function with UniValue::find_value method"
(https://github.com/bitcoin/bitcoin/pull/27605#pullrequestreview-1418401022)
ACK fa0d180f48d4e5253f58aced32768369f963d1c7

I can't see any behaviour change, and as far as I can tell using references in fa0d180f48d4e5253f58aced32768369f963d1c7 doesn't introduce any (potential) lifetime issues.

💬 stickies-v commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1188470576)
I think this should be `LIFETIMEBOUND`?

💬 MarcoFalke commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1188513782)
Maybe in a follow-up for the whole univalue interface?

💬 willcl-ark commented on pull request "refactor: Remove unused GetTimeMillis":
(https://github.com/bitcoin/bitcoin/pull/27594#issuecomment-1539994241)
tACK fae1d9cded

Also removes `GetSystemTime` which because unused after faf3f12424.

Curious if you have any plans for `GetTime()` (marked deprecated since [16046](https://github.com/bitcoin/bitcoin/pull/16046))?