💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956103968)
Hold on, I don't see why it'd throw an assertion? `ancestor_package[-1]` is the last child right? Added some more comments but didn't change the code

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956104380)
Added a commit before that one, just adding the list and sanity checking

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956104543)
good point, added a comment

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956105056)
nice, thanks - added a `setmocktime()` after all the restarts

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956106767)
Thanks! Added. It does take a long time but that's the only way to get evictions due to announcements in a functional test.

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956106958)
Added thanks!

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956109943)
Thanks! Fixed

👍 stickies-v approved a pull request: "cmake: add a component for each binary"
(https://github.com/bitcoin/bitcoin/pull/31844#pullrequestreview-2617756135)
re-ACK 9b033bebb18dfd609c02736292f37cc6589fcc8d

✅ fanquake closed an issue: "build: cmake installs empty manpages for non-configured targets"
(https://github.com/bitcoin/bitcoin/issues/31762)

✅ fanquake closed an issue: "build: `cmake --install` fails if only select targets are built"
(https://github.com/bitcoin/bitcoin/issues/31745)

🚀 fanquake merged a pull request: "cmake: add a component for each binary"
(https://github.com/bitcoin/bitcoin/pull/31844)

💬 s373nZ commented on pull request "cmake: add a component for each binary":
(https://github.com/bitcoin/bitcoin/pull/31844#issuecomment-2659328035)
re-ACK https://github.com/bitcoin/bitcoin/commit/9b033bebb18dfd609c02736292f37cc6589fcc8d

Consider the prefix name feedback a nit.

💬 hebasto commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2659333795)
> Uploading the macOS binaries here, so I can test the download flow (which in the past behaved different from the scp flow):
>
> * [bitcoin-096525e92cc2-arm64-apple-darwin.zip](https://github.com/user-attachments/files/18781660/bitcoin-096525e92cc2-arm64-apple-darwin.zip)
> * [bitcoin-096525e92cc2-x86_64-apple-darwin.zip](https://github.com/user-attachments/files/18781669/bitcoin-096525e92cc2-x86_64-apple-darwin.zip)

Tested on macOS 15.3 (Intel):
```
% shasum -a 256 bitcoin-096525e92cc
...

💬 fanquake commented on pull request "depends: add missing Darwin objcopy":
(https://github.com/bitcoin/bitcoin/pull/31840#issuecomment-2659376971)
> If it's not too much trouble, could you recall which distros those were?

It's still the case with Ubuntu, i.e 24.04:
```bash
# apt install llvm
# ls /usr/bin/llvm-* | grep objdump
/usr/bin/llvm-objdump
/usr/bin/llvm-objdump-18
# ls /usr/bin/llvm-* | grep install-name
/usr/bin/llvm-install-name-tool-18
```

💬 maflcko commented on issue "Gracefully handle dropped UPnP support ":
(https://github.com/bitcoin-core/gui/issues/843#issuecomment-2659392932)
Looks like this is still up for grabs, waiting on a pull request for 29.x.



> > Can't they just unset it in the UI settings?
>
> No, because the checkbox for upnp no longer exists.

Also not with a previous release as a workaround?

💬 maflcko commented on pull request "consensus: Remove checkpoints (take 2)":
(https://github.com/bitcoin/bitcoin/pull/31649#issuecomment-2659397191)
review ACK 301017c6217378ca868e17c7cb8ffe3447abb11d 🎸

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 301017c62173
...

💬 Sjors commented on pull request "cmake: Improve compatibility with Python version managers":
(https://github.com/bitcoin/bitcoin/pull/31421#issuecomment-2659427920)
I had `export PATH=/opt/homebrew/bin/:$PATH` in my `~/.zshrc` probably to use gnu versions of various tools. But that's not the right way.

Once I removed that, and restore `brew link python3`, the path is as follows:

```
which -a python3
/Users/sjors/.pyenv/shims/python3
/opt/homebrew/bin/python3
/usr/bin/python3
```

And cmake finds 3.10.14.

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956203848)
Hm, one of the CI failures is a timeout for this (the other is a wallet thing). Perhaps it takes a bit too long?
We could also change these to batches of 200 * 10 + 101 * 10 and just do the `wait_until` once to make the test faster. Or, we use `-maxorphantxs` to reduce the limit.

💬 Sjors commented on issue "Gracefully handle dropped UPnP support ":
(https://github.com/bitcoin-core/gui/issues/843#issuecomment-2659432408)
I suspect "unset" will store upnp=0 in the settings which would still be an error.

💬 instagibbs commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1956206594)
Too bad :(

Try the smaller batches and see how we do? Lowering maxorphantxs is better than no test at all but clearly not optimal.