💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656675260)
Yes, I can help you with that.
Through Bitcoin Core interface: *File → Create Wallet → Set Name →
Encrypt Wallet* – \ \ \ \ \ \ \ \ \ \ \ \ That's all.
On Thu, 13 Feb 2025 at 16:50, Pieter Wuille ***@***.***>
wrote:
> @InnDe <https://github.com/InnDe> We don't know how you created the
> wallet, and set its password in the first place, making it impossible to
> reproduce.
>
> Can you give the full and exact reproduction steps, from scratch, from
> starting bitcoin-qt, to creating
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656675260)
Yes, I can help you with that.
Through Bitcoin Core interface: *File → Create Wallet → Set Name →
Encrypt Wallet* – \ \ \ \ \ \ \ \ \ \ \ \ That's all.
On Thu, 13 Feb 2025 at 16:50, Pieter Wuille ***@***.***>
wrote:
> @InnDe <https://github.com/InnDe> We don't know how you created the
> wallet, and set its password in the first place, making it impossible to
> reproduce.
>
> Can you give the full and exact reproduction steps, from scratch, from
> starting bitcoin-qt, to creating
...
📝 tianzedavid opened a pull request: "chore: remove redundant word"
(https://github.com/bitcoin/bitcoin/pull/31858)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/31858)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
💬 tianzedavid commented on pull request "chore: remove redundant word":
(https://github.com/bitcoin/bitcoin/pull/31855#issuecomment-2656717008)
> similar instance on line 94 now that i see it
>
> https://github.com/bitcoin/bitcoin/pull/31855/files#diff-91d294c18d2f63ceb1c9aadff3b3ae046b252b763d69b13f930f7de7b399f440R94
Thanks for pointing out. The new pr https://github.com/bitcoin/bitcoin/pull/31858
(https://github.com/bitcoin/bitcoin/pull/31855#issuecomment-2656717008)
> similar instance on line 94 now that i see it
>
> https://github.com/bitcoin/bitcoin/pull/31855/files#diff-91d294c18d2f63ceb1c9aadff3b3ae046b252b763d69b13f930f7de7b399f440R94
Thanks for pointing out. The new pr https://github.com/bitcoin/bitcoin/pull/31858
💬 ryanofsky commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954473077)
In commit "rpc: introduce RPC_SHUTDOWN_ERROR" (e6760e7f0f04c076c3eb8fa61cb54adf12fed36b)
Out of curiosity, where did 37 come from?
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954473077)
In commit "rpc: introduce RPC_SHUTDOWN_ERROR" (e6760e7f0f04c076c3eb8fa61cb54adf12fed36b)
Out of curiosity, where did 37 come from?
💬 ryanofsky commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954576364)
In commit "rpc: handle shutdown during long poll and wait methods" (fa99eddd926e0d49604d9ca8f21fac85d63652f4)
I think this new behavior of only using `timeout` as time limit for tip changing, not as a time limit for the tip to be set on startup makes a lot of sense and should be much more convenient for callers than previous behavior.
(Previous version in ad3af401c19b8d05ce69011a359db3090b7018e1 would return ambiguous null values on startup that could mean either the node was shutting down
...
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954576364)
In commit "rpc: handle shutdown during long poll and wait methods" (fa99eddd926e0d49604d9ca8f21fac85d63652f4)
I think this new behavior of only using `timeout` as time limit for tip changing, not as a time limit for the tip to be set on startup makes a lot of sense and should be much more convenient for callers than previous behavior.
(Previous version in ad3af401c19b8d05ce69011a359db3090b7018e1 would return ambiguous null values on startup that could mean either the node was shutting down
...
💬 josibake commented on pull request "Benchmark Chainstate::ConnectBlock duration":
(https://github.com/bitcoin/bitcoin/pull/31689#issuecomment-2656722488)
reACK https://github.com/bitcoin/bitcoin/commit/7edaf8b64cb2d59ada22042fee62a417e52368b8
(https://github.com/bitcoin/bitcoin/pull/31689#issuecomment-2656722488)
reACK https://github.com/bitcoin/bitcoin/commit/7edaf8b64cb2d59ada22042fee62a417e52368b8
💬 maflcko commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656739550)
I can't reproduce. Though, I am on Linux.
Does it also happen when you copy-paste the exact same password into both places? Does it happen when you use the on-screen software keyboard instead of the hardware one?
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656739550)
I can't reproduce. Though, I am on Linux.
Does it also happen when you copy-paste the exact same password into both places? Does it happen when you use the on-screen software keyboard instead of the hardware one?
💬 willcl-ark commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656741857)
If we are going to be able to reproduce it, the instructions will need to be reproducible by someone. I can't reproduce yours currently. My recommendation would be to, whilst using a computer, write out the instructions in a codeblock as @maflcko suggested. They should look something like this at the end:
\`\`\`bash
```bash
# Start bitcoind
bitcoind
# Create new wallet
bitcoin-cli createwallet test-wallet false false " \ \ \ \ \ \ \ \"
# reload wallet
bitcoin-cli unload wallet "test-wallet"
b
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656741857)
If we are going to be able to reproduce it, the instructions will need to be reproducible by someone. I can't reproduce yours currently. My recommendation would be to, whilst using a computer, write out the instructions in a codeblock as @maflcko suggested. They should look something like this at the end:
\`\`\`bash
```bash
# Start bitcoind
bitcoind
# Create new wallet
bitcoin-cli createwallet test-wallet false false " \ \ \ \ \ \ \ \"
# reload wallet
bitcoin-cli unload wallet "test-wallet"
b
...
💬 sipa commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656746360)
Is it possible that you have more than one wallet loaded? If so, you should see a drop-down list at the top left in the debug console window.
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656746360)
Is it possible that you have more than one wallet loaded? If so, you should see a drop-down list at the top left in the debug console window.
💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656748026)
I'm using my Acer Predator laptop keyboard. It doesn’t matter whether I
type the passphrase or paste it—the result is always the same.
On Thu, 13 Feb 2025 at 17:19, maflcko ***@***.***> wrote:
> I can't reproduce. Though, I am on Linux.
>
> Does it also happen when you copy-paste the exact same password into both
> places? Does it happen when you use the on-screen software keyboard instead
> of the hardware one?
>
> —
> Reply to this email directly, view it on GitHub
> <https://
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656748026)
I'm using my Acer Predator laptop keyboard. It doesn’t matter whether I
type the passphrase or paste it—the result is always the same.
On Thu, 13 Feb 2025 at 17:19, maflcko ***@***.***> wrote:
> I can't reproduce. Though, I am on Linux.
>
> Does it also happen when you copy-paste the exact same password into both
> places? Does it happen when you use the on-screen software keyboard instead
> of the hardware one?
>
> —
> Reply to this email directly, view it on GitHub
> <https://
...
💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656752290)
sorry but I really don't understand what you want me to do
On Thu, 13 Feb 2025 at 17:21, Amer Emad ***@***.***> wrote:
> I'm using my Acer Predator laptop keyboard. It doesn’t matter whether I
> type the passphrase or paste it—the result is always the same.
>
> On Thu, 13 Feb 2025 at 17:19, maflcko ***@***.***> wrote:
>
>> I can't reproduce. Though, I am on Linux.
>>
>> Does it also happen when you copy-paste the exact same password into both
>> places? Does it happen when you us
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656752290)
sorry but I really don't understand what you want me to do
On Thu, 13 Feb 2025 at 17:21, Amer Emad ***@***.***> wrote:
> I'm using my Acer Predator laptop keyboard. It doesn’t matter whether I
> type the passphrase or paste it—the result is always the same.
>
> On Thu, 13 Feb 2025 at 17:19, maflcko ***@***.***> wrote:
>
>> I can't reproduce. Though, I am on Linux.
>>
>> Does it also happen when you copy-paste the exact same password into both
>> places? Does it happen when you us
...
💬 maflcko commented on pull request "chore: remove redundant word":
(https://github.com/bitcoin/bitcoin/pull/31858#issuecomment-2656752950)
lgtm ACK 4c62b37fcd23e94ea482efc5974acc2560f57f5f
(https://github.com/bitcoin/bitcoin/pull/31858#issuecomment-2656752950)
lgtm ACK 4c62b37fcd23e94ea482efc5974acc2560f57f5f
💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656757505)
Yes, sir, I have more than one, but I choose in the CLI from the top
right corner which one to execute commands in.
On Thu, 13 Feb 2025 at 17:21, Pieter Wuille ***@***.***>
wrote:
> Is it possible that you have more than one wallet loaded? If so, you
> should see a drop-down list at the top left in the debug console window.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656746360>,
> or unsubscribe
> <http
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656757505)
Yes, sir, I have more than one, but I choose in the CLI from the top
right corner which one to execute commands in.
On Thu, 13 Feb 2025 at 17:21, Pieter Wuille ***@***.***>
wrote:
> Is it possible that you have more than one wallet loaded? If so, you
> should see a drop-down list at the top left in the debug console window.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656746360>,
> or unsubscribe
> <http
...
💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954607452)
My takeaway from the article is that having a default for the base class is fine, and that it's better to not use a default for the inherited classes (but it could get ignored).
The patch in my previous comment would be bad. But the current code that calls `waitTipChanged(uint256::ZERO, MillisecondsDouble::max())` should be fine.
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954607452)
My takeaway from the article is that having a default for the base class is fine, and that it's better to not use a default for the inherited classes (but it could get ignored).
The patch in my previous comment would be bad. But the current code that calls `waitTipChanged(uint256::ZERO, MillisecondsDouble::max())` should be fine.
💬 sipa commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656770266)
Ok, well, if the password you set when creating the wallet in the GUI is `\ \ \ \ \ \ \ \ \ \ \ \`, then the command in the debug console should be `walletpassphrase '\ \ \ \ \ \ \ \ \ \ \ \' 800`, or `walletpassphrase "\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\" 800`, because of backslash quoting.
But I cannot explain why you're not seeing any output at all. The response to the `walletpassphrase` command, you should get either `(null)` as output when the password is correct, or `Error: The wallet pas
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656770266)
Ok, well, if the password you set when creating the wallet in the GUI is `\ \ \ \ \ \ \ \ \ \ \ \`, then the command in the debug console should be `walletpassphrase '\ \ \ \ \ \ \ \ \ \ \ \' 800`, or `walletpassphrase "\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\" 800`, because of backslash quoting.
But I cannot explain why you're not seeing any output at all. The response to the `walletpassphrase` command, you should get either `(null)` as output when the password is correct, or `Error: The wallet pas
...
💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954608225)
First available number.
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954608225)
First available number.
🤔 delta1 reviewed a pull request: "chore: remove redundant word"
(https://github.com/bitcoin/bitcoin/pull/31858#pullrequestreview-2615179552)
ACK https://github.com/bitcoin/bitcoin/commit/4c62b37fcd23e94ea482efc5974acc2560f57f5f
(https://github.com/bitcoin/bitcoin/pull/31858#pullrequestreview-2615179552)
ACK https://github.com/bitcoin/bitcoin/commit/4c62b37fcd23e94ea482efc5974acc2560f57f5f
🚀 fanquake merged a pull request: "chore: remove redundant word"
(https://github.com/bitcoin/bitcoin/pull/31858)
(https://github.com/bitcoin/bitcoin/pull/31858)
💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954615547)
See https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954576364
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954615547)
See https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954576364
💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954626155)
Thanks, that indeed looks simpler.
I also think clients should handle timeouts themselves. For `bitcoin-cli` we have `-rpcclienttimeout=0`, other RPC clients presumably have their own timeout mechanisms, and IPC clients can do the same.
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954626155)
Thanks, that indeed looks simpler.
I also think clients should handle timeouts themselves. For `bitcoin-cli` we have `-rpcclienttimeout=0`, other RPC clients presumably have their own timeout mechanisms, and IPC clients can do the same.