Bitcoin Core Github
44 subscribers
121K links
Download Telegram
💬 pinheadmz commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2654987498)
I think stack exchange is the best place for this usage question but you need to be a bit more cool to people who are trying to help you there. The issue tracker here is only for technical issues with the software. If you actually discover one of those (maybe like, walletpassphrase doesn't work if passphrase contains a backslash?) please open an issue for that.

You can update this issue if you can rephrase it according to our guidelines otherwise it's likely to be closed as won't-fix
💬 achow101 commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2654987869)
Does your passphrase has quotes (`"` or `'`) in it? If so, you will need to escape them when using the RPC console. If your password also has the space character, then entire passphrase will need to be surrounded with quotes so that the space is recognized as part of the passphrase.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953498553)
It's something that really only has meaning after staging support is added. I have dropped it here, expanded the comment a bit, and expanded on it a lot more in the staging commit.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953498653)
Done.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953499000)
I have rewritten this.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953499878)
I have added an Assume, but not the break. It just shouldn't happen, and this is tested extensively in fuzzing (where the Assumes actually have teeth).
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500039)
Done.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500309)
Indeed. Expanded/corrected the comment.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500407)
Done.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500490)
Done.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500634)
Added a comment to this effect.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500945)
This comment was no longer relevant, it dates from an earlier iteration. Gone.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501047)
Done.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501119)
Gone.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501453)
When the same Ref is `RemoveTransaction()`ed twice. Added a comment to clarify.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501564)
Done.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501757)
Fixed.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501842)
Done.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953502322)
I've added a comment to `AddTransaction` to clarify one can only pass Refs from a given txgraph object to functions of the same object.
💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953502492)
Fixed.