💬 fanquake commented on pull request "ci: switch MSAN to use prebuilt Clang binaries":
(https://github.com/bitcoin/bitcoin/pull/31850#discussion_r1953473331)
https://github.com/llvm/llvm-project/releases/tag/llvmorg-20.1.0-rc2

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953481542)
Indeed.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953484318)
It's a tiny number, as it's bounded by $\mathcal{O}(\log n)$, so it didn't feel right to use the same `DepGraphIndex` or `GraphIndex` type.

⚠️ InnDe opened an issue: "Wallet passpharse"
(https://github.com/bitcoin/bitcoin/issues/31852)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour


I’m using a passphrase for my encrypted wallets—8 in total.

This passphrase is: (space “thekey” \ \ \ \ \ \ \ \ \ \ \ \ \)
“ \ \ \ \ \ \ \ \ \ \ \ \ \)”

I use this passphrase for all my wallets (total: 2.4 BTC), but now it doesn’t work as usual. I tried creating a new wallet with the same passphrase, and I encountered the same issue.

You can review my question and all the comments her
...

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953494478)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953494661)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953495202)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953495306)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953495533)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953496332)
I've reworded this a bit.

💬 pinheadmz commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2654987498)
I think stack exchange is the best place for this usage question but you need to be a bit more cool to people who are trying to help you there. The issue tracker here is only for technical issues with the software. If you actually discover one of those (maybe like, walletpassphrase doesn't work if passphrase contains a backslash?) please open an issue for that.

You can update this issue if you can rephrase it according to our guidelines otherwise it's likely to be closed as won't-fix

💬 achow101 commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2654987869)
Does your passphrase has quotes (`"` or `'`) in it? If so, you will need to escape them when using the RPC console. If your password also has the space character, then entire passphrase will need to be surrounded with quotes so that the space is recognized as part of the passphrase.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953498553)
It's something that really only has meaning after staging support is added. I have dropped it here, expanded the comment a bit, and expanded on it a lot more in the staging commit.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953498653)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953499000)
I have rewritten this.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953499878)
I have added an Assume, but not the break. It just shouldn't happen, and this is tested extensively in fuzzing (where the Assumes actually have teeth).

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500039)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500309)
Indeed. Expanded/corrected the comment.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500407)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500490)
Done.