💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#issuecomment-2652236274)
> My understanding is that m_total_orphan_usage exists to limit memory usage, and m_total_announcements to limit CPU usage - but why the number of announcements instead of number of orphans?

Yep, to limit CPU usage. The complexity of eviction for example is bounded by the total number of announcements: in the worst case, each orphan has many announcers and the `MaybeTrimOrphans` loop first removes announcements until each orphan just has 1 left, and then finally can remove transactions. See c
...

🤔 mzumsande reviewed a pull request: "validation: set BLOCK_FAILED_CHILD correctly"
(https://github.com/bitcoin/bitcoin/pull/31835#pullrequestreview-2610319771)
Concept ACK

This is a straightforward bugfix.

In general, I'm in favor of removing the `BLOCK_FAILED_CHILD` / `BLOCK_FAILED_VALID` distinction as a follow-up, as suggested in https://github.com/bitcoin/bitcoin/pull/16856#issuecomment-565506585. It's been introduced in 2012 (#1677) and (as far as I know) has never been used for anything. I also can't think of a legitimate use - block indexes that are marked as invalid are invalid indefinitely (outside of the `reconsiderblock` rpc, but that
...

💬 yancyribbens commented on issue "wallet: Branch and Bound producing change":
(https://github.com/bitcoin/bitcoin/issues/31830#issuecomment-2652350051)
I tracked down the PR that add this: https://github.com/bitcoin/bitcoin/pull/27585 and commit https://github.com/bitcoin/bitcoin/pull/27585/commits/6d9b26d56ab5295dfcfe0f80a3069046a263fb2f. I'm a little confused by this since this is counter to what I would expect. BnB seeks to find a changelss solution, however only if the change created is less than the cost of creating a new output. That is, if it's more expansive to add the change leftover to a new output, don't bother.

👋 achow101's pull request is ready for review: "psbt: MuSig2 Fields"
(https://github.com/bitcoin/bitcoin/pull/31247)

💬 achow101 commented on pull request "psbt: MuSig2 Fields":
(https://github.com/bitcoin/bitcoin/pull/31247#issuecomment-2652378647)
Updated with the test vectors from https://github.com/bitcoin/bips/pull/1764

💬 achow101 commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#discussion_r1951831500)
If I need to retouch

💬 achow101 commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#discussion_r1951831539)
If I need to retouch

💬 achow101 commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2652428792)
Windows code signature:
[signature-win.tar.gz](https://github.com/user-attachments/files/18760608/signature-win.tar.gz)

It looks like I have a mismatch.

```
$ find guix-build-46e44a35b858/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
c92e7d0b4d0d1f929bfe8d61e15a953738725d530fc64eb936634571c17936b7 guix-build-46e44a35b858/output/aarch64-linux-gnu/SHA256SUMS.part
ad3992a66f9de8039cabbc9f222f7369f8002fc5350a01b03a3194d574100770 guix-build-46e44a35b858/output/aarch
...

📝 luke-jr opened a pull request: "Add -pruneduringinit option to temporarily use another prune target during IBD"
(https://github.com/bitcoin/bitcoin/pull/31845)
Low prune sizes can force flushing long before dbcache is full, making a significant impact on real-world IBD time.

This new option allows a higher (or lower) prune size during IBD to mitigate this. When assumeutxo is active, the entire additional budget is allocated to the background chainstate.

💬 achow101 commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#discussion_r1951862122)
Done

💬 achow101 commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#discussion_r1951862158)
Done

💬 achow101 commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2652459686)
I believe I identified the non-determinism, pushed a fix for that.

💬 andrewtoth commented on pull request "Add -pruneduringinit option to temporarily use another prune target during IBD":
(https://github.com/bitcoin/bitcoin/pull/31845#issuecomment-2652484368)
After #28280 how significant is the impact of this?

💬 luke-jr commented on pull request "Add -pruneduringinit option to temporarily use another prune target during IBD":
(https://github.com/bitcoin/bitcoin/pull/31845#issuecomment-2652488514)
>After #28280 and #30039 how significant is the impact of this?

I don't know, but logically I would expect this to still improve things significantly.

💬 achow101 commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2652507129)
Windows code signature for 096525e92cc2f5a4318bae13cedd2cf36b928d5f:
[signature-win.tar.gz](https://github.com/user-attachments/files/18761067/signature-win.tar.gz)

# Non-Codesigned guix hashes
```
$ find guix-build-096525e92cc2/output -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
bff1786e0fe30ac2c70eb8abd39af1764eff33aef98c92cccd74b70db0cf63d8 guix-build-096525e92cc2/output/aarch64-linux-gnu/SHA256SUMS.part
d7308491e32e076f40e58aaa9092ceae8a16b39e66937af72bdc8b879164f30
...

💬 pinheadmz commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2652521109)
New sigs for 096525e92cc2f5a4318bae13cedd2cf36b928d5f:

[signature-osx-arm64.tar.gz](https://github.com/user-attachments/files/18761206/signature-osx-arm64.tar.gz)

[signature-osx-x86_64.tar.gz](https://github.com/user-attachments/files/18761208/signature-osx-x86_64.tar.gz)

# All osx

```

111016205f0a2ac732feb934acb3e8a36d5251f119d8fa9215790310ba46c31d bitcoin-096525e92cc2-arm64-apple-darwin.tar.gz
a1228ddcb27fc5802ff5cab8f99026286070b4938aba08982f8e49d8e01b49cf bitcoin-096525e92
...

💬 achow101 commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2652543539)
Looks like everything matches:

```
$ find guix-build-096525e92cc2/output -wholename "*codesigned*" -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
b329c253e4c791d5622adc16ed0c06759ce29309e7d72221c76de4becb58b409 guix-build-096525e92cc2/output/arm64-apple-darwin-codesigned/SHA256SUMS.part
111016205f0a2ac732feb934acb3e8a36d5251f119d8fa9215790310ba46c31d guix-build-096525e92cc2/output/arm64-apple-darwin-codesigned/bitcoin-096525e92cc2-arm64-apple-darwin.tar.gz
a1228ddcb27fc580
...

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1951957283)
added

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1951957432)
fixed

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r1951957531)
Moved into `NeedsTrim`