💬 onlinesipahimithu commented on pull request "Add bitcoin-{node,gui} to release binaries for IPC":
(https://github.com/bitcoin/bitcoin/pull/31802#issuecomment-2646012270)
What is and how

🤔 onlinesipahimithu reviewed a pull request: "Add bitcoin-{node,gui} to release binaries for IPC"
(https://github.com/bitcoin/bitcoin/pull/31802#pullrequestreview-2604083934)
GOOD lesson from

💬 onlinesipahimithu commented on pull request "Remove the legacy wallet and BDB dependency":
(https://github.com/bitcoin/bitcoin/pull/28710#issuecomment-2646012743)
Helli how to develop

⚠️ onlinesipahimithu opened an issue: "Hellobtc"
(https://github.com/bitcoin/bitcoin/issues/31828)
I trying for learn how works crypto

✅ pinheadmz closed an issue: "Hellobtc"
(https://github.com/bitcoin/bitcoin/issues/31828)

💬 eval-exec commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1947992696)
Agree, I prefer fallback to `GetRNSR`.

💬 eval-exec commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#issuecomment-2646035608)
> it would be better to instead investigate and fix the feature test or feature reporting.

Agree, it need time to invistigate this bug.

And I did some research, this CPU have bug on `rndrrs`:
> [04:28](https://oftc.irclog.whitequark.org/aarch64-laptops/2024-07-21#33392883) <HdkR> I found out yesterday that the bitcoin project uses rndrrs if it is available on aarch64 to fill its entropy pool. It spins in a loop until its pool is filled.
> [04:28](https://oftc.irclog.whitequark.org/aarch6
...

💬 eval-exec commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1947993250)
Maybe should fallback to `GetRNDR`?

💬 sipa commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1947994381)
I think it would be even better to do a trial run inside `InitHardwareRand`, so this condition can be detected, and the feature can be considered unsupported (so future calls to GetRNDRS will not even bother).

💬 theStack commented on pull request "contrib: fix `test_deterministic_coverage.sh` script for out-of-tree builds":
(https://github.com/bitcoin/bitcoin/pull/31588#issuecomment-2646119824)
@fjahr: Note that `GCOV_EXECUTABLE` is hardcoded in the script currently, so setting it as environment variable won't have any effect. Can you try again by modifying it directly in the file? It's not very user friendly that this is necessary, can add a commit that allows passing it via environment, if reviewers feel that this is still in scope of this PR.

💬 purpleKarrot commented on something "":
(https://github.com/bitcoin/bitcoin/commit/332655cb52c8f8ef64b29b09e38ef5d61235ed21#r152324998)
Instead of setting so many different variables, why not use variables that are already set by CMake?

The `DESCRIPTION` that is passed to the `project()` command sets the variables `PROJECT_DESCRIPTION` and `BitcoinCore_DESCRIPTION`. Neither of the two variables are used anywhere, so maybe "Bitcoin Core" should be passed as the `DESCRIPTION` argument and then `PROJECT_DESCRIPTION` may be used in places where `PACKAGE_NAME` is used at the moment?

Likewise, the `VERSION` that is passed to `pr
...

💬 katesalazar commented on pull request "Updated MacOS icon to more closely fit Apple's design standards":
(https://github.com/bitcoin-core/gui/pull/852#issuecomment-2646204166)
As an ex macOS user, all I see here now is bytes.

💬 sipa commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1948122100)
Nit: perhaps just say "Using RNDR as additional entropy source" here, instead of claiming that RNDRRS is used, but then disabled?

💬 sipa commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1948121952)
You'll also need to actually use this variable inside `GetRNDRRS()`, to fall back to `GetRNDR()` instead.

💬 laanwj commented on pull request "tracing: network connection tracepoints":
(https://github.com/bitcoin/bitcoin/pull/25832#issuecomment-2646339414)
> I have a slight preference on BIP155 NetworkIDs over keeping-as-is or network name as string.

Agree. Strings are sensitive to typos, and require extra effort for matching when doing statistics. i think even the current enumeration is better than that. BIP155 is a good suggestion, but as you have to make up non-standard values, and handle NET_UNROUTABLE differently i'm not entirely sure.

The purpose of tracing is to gain insight into internal state so logging the actual values makes more
...

💬 eval-exec commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1948125076)
Thank you.

💬 sipa commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1948126145)
Even better, use this directly in the only place this function is called: `SeedHardwareSlow`, instead of the `g_rndr_supported` that is used there now.

💬 eval-exec commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1948126777)
Thank you, Updated.

🤔 sipa reviewed a pull request: "Limit retries in GetRNDRRS to avoid infinite loop"
(https://github.com/bitcoin/bitcoin/pull/31826#pullrequestreview-2604286273)
Code review ACK daa1fbe88171042ae39b257767137c8ba652e046. Please squash your commits.

💬 sipa commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1948128303)
Coding style nit: space after `}`.