Bitcoin Core Github

💬 instagibbs commented on issue "Avoid serving stale fees":
(https://github.com/bitcoin/bitcoin/issues/27555#issuecomment-1537586780)
looks like one of my nodes had a similar issue with a clean shutdown and restart

https://twitter.com/CoreFeeHelper/status/1655286815291588611 after restart, then an hour or so later: https://twitter.com/CoreFeeHelper/status/1655301916593668097

back up to expected min fee

7 views00:34

Bitcoin Core Github

💬 ArmchairCryptologist commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1537784340)
Of the four nodes, the one that was restarted on May 6th is now back to spinning 100% of a CPU core (60% average CPU usage on a two-core VM the last hour) while the three that were restarted yesterday are also seeing high CPU usage but not 100% all the time (between 30% and 38% average CPU usage on a two-core VM), so it's building back up relatively quickly. I also verified that the mempool is not fully committed (usage is at 251217552).

There were around 15 peers with bytessent_per_msg.inv o
...

7 views05:43

Bitcoin Core Github

💬 S3RK commented on pull request "wallet, tests: Expand and test when the blank wallet flag should be un/set":
(https://github.com/bitcoin/bitcoin/pull/25634#issuecomment-1537830694)
re code review ACK 7baa0971527ba3c8d87b82c7a2a4eabf6abbb2b7

My previous comment about exposing `blank` flag is still valid, but I don't think it's blocking. I like furszy's suggestion to return the flag only for regtest

7 views06:35

Bitcoin Core Github

💬 MarcoFalke commented on pull request "rpc: distinguish between vsize and sigop-adjusted mempool vsize":
(https://github.com/bitcoin/bitcoin/pull/27591#discussion_r1187091583)
Is there a setting to affect this value? If yes, does it make sense to mention the setting's key?

7 views06:57

Bitcoin Core Github

💬 MarcoFalke commented on pull request "rpc: distinguish between vsize and sigop-adjusted mempool vsize":
(https://github.com/bitcoin/bitcoin/pull/27591#discussion_r1187089387)
Is there still a reason with recent univalue to use potentially narrowing casts? You could try no cast or a w-narrowing one (with `{}`)?

7 views06:57

Bitcoin Core Github

💬 localbool commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1537886785)
> Just to confirm, yours was in debug mode as well? Otherwise it'd be concerning.

What is debug mode? A binary compiled with `--enable-debug` option or `debug=1` saved in bitcoin.conf?

7 views07:27

Bitcoin Core Github

💬 willcl-ark commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1537887983)
> What is debug mode? A binary compiled with `--enable-debug` option or `debug=1` saved in bitcoin.conf?
>
>

Compiled with `--enable-debug`

7 views07:28

Bitcoin Core Github

⚠️ MarcoFalke opened an issue: "test: RPC coverage check doesn't work?"
(https://github.com/bitcoin/bitcoin/issues/27593)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Currently CI reports that all RPCs are covered: https://cirrus-ci.com/task/6244871116161024?logs=ci#L4674

### Expected behaviour

However, some RPCs are clearly not covered because they are never called. For example:

```
$ git grep abortrescan ./test/ | grep -v '. Please call `abortrescan` before ' | wc -l
0
```

### Steps to reproduce

?

### Relevant log output

_No response_

...

7 views08:14

Bitcoin Core Github

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1187190754)
nit in 1def580e80a1892e473324016db9a0f2ffec0c27: (For this method and others like `UndoReadFromDisk` ...) It is UB to pass a nullptr pindex, so it would be good, while touching the function signature in this pull request to switch the pointer to a reference.

7 views09:59

Bitcoin Core Github

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1187174928)
nit in ea2a049b42f73499eaa1b69212af3514026440fd: Any reason to accept a nullptr here, which would be UB?

I think it would be better to accept a `const CBlockIndex& block`.

7 views09:59

Bitcoin Core Github

👍 MarcoFalke approved a pull request: "refactor, kernel: Decouple ArgsManager from blockstorage"
(https://github.com/bitcoin/bitcoin/pull/27125#pullrequestreview-1416363907)
nice ACK 3b34ac7465919b968795063995f6610a73aa2d29 🗣

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: nice ACK 3b34ac7465919b96
...

7 views09:59

Bitcoin Core Github

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1187180745)
Also, it would be good to include the diff in `src/zmq/zmqpublishnotifier.cpp` from the next commit. This makes review easier, because reviewers can see that the function-to-lambda is a simple 1-1 replacement that compiles and passes all tests on its own.

6 views09:59

6 views09:59

6 views10:00

6 views10:00

6 views10:01

6 views10:01