💬 vasild commented on pull request "rpc: add cpu_load to getpeerinfo":
(https://github.com/bitcoin/bitcoin/pull/31672#issuecomment-2636601335)
@maflcko yes, I agree. Future changes that make message processing multi-threaded will have to take this into account.

👍 vasild approved a pull request: "tracing: network connection tracepoints"
(https://github.com/bitcoin/bitcoin/pull/25832#pullrequestreview-2595610931)
ACK e3622a969293feea75cfadc8f7c6083edcd6d8de

💬 maflcko commented on pull request "refactor: Use std::span over Span":
(https://github.com/bitcoin/bitcoin/pull/31519#discussion_r1942840067)
The comment is for the second function below, see https://github.com/bitcoin/bitcoin/pull/31519#discussion_r1941880894

💬 egruper commented on issue " Cannot figure out how to use std::atomic error for MacOS Sequoia 15.2":
(https://github.com/bitcoin/bitcoin/issues/31579#issuecomment-2636659371)
@hebasto

Nice catch.
I indeed didn't have atomic under /Library/Developer/CommandLineTools/usr/include/c++/v1

I went on to 'rm -rf /Library/Developer/CommandLineTools' and re-install it with 'xcode-select --install' (didn't see your update so I didn't search under SDKs...)

Now I find atomic under:
/Library/Developer/CommandLineTools/SDKs/MacOSX15.2.sdk/usr/include/c++/v1/atomic
/Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/atomic
/Library/Developer/CommandLineToo
...

💬 maflcko commented on pull request "refactor: Use std::span over Span":
(https://github.com/bitcoin/bitcoin/pull/31519#discussion_r1942852606)
Adjusted `span's`, so resolving this for now.

💬 hebasto commented on issue " Cannot figure out how to use std::atomic error for MacOS Sequoia 15.2":
(https://github.com/bitcoin/bitcoin/issues/31579#issuecomment-2636689705)
> And building with 'cmake -B build' works fine.
>
> Is this going to be logged somewhere?

In the configuration output, you can see:
```
-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC
-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC - Success
```

Also you could grep for `ATOMIC` in the `CMakeFiles/CMakeConfigureLog.yaml` log file.

💬 hebasto commented on issue " Cannot figure out how to use std::atomic error for MacOS Sequoia 15.2":
(https://github.com/bitcoin/bitcoin/issues/31579#issuecomment-2636702426)
I assume this issue can now be closed.

✅ maflcko closed an issue: " Cannot figure out how to use std::atomic error for MacOS Sequoia 15.2"
(https://github.com/bitcoin/bitcoin/issues/31579)

💬 maflcko commented on issue " Cannot figure out how to use std::atomic error for MacOS Sequoia 15.2":
(https://github.com/bitcoin/bitcoin/issues/31579#issuecomment-2636783895)
Closing for now, as this seemed to be an upstream issue that was fixed by a re-install.

💬 maflcko commented on pull request "refactor: Use std::span over Span":
(https://github.com/bitcoin/bitcoin/pull/31519#discussion_r1942903118)
thx, done

💬 maflcko commented on pull request "refactor: Use std::span over Span":
(https://github.com/bitcoin/bitcoin/pull/31519#discussion_r1942903310)
thx, done

💬 maflcko commented on pull request "refactor: Use std::span over Span":
(https://github.com/bitcoin/bitcoin/pull/31519#discussion_r1942903540)
Pushed the typo fix, so closing this for now.

💬 l0rinc commented on pull request "refactor: Use std::span over Span":
(https://github.com/bitcoin/bitcoin/pull/31519#issuecomment-2636796621)
ACK fa77685ba5c7185781acca04f57399cdcd19e9f7

👍 brunoerg approved a pull request: "test: add validation for gettxout RPC response"
(https://github.com/bitcoin/bitcoin/pull/30226#pullrequestreview-2595718629)
code review ACK 723440c5b8eb3a815c80bfb37ad195b5448b25ed

💬 maflcko commented on pull request "refactor: Use std::span over Span":
(https://github.com/bitcoin/bitcoin/pull/31519#discussion_r1942909288)
(Resolving for now, but I am still happy to reword or remove the comment.)

💬 Sjors commented on pull request "ci: build multiprocess on most jobs":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2636816161)
CI got rate limited:

```
[08:08:36.286] Error: creating build container: initializing source docker://ubuntu:24.04: reading manifest 24.04 in docker.io/library/ubuntu: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
```

💬 Sjors commented on issue "CI: Failed pulls from docker.io causing jobs to fail":
(https://github.com/bitcoin/bitcoin/issues/31797#issuecomment-2636820896)
@maflcko can you re-run #30975 as well?

💬 jonatack commented on pull request "rpc, logging: return "verificationprogress" of 1 when up to date":
(https://github.com/bitcoin/bitcoin/pull/31177#discussion_r1942925643)
Haven't looked into this yet, but just finished a 3-week IBD. The past few days was switching between this branch and master, with stops and starts as internet access was intermittent, and this branch seemed to work well -- it returned the same value or very close each time.

```
Blocks: 882404
Headers: 882404
Verification progress: 100.0000%
```

💬 maflcko commented on issue "CI: Failed pulls from docker.io causing jobs to fail":
(https://github.com/bitcoin/bitcoin/issues/31797#issuecomment-2636829407)
I've rebooted the CI machines yesterday and today, which caused the issues here. I'll keep an eye on the tasks an re-run any that fail due to dockerhub limits for the next few hours. This should fix it once and for all (for now 😅 ).

💬 Sjors commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1942930263)
Agreed (though can wait for a followup).

For the fuzzer it's probably best to push the most extreme value a user can achieve without recompilation.