💬 ryanofsky commented on pull request "multiprocess: Add libmultiprocess git subtree":
(https://github.com/bitcoin/bitcoin/pull/31741#issuecomment-2633863663)
re: https://github.com/bitcoin/bitcoin/pull/31741#issuecomment-2633426678

> I'm unable to make a Guix build.

Thanks, created https://github.com/chaincodelabs/libmultiprocess/issues/150 to track this

💬 hebasto commented on pull request "ci: build multiprocess on most jobs":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2633897096)
> macOS cross compile fails (in a different way): https://cirrus-ci.com/task/5052270577975296
>
> ```
> [09:45:29.772] /bin/sh: 1: /ci_container_base/depends/x86_64-apple-darwin/bin/capnp: Exec format error
> ```

It should call `/ci_container_base/depends/x86_64-apple-darwin/native/bin/capnp`.

💬 maflcko commented on pull request "rpc: Ensure -debug=0/none behaves consistently with -nodebug":
(https://github.com/bitcoin/bitcoin/pull/31767#discussion_r1941170754)
What is the connection to RPC? I was under the impression that `-debug` is a setting related to logging.

💬 hebasto commented on issue " Cannot figure out how to use std::atomic error for MacOS Sequoia 15.2":
(https://github.com/bitcoin/bitcoin/issues/31579#issuecomment-2634033316)
I cannot reproduce the issue on my MacOS Sequoia 15.2 (24C101):
```
% clang --version
Apple clang version 16.0.0 (clang-1600.0.26.6)
Target: arm64-apple-darwin24.2.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
% cmake -B build -DWITH_BDB=ON
<snip>
-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC
-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC - Success
<snip>
```

Can anyone else provide the exact steps to reproduce the is
...

💬 brunoerg commented on pull request "test: check `scanning` field from `getwalletinfo`":
(https://github.com/bitcoin/bitcoin/pull/31768#discussion_r1941236428)
You're right, could happen. I just added a try/except around it, now it checks the duration is greater than 0 or if the field is not returned into `getwalletinfo` response.

💬 ryanofsky commented on issue "test: 32-bit Clang `ipc_test` failure at `-O0`":
(https://github.com/bitcoin/bitcoin/issues/31772#issuecomment-2634071115)
Thanks was able to get a stack trace by running `cd /ci_container_base/ci/scratch/build-i686-pc-linux-gnu`, `gdb -ex run --args ./src/test/test_bitcoin -t ipc_tests`, and `bt` in container:

```c++
#0 0xf7f4b5b9 in __kernel_vsyscall ()
#1 0xf79e6037 in ?? () from /lib32/libc.so.6
#2 0xf7994c51 in raise () from /lib32/libc.so.6
#3 0xf797c2b7 in abort () from /lib32/libc.so.6
#4 0xf7d4bf71 in ?? () from /lib32/libstdc++.so.6
#5 0xf7d65a97 in ?? () from /lib32/libstdc++.so.6
#6 0xf7d4b8f9 in
...

💬 jonatack commented on pull request "rpc, logging: return "verificationprogress" of 1 when up to date":
(https://github.com/bitcoin/bitcoin/pull/31177#discussion_r1941252509)
Yes, I suggested these in https://github.com/bitcoin/bitcoin/pull/31177#discussion_r1940010147.

💬 ryanofsky commented on issue "test: 32-bit Clang `ipc_test` failure at `-O0`":
(https://github.com/bitcoin/bitcoin/issues/31772#issuecomment-2634113716)
Stack trace seems to be showing something going wrong in capnproto code, but unclear what the cause is. The crash is happening in the CidrRange::CidrRange constructor here:

https://github.com/capnproto/capnproto/blob/b34ec28cceaf15b1082b74b50f03f770873c3636/c%2B%2B/src/kj/cidr.c%2B%2B#L53

which is being called on a static list of address patterns:

https://github.com/capnproto/capnproto/blob/b34ec28cceaf15b1082b74b50f03f770873c3636/c%2B%2B/src/kj/async-io.c%2B%2B#L2999-L3007

All of the patter
...

💬 ryanofsky commented on issue "test: 32-bit Clang `ipc_test` failure at `-O0`":
(https://github.com/bitcoin/bitcoin/issues/31772#issuecomment-2634135091)
gdb shows invalid results being returned from `pattern.findFirst('/')` call where pattern is `192.0.0.0/24`

https://github.com/capnproto/capnproto/blob/b34ec28cceaf15b1082b74b50f03f770873c3636/c%2B%2B/src/kj/cidr.c%2B%2B#L51C48-L51C57

```
#14 0x5971f1e4 in kj::CidrRange::CidrRange (this=0x5a930c80 <kj::_::reservedCidrs()::result>, pattern=...) at /usr/src/kj/cidr.c++:53
(gdb) p pattern
$6 = {content = {<kj::DisallowConstCopyIfNotConst<char const>> = {<No data fields>}, ptr = 0x59e13a45 "192.0.
...

💬 willcl-ark commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1941284740)
We could also (or additionally) check if the user has set the launcher themselves by gating the entire following section with:

```cmake
if(NOT DEFINED CMAKE_CXX_COMPILER_LAUNCHER)
```

...skipping all ccache setup if they have.

This way we might be able to get the best of both "sane defaults" and "easy to override".

💬 hebasto commented on pull request "ci: build multiprocess on most jobs":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2634149344)
> macOS cross compile fails (in a different way): https://cirrus-ci.com/task/5052270577975296
>
> ```
> [09:45:29.772] /bin/sh: 1: /ci_container_base/depends/x86_64-apple-darwin/bin/capnp: Exec format error
> ```

Here is a fix:
```diff
--- a/depends/toolchain.cmake.in
+++ b/depends/toolchain.cmake.in
@@ -155,6 +155,8 @@ endif()
if("@multiprocess@" STREQUAL "1")
set(ENABLE_IPC ON CACHE BOOL "")
set(Libmultiprocess_EXTERNAL_MPGEN "@depends_prefix@/native/bin/mpgen" CACHE PATH
...

💬 hebasto commented on pull request "ci: build multiprocess on most jobs":
(https://github.com/bitcoin/bitcoin/pull/30975#discussion_r1941299799)
Please, don't reintroduce more `@depends_prefix@` instances:
```suggestion
set(Libmultiprocess_EXTERNAL_MPGEN "${CMAKE_CURRENT_LIST_DIR}/native/bin/mpgen" CACHE FILEPATH "")
```

For the context, please see https://github.com/bitcoin/bitcoin/pull/31358.

💬 ajtowns commented on pull request "Double check all block rules in `ConnectBlock`, not only `CheckBlock`":
(https://github.com/bitcoin/bitcoin/pull/31792#discussion_r1941306874)
Should this line be in the following commit?

💬 danielabrozzoni commented on pull request "rpc: Ensure -debug=0/none behaves consistently with -nodebug":
(https://github.com/bitcoin/bitcoin/pull/31767#discussion_r1941344025)
You're right, thanks! Updated with "Logging" as it feels more appropriate to me too

💬 darosior commented on pull request "Double check all block rules in `ConnectBlock`, not only `CheckBlock`":
(https://github.com/bitcoin/bitcoin/pull/31792#discussion_r1941355885)
Done.

💬 Sjors commented on pull request "ci: build multiprocess on most jobs":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2634256382)
Let's see if only ASan remains... https://github.com/bitcoin/bitcoin/actions/runs/13138410284/job/36659308174?pr=30975

💬 maflcko commented on pull request "test: check `scanning` field from `getwalletinfo`":
(https://github.com/bitcoin/bitcoin/pull/31768#issuecomment-2634283850)
lgtm ACK bb0879ddabc8b3a7253bc774d23b842937d18015

💬 maflcko commented on pull request "ci: run in worktrees":
(https://github.com/bitcoin/bitcoin/pull/31787#discussion_r1941383838)
On a second though, I guess if someone wanted to run the CI on an extracted tarball of the repo (git-archive), it would be better to also support that. Not sure if it is as trivial as `git init && git add ./`, so no strong opinion.

💬 darosior commented on pull request "Double check all block rules in `ConnectBlock`, not only `CheckBlock`":
(https://github.com/bitcoin/bitcoin/pull/31792#discussion_r1941384261)
To keep the existing level for this error. I suppose the existing level is debug due to log-filling concerns, maybe with very-low-difficulty headers?

Thanks for pointing this out though, i double checked the other log line in `TestBlockValidity` and there it should have been `LogError`. Fixed.

💬 ryanofsky commented on pull request "ci: build multiprocess on most jobs":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2634296691)
re: https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2634256382

> Let's see if only ASan remains... https://github.com/bitcoin/bitcoin/actions/runs/13138410284/job/36659308174?pr=30975

Following might fix the asan error:

```diff
--- a/src/ipc/CMakeLists.txt
+++ b/src/ipc/CMakeLists.txt
@@ -9,6 +9,7 @@ if (NOT WITH_LIBMULTIPROCESS)
# Apply core_interface compile options to libmultiprocess runtime library.
target_link_libraries(multiprocess PUBLIC $<BUILD_INTERFACE:co
...