💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939695630)
Taken, thanks @pinheadmz
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939695630)
Taken, thanks @pinheadmz
💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939689525)
Done!
I updated the error message to indicate that it is policy default block max weight.
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939689525)
Done!
I updated the error message to indicate that it is policy default block max weight.
💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939696594)
Done!
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939696594)
Done!
💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939791295)
Fixed
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939791295)
Fixed
💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939791635)
I've updated the release notes.
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939791635)
I've updated the release notes.
💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939697020)
Fixed
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939697020)
Fixed
💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939791981)
Taken but slightly different
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939791981)
Taken but slightly different
💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#issuecomment-2631717860)
Forced pushed to address recent comments by @fjahr @pinheadmz and @Sjors see [diff](https://github.com/bitcoin/bitcoin/compare/fd4af64d58901334d907dd0bd38efd303a21374a..e7df348288e81dae104df7f8c984cb8eca57da35)
Changes
1. Updated release notes to be more accurate
2. Introduce `DEFAULT_BLOCK_RESERVED_WEIGHT`
3. Fixed nits
(https://github.com/bitcoin/bitcoin/pull/31384#issuecomment-2631717860)
Forced pushed to address recent comments by @fjahr @pinheadmz and @Sjors see [diff](https://github.com/bitcoin/bitcoin/compare/fd4af64d58901334d907dd0bd38efd303a21374a..e7df348288e81dae104df7f8c984cb8eca57da35)
Changes
1. Updated release notes to be more accurate
2. Introduce `DEFAULT_BLOCK_RESERVED_WEIGHT`
3. Fixed nits
💬 Sjors commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939820972)
In c961c509bc5d4a8c9e9197cad001d2b7598c8bd7 "miner: bugfix: fix duplicate weight reservation in block assembler": I'd rather keep the explanation in `types.h` since `BlockCreateOptions` is part of an external interface that should make sense without having to dig into internals.
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939820972)
In c961c509bc5d4a8c9e9197cad001d2b7598c8bd7 "miner: bugfix: fix duplicate weight reservation in block assembler": I'd rather keep the explanation in `types.h` since `BlockCreateOptions` is part of an external interface that should make sense without having to dig into internals.
💬 Sjors commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939827439)
In 8b8e143a8fdd9c12068c7d7f5bbe5317dd55d22a "init: fail to start when `-blockmaxweight` exceeds `DEFAULT_MAX_BLOCK_WEIGHT`": I think this should only check against consensus.
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939827439)
In 8b8e143a8fdd9c12068c7d7f5bbe5317dd55d22a "init: fail to start when `-blockmaxweight` exceeds `DEFAULT_MAX_BLOCK_WEIGHT`": I think this should only check against consensus.
💬 Sjors commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939831288)
In cd6cca1018f1c4b0c5d73991afbdb19d1b0b9682 "miner: init: add `-blockreservedweight` startup option"
Same as for the earlier commit, imo this should only check against the consensus limit.
https://github.com/bitcoin/bitcoin/pull/31384/commits/cd6cca1018f1c4b0c5d73991afbdb19d1b0b9682#r1938237527
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939831288)
In cd6cca1018f1c4b0c5d73991afbdb19d1b0b9682 "miner: init: add `-blockreservedweight` startup option"
Same as for the earlier commit, imo this should only check against the consensus limit.
https://github.com/bitcoin/bitcoin/pull/31384/commits/cd6cca1018f1c4b0c5d73991afbdb19d1b0b9682#r1938237527
💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939839897)
In block assembly, we check against policy. If we were to lower the policy default, users could set a higher value than our policy limit, but the generated block would still be checked against policy, meaning their higher value would have no effect. I think we should be consistent and either check against policy everywhere or remove the policy default and check only against consensus?
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939839897)
In block assembly, we check against policy. If we were to lower the policy default, users could set a higher value than our policy limit, but the generated block would still be checked against policy, meaning their higher value would have no effect. I think we should be consistent and either check against policy everywhere or remove the policy default and check only against consensus?
💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939842698)
Done in this [push](https://github.com/bitcoin/bitcoin/compare/e7df348288e81dae104df7f8c984cb8eca57da35..6709e185b93d97b9191597acfecb25c33ab43a0a)
Also updated the release note to fix grammar
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939842698)
Done in this [push](https://github.com/bitcoin/bitcoin/compare/e7df348288e81dae104df7f8c984cb8eca57da35..6709e185b93d97b9191597acfecb25c33ab43a0a)
Also updated the release note to fix grammar
📝 Hack666r opened a pull request: "Typos fix"
(https://github.com/bitcoin/bitcoin/pull/31789)
### Changes
1. **File:** `/test/lint/README.md`
- Fixed `lief` to `leaf, life` (Line 48)
1. **File:** `/contrib/guix/INSTALL.md`
- Fixed `debbugs` to `debugs, bedbugs` (Line 761)
1. **File:** `/doc/psbt.md`
- Fixed `Asend` to `Ascend, As end` (Line 132)
1. **File:** `/doc/tracing.md`
- Fixed `stap` to `step, stop` (Line 379)
### Purpose
- Improved documentation accuracy by fixing typographical errors.
- Ensured better readability and consistency.
(https://github.com/bitcoin/bitcoin/pull/31789)
### Changes
1. **File:** `/test/lint/README.md`
- Fixed `lief` to `leaf, life` (Line 48)
1. **File:** `/contrib/guix/INSTALL.md`
- Fixed `debbugs` to `debugs, bedbugs` (Line 761)
1. **File:** `/doc/psbt.md`
- Fixed `Asend` to `Ascend, As end` (Line 132)
1. **File:** `/doc/tracing.md`
- Fixed `stap` to `step, stop` (Line 379)
### Purpose
- Improved documentation accuracy by fixing typographical errors.
- Ensured better readability and consistency.
📝 petryshkaCODE opened a pull request: "Fixed typos"
(https://github.com/bitcoin/bitcoin/pull/31790)
### Changes
1. **File:** `/test/lint/README.md`
- Fixed `LIEF` to `LEAF, LIFE` (Line 48)
1. **File:** `/doc/build-osx.md`
- Fixed `useable` to `usable` (Line 74)
1. **File:** `/doc/psbt.md`
- Fixed `Asend` to `Ascend, As end` (Line 137)
### Purpose
- Enhanced the clarity and professionalism of the documentation.
- Fixed minor grammatical issues for better understanding.
(https://github.com/bitcoin/bitcoin/pull/31790)
### Changes
1. **File:** `/test/lint/README.md`
- Fixed `LIEF` to `LEAF, LIFE` (Line 48)
1. **File:** `/doc/build-osx.md`
- Fixed `useable` to `usable` (Line 74)
1. **File:** `/doc/psbt.md`
- Fixed `Asend` to `Ascend, As end` (Line 137)
### Purpose
- Enhanced the clarity and professionalism of the documentation.
- Fixed minor grammatical issues for better understanding.
🤔 ryanofsky reviewed a pull request: "multiprocess: Add libmultiprocess git subtree"
(https://github.com/bitcoin/bitcoin/pull/31741#pullrequestreview-2590699485)
Rebased ab041937289f4939758c1896f5cb57f556ae0615 -> 1c10bfc167b0f3c17780b2ae3747999ee56c4e1c ([`pr/subtree.4`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree.4) -> [`pr/subtree.5`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree.5), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/subtree.4-rebase..pr/subtree.5)) incorporating changes from https://github.com/theuni/bitcoin/commits/libmultiprocess-vendor/ and making various build fixes to let multiprocess CI jobs succeed
...
(https://github.com/bitcoin/bitcoin/pull/31741#pullrequestreview-2590699485)
Rebased ab041937289f4939758c1896f5cb57f556ae0615 -> 1c10bfc167b0f3c17780b2ae3747999ee56c4e1c ([`pr/subtree.4`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree.4) -> [`pr/subtree.5`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree.5), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/subtree.4-rebase..pr/subtree.5)) incorporating changes from https://github.com/theuni/bitcoin/commits/libmultiprocess-vendor/ and making various build fixes to let multiprocess CI jobs succeed
...
💬 ryanofsky commented on pull request "multiprocess: Add libmultiprocess git subtree":
(https://github.com/bitcoin/bitcoin/pull/31741#discussion_r1939842127)
re: https://github.com/bitcoin/bitcoin/pull/31741#discussion_r1938048845
> for determinism (our sources can be described exactly).
The sources are described by the git hash. The tarball could be generated deterministically too, but should be ok to just use default tar options. If during a deterministic build, you put a directory into a intermediate tarball and extract it and compile it, whether the intermediate tarball was deterministic should not effect whether build outputs are determini
...
(https://github.com/bitcoin/bitcoin/pull/31741#discussion_r1939842127)
re: https://github.com/bitcoin/bitcoin/pull/31741#discussion_r1938048845
> for determinism (our sources can be described exactly).
The sources are described by the git hash. The tarball could be generated deterministically too, but should be ok to just use default tar options. If during a deterministic build, you put a directory into a intermediate tarball and extract it and compile it, whether the intermediate tarball was deterministic should not effect whether build outputs are determini
...
💬 pinheadmz commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2631806570)
I got one step further by creating the directory its looking for in the last error:
`$ mkdir -p /home/zip/bitcoin/guix-build-ba67aa681e9b/var/profiles/`
this broke somewhere new...
```
$ DETACHED_SIGS_REPO=../bitcoin-detached-sigs HOSTS=arm64-apple-darwin FORCE_DIRTY_WORKTREE=1 ./contrib/guix/guix-codesign
Checking that we can connect to the guix-daemon...
Hint: If this hangs, you may want to try turning your guix-daemon off and on
again.
INFO: Codesigning ba67aa681e9b f
...
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2631806570)
I got one step further by creating the directory its looking for in the last error:
`$ mkdir -p /home/zip/bitcoin/guix-build-ba67aa681e9b/var/profiles/`
this broke somewhere new...
```
$ DETACHED_SIGS_REPO=../bitcoin-detached-sigs HOSTS=arm64-apple-darwin FORCE_DIRTY_WORKTREE=1 ./contrib/guix/guix-codesign
Checking that we can connect to the guix-daemon...
Hint: If this hangs, you may want to try turning your guix-daemon off and on
again.
INFO: Codesigning ba67aa681e9b f
...
✅ hebasto closed a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/31789)
(https://github.com/bitcoin/bitcoin/pull/31789)
📝 hebasto locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/31789)
### Changes
1. **File:** `/test/lint/README.md`
- Fixed `lief` to `leaf, life` (Line 48)
1. **File:** `/contrib/guix/INSTALL.md`
- Fixed `debbugs` to `debugs, bedbugs` (Line 761)
1. **File:** `/doc/psbt.md`
- Fixed `Asend` to `Ascend, As end` (Line 132)
1. **File:** `/doc/tracing.md`
- Fixed `stap` to `step, stop` (Line 379)
### Purpose
- Improved documentation accuracy by fixing typographical errors.
- Ensured better readability and consistency.
(https://github.com/bitcoin/bitcoin/pull/31789)
### Changes
1. **File:** `/test/lint/README.md`
- Fixed `lief` to `leaf, life` (Line 48)
1. **File:** `/contrib/guix/INSTALL.md`
- Fixed `debbugs` to `debugs, bedbugs` (Line 761)
1. **File:** `/doc/psbt.md`
- Fixed `Asend` to `Ascend, As end` (Line 132)
1. **File:** `/doc/tracing.md`
- Fixed `stap` to `step, stop` (Line 379)
### Purpose
- Improved documentation accuracy by fixing typographical errors.
- Ensured better readability and consistency.