📝 brunoerg converted_to_draft a pull request: "fuzz: wallet: add target for spkm migration"
(https://github.com/bitcoin/bitcoin/pull/29694)
This PR adds a fuzz target for `ScriptPubKeyMan` migration. It creates a `LegacyDataSPKM` which can have some keys/scripts/etc, and then migrate it to descriptor. I tried to keep it as compatible as possible with future legacy wallet removal.

💬 willcl-ark commented on pull request "ci: run in worktrees":
(https://github.com/bitcoin/bitcoin/pull/31787#discussion_r1939723475)
Hmmm, this was actually my first approach in the lint script, as it was simpler. Once I got this working in the Ci script, I backported a "matching" version to the linter script.

Looking at:

https://github.com/bitcoin/bitcoin/blob/1172bc4157eefe80d1aaf0b56459857ec651e535/ci/test/01_base_install.sh#L11-L16

...I mistakenly thought that `.git` was actually needed, but i) it's mounted RO, and ii) it's only used as above here as far as I can see in the whole CI.

Can we just touch a (
...

📝 rhysbeynon opened a pull request: "Case fix"
(https://github.com/bitcoin-core/gui/pull/851)
fixes letter case in icon filename to prior default.

✅ rhysbeynon closed a pull request: "Case fix"
(https://github.com/bitcoin-core/gui/pull/851)

💬 maflcko commented on pull request "ci: run in worktrees":
(https://github.com/bitcoin/bitcoin/pull/31787#discussion_r1939733626)
> ...I mistakenly thought that `.git` was actually needed, but i) it's mounted RO, and ii) it's only used as above here as far as I can see in the whole CI.

It is also used in tidy via `git --no-pager diff`.



> Can we just touch a (any) file to persist the flag then, and drop all `.git` requirement?

Yes, but I don't know how to do that in a one-liner cross-platform (linux+mac), taking into account the different root trees and permissions. So just using git seems simplest?

📝 rhysbeynon opened a pull request: "Updated MacOS icon to more closely fit Apple's design standards"
(https://github.com/bitcoin-core/gui/pull/852)
_This is a duplicate of my mis-appropriated fork of [bitcoin/bitcoin](https://github.com/bitcoin/bitcoin)_

### Mac OS Minor icon change

**This is a fix to an outdated format of app icon. I am not trying to change re-invent the wheel with this, I am simply fixing a minor perceived issue. This should not be seen as a subjective design change as it does not change anything substantially.**

Apple's design guidelines have changed since the previous iteration of the Bitcoin-Core app icon. As
...

💬 Sjors commented on pull request "Have createNewBlock() ensure m_tip_block is set":
(https://github.com/bitcoin/bitcoin/pull/31785#issuecomment-2631596373)
There were slightly more worms in this can.

Instead I've now changed `createNewBlock()` to first call `waitTipChanged()` and the latter to return null during a shutdown. This shifts some work to the RPC, but I think makes the overall behaviour easier to understand.

💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1939755012)
The latest push has `waitTipChanged` and `createNewBlock` return null if the node shuts down, and documentation is updated to reflect that.

✅ Sjors closed a pull request: "Pass custom DEP_OPTS and CONFIG_FLAGS to guix-build"
(https://github.com/bitcoin/bitcoin/pull/31763)

💬 Sjors commented on pull request "Add waitNext() to BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/31283#discussion_r1939763961)
> though I could include it here.

It turned into a bigger change than I expected, so better to keep it separate from this. I don't think it's blocking.

💬 fanquake commented on issue "test: 32-bit Clang `ipc_test` failure at `-O0`":
(https://github.com/bitcoin/bitcoin/issues/31772#issuecomment-2631693290)
cc @ryanofsky

📝 MonkeyKing44 opened a pull request: "Corrected typos"
(https://github.com/bitcoin/bitcoin/pull/31788)
### Changes

1. **File:** `/contrib/guix/INSTALL.md`
- Fixed `debbugs` to `debugs, bedbugs` (Line 761)
1. **File:** `/doc/psbt.md`
- Fixed `Asend` to `Ascend, As end` (Line 129)
1. **File:** `/doc/tracing.md`
- Fixed `stap` to `step, stop` (Line 378)

### Purpose

- EImproved the documentation's clarity and professional tone.
- Corrected small grammatical errors to enhance comprehension.

🤔 pinheadmz reviewed a pull request: "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries"
(https://github.com/bitcoin/bitcoin/pull/31407#pullrequestreview-2590596665)
I'm hitting an error with `guix-codesign`. I am just focusing on `HOSTS=arm64-apple-darwin`, guix build of: ba67aa681e9b28a9992636fec4e06b26b3c3422e

SHASUMS.part:
```
462617a5476e946e10be8624d73b531041c8abf4628a35038d65b80534de768a arm64-apple-darwin/bitcoin-ba67aa681e9b-arm64-apple-darwin-codesigning.tar.gz
2583965a7ecbcf48946bcb7676cf6b39a04cee44b34c6292d81cbb825f0d35df arm64-apple-darwin/bitcoin-ba67aa681e9b-arm64-apple-darwin-unsigned.tar.gz
96f25391136c5e3f77b6dfb4e027aa1f43ccc91ed
...

💬 pinheadmz commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#discussion_r1939779580)
output file is actually `signature-osx-executable.tar.gz`

💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939695630)
Taken, thanks @pinheadmz

💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939689525)
Done!
I updated the error message to indicate that it is policy default block max weight.

💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939696594)
Done!

💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939791295)
Fixed

💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939791635)
I've updated the release notes.

💬 ismaelsadeeq commented on pull request "mining: bugfix: Fix duplicate coinbase tx weight reservation":
(https://github.com/bitcoin/bitcoin/pull/31384#discussion_r1939697020)
Fixed