💬 jonatack commented on pull request "p2p: Allow whitelisting outgoing connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1186377787)
19f3f3a A comment here for future readers documenting when/why to use this would be good.

💬 jonatack commented on pull request "p2p: Allow whitelisting outgoing connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1186373633)
https://github.com/bitcoin/bitcoin/commit/f52fc86d0840221a5d106eec201a4dcffd7d5774 without quotes here it doesn't seem clear that these are values to be passed

```suggestion
"Additional flags \"in\" and \"out\" control whether permissions apply to incoming connections and/or outgoing (default: %s). "
```

```
$ ./src/bitcoind -h | grep -A7 "\-whitelist="
-whitelist=<[permissions@]IP address or network>
Add permission flags to the peers using the given IP address (e.g.
...

💬 jonatack commented on pull request "p2p: Allow whitelisting outgoing connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1186378760)
https://github.com/bitcoin/bitcoin/commit/19f3f3a316660890f03d6ddcb4a4230eb2ff5e91 This doesn't seem to be a pure refactoring here and in `mempool_packages.py` and `p2p_segwit.py`

💬 martinus commented on pull request "util: Use steady clock instead of system clock to measure durations":
(https://github.com/bitcoin/bitcoin/pull/27405#issuecomment-1536625417)
Code review ACK fa83fb3, also ran all tests. All usages of the steady_clock are just for duration measurements, so the change to a different epoch is ok.

👍 martinus approved a pull request: "util: Use steady clock instead of system clock to measure durations"
(https://github.com/bitcoin/bitcoin/pull/27405#pullrequestreview-1415266523)
Code review ACK https://github.com/bitcoin/bitcoin/commit/fa83fb31619c19a1a30b4181486601a944941b16, also ran all tests. All usages of the steady_clock are just for duration measurements, so the change to a different epoch is ok.

💬 pinheadmz commented on pull request "net: call getaddrinfo() in detachable thread to prevent stalling":
(https://github.com/bitcoin/bitcoin/pull/27557#issuecomment-1536631559)
...got thread sanitizer errors running locally on main when my local DNS is black-holed. Fixed that with a shared pointer.

💬 hebasto commented on pull request "build: Add CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/25797#issuecomment-1536643935)
Rebased on top of the bitcoin/bitcoin#27554.

The CI build is :green_circle:

🤔 glozow reviewed a pull request: "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0"
(https://github.com/bitcoin/bitcoin/pull/27501#pullrequestreview-1415387665)
Addressed review comments and moved it from rpc/mempool.cpp to rpc/mining.cpp.

> Probably miners would be thankful to not need multiply the result by 100000000 first in order to delete mapDelta entries (and it would also make the tests simpler 😅), but happy to ACK either variant.

I agree! I've changed it to satoshis to be the same as prioritisetransaction.

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1186458650)
Good point, changed to `getprioritisedtransactions`

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1186459877)
Done

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1186461359)
Fixed

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1186460872)
Would it be API-breaky to change the result of prioritisetransaction?

I've edited the logs though, to show whether the tx is in mempool and what the new delta is. Btw I don't think `nTransactionsUpdated` starts out at 0 when this is called.

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1186461032)
Done

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1186459024)
Removed

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1186459071)
Fixed

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1186459143)
Taken

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1186461262)
Done, added a `std::optional<CAmount> modified_fee` to the `delta_info` struct

💬 udiWertheimer commented on pull request "Allow accepting non-standard transactions on mainnet":
(https://github.com/bitcoin/bitcoin/pull/27578#issuecomment-1536733105)
> taproot was designed with specific goals in mind to allow people to do whatever they want, as long as they aren't causing systemic issues with relay/validation/miners.
>
> On the other hand, legacy script is full of DoS disasters(that we can't simply softfork out because literal _theft_), and we shouldn't just open the gates further for people to trash the network.

Admittedly I wasn’t aware of that distinction between taproot and pre-taproot scripts wrt DoS issues. That’s good news! If t
...

💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1536739318)
Rebased e056d6f758382d3418682095ab02f8d487aa641f -> 3b34ac7465919b968795063995f6610a73aa2d29 ([removeBlockstorageArgs_20](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_20) -> [removeBlockstorageArgs_21](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_21), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_20..removeBlockstorageArgs_21))
* Fixed conflicts with #27570
* Added a commit to remove the params argument from the f
...

💬 TheCharlatan commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#issuecomment-1536750187)
Rebased 7d361083d72a267de4af258e574219abdef0fc82 -> dd95e2a3353b5ded87d1d5408a51bf461f1f90b4 ([kernelChainType_2](https://github.com/TheCharlatan/bitcoin/tree/kernelChainType_2) -> [kernelChainType_3](https://github.com/TheCharlatan/bitcoin/tree/kernelChainType_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelChainType_2..kernelChainType_3))
* Fixed conflict with #27570