💬 MarcoFalke commented on pull request "Allow accepting non-standard transactions on mainnet":
(https://github.com/bitcoin/bitcoin/pull/27578#issuecomment-1535776017)
Presumed related issue: #27490

💬 TalasDigital commented on pull request "Allow accepting non-standard transactions on mainnet":
(https://github.com/bitcoin/bitcoin/pull/27578#issuecomment-1535777823)
Concept ACK.

I agree that this is seriously worth considering in light of risks related to mempool divergence and mining centralization if non-standard transaction usage grows in popularity.

💬 MarcoFalke commented on pull request "ci: Add test coverage job":
(https://github.com/bitcoin/bitcoin/pull/27547#discussion_r1185754046)
It is not possible to execute something inside the CI pod after it has been killed (see previous line). I've cleared the confusion in the second commit of https://github.com/bitcoin/bitcoin/pull/27573

💬 berenddeboer commented on issue "[Linux] Add wayland support":
(https://github.com/bitcoin/bitcoin/issues/19950#issuecomment-1535805727)
I've switched to the Sway window manager which gets a lot of traction, but unfortunately got here as bitcoin doesn't run.

💬 benthecarman commented on pull request "Allow accepting non-standard transactions on mainnet":
(https://github.com/bitcoin/bitcoin/pull/27578#issuecomment-1535832559)
> If there's a standardness rule that is interfering with someone's use case, we should discuss it and figure out whether the rule can be relaxed to accommodate the use case, or whether the use case can be adapted to comply with the standardness rules. Generally speaking, our policy rules are designed to prevent various kinds of denial-of-service attacks, or to help make sure the network runs smoothly -- so if users are trying to bypass them, there's a good chance that there's insufficient under
...

💬 hebasto commented on pull request "Enable HW-accelerated implementations of SHA256 for MSVC builds":
(https://github.com/bitcoin/bitcoin/pull/24773#discussion_r1185847875)
1. This `#if ... #else ... #endif` [block](https://github.com/hebasto/bitcoin/blob/915bdbdf8c87e20426161bbf393d1036659813a2/src/random.cpp#L69-L185) guards two static functions--`GetRdRand` and `GetRdSeed`--which are not implemented for Windows. Not adding `&& !defined(_MSC_VER)` ends with an error:
```
C:\Users\hebasto\bitcoin\src\random.cpp(137,1): fatal error C1189: #error: "RdRand is only supported on x86 and x86_64" [C:\Users\hebasto\bitcoin\build_msvc\li
bbitcoin_util\libbitcoin_util.
...

📝 0xchabbi opened a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/27579)
change naming and link it right

✅ fanquake closed a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/27579)

⚠️ fanquake pinned an issue: "Package Relay Project Tracking"
(https://github.com/bitcoin/bitcoin/issues/27463)
This issue will be edited frequently to reflect the current status of the project.

PR ready for review: #26711

**Mempool, Policy, Validation**

- [x] Enable validation of multiple transactions in ATMP
- [x] Refactoring #21062, #22675, #23381
- [x] Multiple transactions in testmempoolaccept #20833
- [x] Package limits #21800
- [x] Allow submission of 1 child with parents #22674
- [x] Enable a child to bump parents in a package #24152
- [x] Make package validation interface a
...

💬 fanquake commented on issue "Release schedule for 25.0":
(https://github.com/bitcoin/bitcoin/issues/26549#issuecomment-1535982379)
> Start RC cycle, tag and release 25.0rc1

`rc1` binarie are now available: https://bitcoincore.org/bin/bitcoin-core-25.0/test.rc1/.

💬 hebasto commented on issue "[Linux] Add wayland support":
(https://github.com/bitcoin/bitcoin/issues/19950#issuecomment-1535989723)
@berenddeboer
> I've switched to the Sway window manager which gets a lot of traction, but unfortunately got here as bitcoin doesn't run.

You can compile `bitcoin-qt` by yourself using linking against system-wide (modern enough) Qt5 packages. The resulted binary will support Wayland.

To run it, the additional packages could be required. For details, see https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md.

💬 willcl-ark commented on pull request "util: Use steady clock instead of system clock to measure durations":
(https://github.com/bitcoin/bitcoin/pull/27405#issuecomment-1535999135)
ACK fa83fb3161

This is a nice cleanup to the clocks.

There are a few time values left as other types in the codebase, but it doesn't make sense to change them as they are being used as those types by other components (mainly libevent it seems).

💬 fanquake commented on issue "Compiling a bitcoin core version that accepts transactions over 100vkb":
(https://github.com/bitcoin/bitcoin/issues/27490#issuecomment-1536017323)
Closing for now.

✅ fanquake closed an issue: "Compiling a bitcoin core version that accepts transactions over 100vkb"
(https://github.com/bitcoin/bitcoin/issues/27490)

📝 hebasto opened a pull request: "msvc: Cleanup after upgrading libsecp256k1 up to 0.3.0"
(https://github.com/bitcoin/bitcoin/pull/27580)
libsecp256k1 [v0.3.0](https://github.com/bitcoin-core/secp256k1/blob/master/CHANGELOG.md#030---2023-03-08):
> Removed the configuration header `src/libsecp256k1-config.h`.

This PR removed the code that has been unused since https://github.com/bitcoin/bitcoin/pull/27230.

The `USE_ASM_X86_64` is now undefined explicitly (but actually it seems a bit redundant).

The `ECMULT_GEN_PREC_BITS` and `ECMULT_WINDOW_SIZE` macros are defined by the source code to their defaults.

---

Considerin
...

🤔 darosior reviewed a pull request: "Switch hardened derivation marker to h (in normalized descriptors and new wallets)"
(https://github.com/bitcoin/bitcoin/pull/26076#pullrequestreview-1413412381)
light ACK bd13dc2f46ea10302a928fcf0f53b7aed77ad260. Code looks correct to me but i find the OP and release note misleading (stated purpose is already possible and not what this PR implements) and i'm a bit confused about the choice of where to make breaking changes:
- Why not honour what was parsed for normalized serialization?
- Why keep serializing `hdkeypath`'s hardened paths with apostrophe for legacy wallet but not descriptor wallets or elsewhere (like in `decodepsbt`)?

Just to be clea
...

💬 darosior commented on pull request "Switch hardened derivation marker to h (in normalized descriptors and new wallets)":
(https://github.com/bitcoin/bitcoin/pull/26076#discussion_r1185207740)
But so has it in descriptor wallets? Why would it be more ok to make a breaking change for descriptor wallets than for legacy wallet?

💬 darosior commented on pull request "Switch hardened derivation marker to h (in normalized descriptors and new wallets)":
(https://github.com/bitcoin/bitcoin/pull/26076#discussion_r1185237888)
This is already possible on master (and also at least on 24.0.1). This PR does not change that. For instance on a `24.0.1` regtest node:
```
importdescriptors '[{"desc":"pk([00aabbcc/0h/1h]cSWVo8YMehg6STxqw6xGgmMJE6Ac6RCJ7owcrBZRAT7QANtyAAEj)#uqdekwuc","timestamp":"now"}]'
```
works fine. So does:
```
scantxoutset start '["pk([00aabbcc/0h/1h]cSWVo8YMehg6STxqw6xGgmMJE6Ac6RCJ7owcrBZRAT7QANtyAAEj)#uqdekwuc"]'
```

💬 darosior commented on pull request "Switch hardened derivation marker to h (in normalized descriptors and new wallets)":
(https://github.com/bitcoin/bitcoin/pull/26076#discussion_r1185924697)
`decodepsbt` too.

👍 dergoegge approved a pull request: "refactor: Remove need to pass chainparams to BlockManager methods"
(https://github.com/bitcoin/bitcoin/pull/27570#pullrequestreview-1414541195)
Code review ACK fa5d7c39eb992467e43b12db213b27913374fb83