🚀 fanquake merged a pull request: "ci: Bump centos stream 10"
(https://github.com/bitcoin/bitcoin/pull/31593)

👍 willcl-ark approved a pull request: "ci: optionally use local docker build cache"
(https://github.com/bitcoin/bitcoin/pull/31545#pullrequestreview-2562761273)
ACK e87429a2d0f23eb59526d335844fa5ff5b50b21f

🚀 fanquake merged a pull request: "depends: add *FLAGS to gen_id"
(https://github.com/bitcoin/bitcoin/pull/31125)

👍 fanquake approved a pull request: "depends: Override default build type for `libevent`"
(https://github.com/bitcoin/bitcoin/pull/31661#pullrequestreview-2562822492)
ACK d7d3bb1bbcc0d9b03ac1d3b4e3a6a537fcff077d

👋 maflcko's pull request is ready for review: "ci: Enable DEBUG=1 for one GCC-12+ build to catch 117966 regressions"
(https://github.com/bitcoin/bitcoin/pull/31522)

💬 fanquake commented on pull request "depends: Override default build type for `libevent`":
(https://github.com/bitcoin/bitcoin/pull/31661#issuecomment-2602890757)
Spoke too soon. This change is not deterministic.

Guix Build (aarch64):
```bash
d5d3cf8a8cec671bccc5d1dee03f05f67dee52dfd543295d93e71b1338ae6abd guix-build-d7d3bb1bbcc0/output/aarch64-linux-gnu/SHA256SUMS.part
f5f224be7a011f1465f995bb21a9f3af18567911272d795a937913370012d83f guix-build-d7d3bb1bbcc0/output/aarch64-linux-gnu/bitcoin-d7d3bb1bbcc0-aarch64-linux-gnu-debug.tar.gz
9e2e815f19be9f7e8480ce5c5bd2443b703e5134667ed3feb57fd2cd75ad9dae guix-build-d7d3bb1bbcc0/output/aarch64-linux-gnu/
...

💬 fanquake commented on pull request "guix: use GCC 13 to build releases":
(https://github.com/bitcoin/bitcoin/pull/29881#issuecomment-2602897865)
Changed the CI changes here, the win64 job is now `debian:trixie`, which matches Guix with GCC 13.3.0.

💬 maflcko commented on pull request "guix: use GCC 13 to build releases":
(https://github.com/bitcoin/bitcoin/pull/29881#discussion_r1922678938)
Is there any insurance that debian won't bump this to gcc 14 as well? Seems better to stick to 13.2, than to silently go to 14?

💬 fanquake commented on pull request "guix: use GCC 13 to build releases":
(https://github.com/bitcoin/bitcoin/pull/29881#discussion_r1922692886)
Even though `https://packages.ubuntu.com/noble/g++-arm-linux-gnueabihf` says 13.2.0, the actual compiler is 13.3.0: https://packages.ubuntu.com/noble/g++-13-arm-linux-gnueabihf.
```bash
g++ --version
g++ (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
```

💬 fanquake commented on pull request "guix: use GCC 13 to build releases":
(https://github.com/bitcoin/bitcoin/pull/29881#discussion_r1922697819)
I was thinking this might also be needed if we want to test the newer runtime in future, but given that isn't happening yet, will just return this to `nobel`.

🤔 BrandonOdiwuor reviewed a pull request: "consensus: Remove checkpoints (take 2)"
(https://github.com/bitcoin/bitcoin/pull/31649#pullrequestreview-2562980692)
Concept ACK

⚠️ mohammwdofficial opened an issue: "Adminator default server"
(https://github.com/bitcoin/bitcoin/issues/31692)
bitcoin:bc1qw3e6zhc5ddta9suqulfjqy7w0l670nuv883y3z?label=bc1qw3e6zhc5ddta9suqulfjqy7w0l670nuv883y3z

💬 mohammwdofficial commented on issue "Adminator default server":
(https://github.com/bitcoin/bitcoin/issues/31692#issuecomment-2603044203)
Created

✅ fanquake closed an issue: "Adminator default server"
(https://github.com/bitcoin/bitcoin/issues/31692)

:lock: fanquake locked an issue: "Adminator default server"
(https://github.com/bitcoin/bitcoin/issues/31692)

💬 Sjors commented on pull request "Add multiprocess binaries to release build (except Windows, OpenBSD)":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2603048215)
Trivial rebase after #31657.

💬 fjahr commented on pull request "Embed default ASMap as binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r1922755863)
I guess you are right, I probably got a bit too caught up in this thinking that there should be an easier way to keep it consistent. I have removed that backwards compatibility code and updated the test.

💬 l0rinc commented on pull request "optimization: `CheckBlock` input duplicate detection":
(https://github.com/bitcoin/bitcoin/pull/31682#issuecomment-2603071270)
> it is called whenever a tx is validated (so also during mempool acceptance)

Updated the description, thanks.

> how much this improves transaction validation as a whole

I can only optimize small parts of these, step-by-step. This was the next part I found that could be cheaply sped up (having preexisting tests, benchmarks - signaling that others were also interested in it).

I have created a `chainman.ProcessTransaction` benchmark locally (will commit separately, not strictly relate
...

📝 rex4539 opened a pull request: "bench: fix used file that is not opened"
(https://github.com/bitcoin/bitcoin/pull/31693)
Fixes
```
src/bench/load_external.cpp:57:17: error: Used file that is not opened. [useClosedFile]
if (fwrite(ss.data(), 1, ss.size(), file) != ss.size()) {
^
src/bench/load_external.cpp:61:9: error: Used file that is not opened. [useClosedFile]
fclose(file);
^
```

💬 l0rinc commented on pull request "RPC: Fix invalid txid in `gettransaction` example":
(https://github.com/bitcoin/bitcoin/pull/31610#issuecomment-2603113440)
@luke-jr How would using an unconfirmed, ephemeral transaction work in practice here? By the time this is merged, it could be gone or still require `-txindex=1` - or am I missing something here?
Also, a `Use -txindex` error seems more helpful than the current `must be of length 64 (not 63` error (in case they've started without `-txindex`).
Do you have a more reliable approach?